From: Sachin Gupta <quic_sachgupt@quicinc.com>
Document the 'dll-presets' property for MMC device tree bindings.
The 'dll-presets' property defines the DLL configurations for HS400
and HS200 modes.
QC SoCs can have 0 to 4 SDHCI instances, and each one may need
different tuning.
Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 594bd174ff21..f7b3b1ced3ce 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -138,6 +138,11 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
description: platform specific settings for DLL_CONFIG reg.
+ qcom,dll-presets:
+ maxItems: 10
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description: platform specific settings for DLL registers.
+
iommus:
minItems: 1
maxItems: 8
--
2.34.1On 13/10/2025 16:53, Ram Prakash Gupta wrote: > From: Sachin Gupta <quic_sachgupt@quicinc.com> > > Document the 'dll-presets' property for MMC device tree bindings. > The 'dll-presets' property defines the DLL configurations for HS400 > and HS200 modes. > > QC SoCs can have 0 to 4 SDHCI instances, and each one may need > different tuning. > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > index 594bd174ff21..f7b3b1ced3ce 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > @@ -138,6 +138,11 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > description: platform specific settings for DLL_CONFIG reg. > > + qcom,dll-presets: > + maxItems: 10 > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: platform specific settings for DLL registers. One of my questions, never answered in original submission and in your versions, was to see the DTS user of it. I still do not see the DTS user. Best regards, Krzysztof
On Tue, Oct 14, 2025 at 02:06:46AM +0200, Krzysztof Kozlowski wrote: > On 13/10/2025 16:53, Ram Prakash Gupta wrote: > > From: Sachin Gupta <quic_sachgupt@quicinc.com> > > > > Document the 'dll-presets' property for MMC device tree bindings. > > The 'dll-presets' property defines the DLL configurations for HS400 > > and HS200 modes. > > > > QC SoCs can have 0 to 4 SDHCI instances, and each one may need > > different tuning. > > > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > > Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com> > > --- > > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > > index 594bd174ff21..f7b3b1ced3ce 100644 > > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > > @@ -138,6 +138,11 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: platform specific settings for DLL_CONFIG reg. > > > > + qcom,dll-presets: > > + maxItems: 10 > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: platform specific settings for DLL registers. > > One of my questions, never answered in original submission and in your > versions, was to see the DTS user of it. I still do not see the DTS user. There is no answer, so I mark the patch as changes requested. Best regards, Krzysztof
On 10/20/2025 3:39 PM, Krzysztof Kozlowski wrote: > On Tue, Oct 14, 2025 at 02:06:46AM +0200, Krzysztof Kozlowski wrote: >> On 13/10/2025 16:53, Ram Prakash Gupta wrote: >>> From: Sachin Gupta <quic_sachgupt@quicinc.com> >>> >>> Document the 'dll-presets' property for MMC device tree bindings. >>> The 'dll-presets' property defines the DLL configurations for HS400 >>> and HS200 modes. >>> >>> QC SoCs can have 0 to 4 SDHCI instances, and each one may need >>> different tuning. >>> >>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>> Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> index 594bd174ff21..f7b3b1ced3ce 100644 >>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> @@ -138,6 +138,11 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> description: platform specific settings for DLL_CONFIG reg. >>> >>> + qcom,dll-presets: >>> + maxItems: 10 >>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>> + description: platform specific settings for DLL registers. >> One of my questions, never answered in original submission and in your >> versions, was to see the DTS user of it. I still do not see the DTS user. > There is no answer, so I mark the patch as changes requested. > > Best regards, > Krzysztof ok, I will provide this in next patchset. Thanks, Ram >
© 2016 - 2025 Red Hat, Inc.