1. Patchew
  2. linux
  3. [PATCH v2 0/3] Add edp reference clock for lemans
  4. View patch

[PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p

Ritesh Kumar posted 3 patches 3 months, 4 weeks ago
There is a newer version of this series
[PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Ritesh Kumar 3 months, 4 weeks ago 
Add edp reference clock for sa8775p edp phy.

Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
---
 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
index bfc4d75f50ff..b0e4015596de 100644
--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
@@ -73,6 +73,7 @@ allOf:
         compatible:
           enum:
             - qcom,x1e80100-dp-phy
+            - qcom,sa8775p-edp-phy
     then:
       properties:
         clocks:
-- 
2.17.1
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Bjorn Andersson 3 months, 2 weeks ago 
On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> Add edp reference clock for sa8775p edp phy.

Perhaps the eDP ref clock was missed in the initial contribution,
perhaps it wasn't supposed to be described at the time, perhaps the
hardware changed...we can only speculate on the purpose of this patch...

You could change this however, by following
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
and start your commit message with an explanation of the problem you're
trying to solve...

> 
> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>

Please start using your oss.qualcomm.com 

Regards,
Bjorn

> ---
>  Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> index bfc4d75f50ff..b0e4015596de 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> @@ -73,6 +73,7 @@ allOf:
>          compatible:
>            enum:
>              - qcom,x1e80100-dp-phy
> +            - qcom,sa8775p-edp-phy
>      then:
>        properties:
>          clocks:
> -- 
> 2.17.1
>
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Ritesh Kumar 3 months, 2 weeks ago 
On 10/27/2025 10:35 PM, Bjorn Andersson wrote:
> On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> > Add edp reference clock for sa8775p edp phy.
>
> Perhaps the eDP ref clock was missed in the initial contribution,
> perhaps it wasn't supposed to be described at the time, perhaps the
> hardware changed...we can only speculate on the purpose of this patch...
>
> You could change this however, by following
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> and start your commit message with an explanation of the problem you're
> trying to solve...

Sure, will update the commit message giving details of the problem.

> > 
> > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
>
> Please start using your oss.qualcomm.com

Took a note of it.

> Regards,
> Bjorn
>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > index bfc4d75f50ff..b0e4015596de 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > @@ -73,6 +73,7 @@ allOf:
> >          compatible:
> >            enum:
> >              - qcom,x1e80100-dp-phy
> > +            - qcom,sa8775p-edp-phy
> >      then:
> >        properties:
> >          clocks:
> > -- 
> > 2.17.1
> >
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Dmitry Baryshkov 3 months, 4 weeks ago 
On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> Add edp reference clock for sa8775p edp phy.

eDP, PHY.

I'd probably ask to squash both DT binding patches together, but this
might cause cross-subsystem merge issues. I'll leave this to DT
maintainers discretion, whether to require a non-warning-adding patch or
two patches with warnings in the middle of the series.

> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> ---
>  Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> index bfc4d75f50ff..b0e4015596de 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> @@ -73,6 +73,7 @@ allOf:
>          compatible:
>            enum:
>              - qcom,x1e80100-dp-phy
> +            - qcom,sa8775p-edp-phy
>      then:
>        properties:
>          clocks:
> -- 
> 2.17.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Rob Herring 3 months, 3 weeks ago 
On Mon, Oct 13, 2025 at 03:37:47PM +0300, Dmitry Baryshkov wrote:
> On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> > Add edp reference clock for sa8775p edp phy.
> 
> eDP, PHY.
> 
> I'd probably ask to squash both DT binding patches together, but this
> might cause cross-subsystem merge issues. I'll leave this to DT
> maintainers discretion, whether to require a non-warning-adding patch or
> two patches with warnings in the middle of the series.

One patch.

Rob
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Ritesh Kumar 3 months, 2 weeks ago 
On 10/15/2025 8:13 PM, Rob Herring wrote:
> On Mon, Oct 13, 2025 at 03:37:47PM +0300, Dmitry Baryshkov wrote:
> > On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> > > Add edp reference clock for sa8775p edp phy.
> > 
> > eDP, PHY.
> > 
> > I'd probably ask to squash both DT binding patches together, but this
> > might cause cross-subsystem merge issues. I'll leave this to DT
> > maintainers discretion, whether to require a non-warning-adding patch or
> > two patches with warnings in the middle of the series.
>
> One patch.

Sure, will update a single patch for DT bindings.

> Rob
>
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Dmitry Baryshkov 3 months, 4 weeks ago 
On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> Add edp reference clock for sa8775p edp phy.
> 
> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> ---
>  Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> index bfc4d75f50ff..b0e4015596de 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> @@ -73,6 +73,7 @@ allOf:
>          compatible:
>            enum:
>              - qcom,x1e80100-dp-phy
> +            - qcom,sa8775p-edp-phy

Usually such lists are sorted.

>      then:
>        properties:
>          clocks:
> -- 
> 2.17.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p
Posted by Ritesh Kumar 3 months, 2 weeks ago 
On 10/13/2025 6:04 PM, Dmitry Baryshkov wrote:
> On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> > Add edp reference clock for sa8775p edp phy.
> > 
> > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > index bfc4d75f50ff..b0e4015596de 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > @@ -73,6 +73,7 @@ allOf:
> >          compatible:
> >            enum:
> >              - qcom,x1e80100-dp-phy
> > +            - qcom,sa8775p-edp-phy
>
> Usually such lists are sorted.

Sure, will update in next version.

>
> >      then:
> >        properties:
> >          clocks:
> > -- 
> > 2.17.1
> > 
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.