[PATCH -next] liveupdate: kho: remove unneeded semicolon

Jiapeng Chong posted 1 patch 2 months, 1 week ago
kernel/liveupdate/kexec_handover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] liveupdate: kho: remove unneeded semicolon
Posted by Jiapeng Chong 2 months, 1 week ago
No functional modification involved.

./kernel/liveupdate/kexec_handover.c:1155:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=26158
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 kernel/liveupdate/kexec_handover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index 5da21f1510cc..c87d00c40c82 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -1152,7 +1152,7 @@ static int __kho_finalize(void)
 		err |= fdt_begin_node(root, fdt->name);
 		err |= fdt_property(root, PROP_SUB_FDT, &phys, sizeof(phys));
 		err |= fdt_end_node(root);
-	};
+	}
 	mutex_unlock(&kho_out.fdts_lock);
 
 	err |= fdt_end_node(root);
-- 
2.43.5
Re: [PATCH -next] liveupdate: kho: remove unneeded semicolon
Posted by Pratyush Yadav 2 months ago
On Mon, Oct 13 2025, Jiapeng Chong wrote:

> No functional modification involved.
>
> ./kernel/liveupdate/kexec_handover.c:1155:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=26158
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Looks like it comes from Pasha's series
https://lore.kernel.org/lkml/20251007033100.836886-4-pasha.tatashin@soleen.com/

I think this fix can be folded into the patch since it isn't merged yet.

> ---
>  kernel/liveupdate/kexec_handover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 5da21f1510cc..c87d00c40c82 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -1152,7 +1152,7 @@ static int __kho_finalize(void)
>  		err |= fdt_begin_node(root, fdt->name);
>  		err |= fdt_property(root, PROP_SUB_FDT, &phys, sizeof(phys));
>  		err |= fdt_end_node(root);
> -	};
> +	}
>  	mutex_unlock(&kho_out.fdts_lock);
>  
>  	err |= fdt_end_node(root);

-- 
Regards,
Pratyush Yadav