[v1] dt-bindings: usb: qcom,snps-dwc3: Fix bindings for X1E80100

[PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix bindings for X1E80100

Posted by Krishna Kurapati 2 months, 1 week ago

Add the missing multiport controller binding to target list.

Fix minItems for interrupt-names to avoid the following error on High
Speed controller:

usb@a200000: interrupt-names: ['dwc_usb3', 'pwr_event',
'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
The above issues were found when effort was being put in to
flatten usb controller nodes on X1E80100.

 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index dfd084ed9024..d49a58d5478f 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -68,6 +68,7 @@ properties:
           - qcom,sm8550-dwc3
           - qcom,sm8650-dwc3
           - qcom,x1e80100-dwc3
+          - qcom,x1e80100-dwc3-mp
       - const: qcom,snps-dwc3
 
   reg:
@@ -460,8 +461,10 @@ allOf:
     then:
       properties:
         interrupts:
+          minItems: 4
           maxItems: 5
         interrupt-names:
+          minItems: 4
           items:
             - const: dwc_usb3
             - const: pwr_event
-- 
2.34.1

Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix bindings for X1E80100

Posted by Krzysztof Kozlowski 2 months, 1 week ago

On 13/10/2025 03:13, Krishna Kurapati wrote:
> Add the missing multiport controller binding to target list.
> 
> Fix minItems for interrupt-names to avoid the following error on High
> Speed controller:
> 
> usb@a200000: interrupt-names: ['dwc_usb3', 'pwr_event',
> 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short

Don't wrap error messages.

> 

Missing Fixes tag.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix bindings for X1E80100

Posted by Krishna Kurapati PSSNV 2 months, 1 week ago


On 10/13/2025 6:49 AM, Krzysztof Kozlowski wrote:
> On 13/10/2025 03:13, Krishna Kurapati wrote:
>> Add the missing multiport controller binding to target list.
>>
>> Fix minItems for interrupt-names to avoid the following error on High
>> Speed controller:
>>
>> usb@a200000: interrupt-names: ['dwc_usb3', 'pwr_event',
>> 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
> 
> Don't wrap error messages.
> 
>>
> 
> Missing Fixes tag.
> 
> 

Thanks for the review Krzysztof. Will update and send v2.

Regards,
Krishna,