media: Use %pe format specifier

[PATCH 25/32] media: imx8mq-mipi-csi2: Use %pe format specifier

Posted by Ricardo Ribalda 2 months, 1 week ago

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/nxp/imx8mq-mipi-csi2.c:422:23-30: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
index 3a4645f59a44028fdca82a4d8393e1a0a6ba88f0..d333ff43539f061b8b9cf88af2cda8c44b3ec2a9 100644
--- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
+++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
@@ -418,8 +418,8 @@ static int imx8mq_mipi_csi_calc_hs_settle(struct csi_state *state,
 
 	src_pad = media_entity_remote_source_pad_unique(&sd_state->sd->entity);
 	if (IS_ERR(src_pad)) {
-		dev_err(state->dev, "can't get source pad of %s (%ld)\n",
-			sd_state->sd->name, PTR_ERR(src_pad));
+		dev_err(state->dev, "can't get source pad of %s (%pe)\n",
+			sd_state->sd->name, src_pad);
 		return PTR_ERR(src_pad);
 	}
 

-- 
2.51.0.760.g7b8bcc2412-goog

Re: [PATCH 25/32] media: imx8mq-mipi-csi2: Use %pe format specifier

Posted by Martin Kepplinger-Novakovic 2 months ago

Am Montag, dem 13.10.2025 um 14:15 +0000 schrieb Ricardo Ribalda:
> The %pe format specifier is designed to print error pointers. It
> prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR().
> 
> This patch fixes this cocci report:
> ./platform/nxp/imx8mq-mipi-csi2.c:422:23-30: WARNING: Consider using
> %pe to print PTR_ERR()
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> index
> 3a4645f59a44028fdca82a4d8393e1a0a6ba88f0..d333ff43539f061b8b9cf88af2c
> da8c44b3ec2a9 100644
> --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> @@ -418,8 +418,8 @@ static int imx8mq_mipi_csi_calc_hs_settle(struct
> csi_state *state,
>  
>  	src_pad = media_entity_remote_source_pad_unique(&sd_state-
> >sd->entity);
>  	if (IS_ERR(src_pad)) {
> -		dev_err(state->dev, "can't get source pad of %s
> (%ld)\n",
> -			sd_state->sd->name, PTR_ERR(src_pad));
> +		dev_err(state->dev, "can't get source pad of %s
> (%pe)\n",
> +			sd_state->sd->name, src_pad);
>  		return PTR_ERR(src_pad);
>  	}
>  

Reviewed-by: Martin Kepplinger-Novakovic <martink@posteo.de>

thanks you,

                             martin