Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.

Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
---
 arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
index b523a868c4ad..78e351eb787a 100644
--- a/arch/arm/boot/dts/airoha/en7523.dtsi
+++ b/arch/arm/boot/dts/airoha/en7523.dtsi
@@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
 			#interrupt-cells = <1>;
 		};
 	};
+
+	spi_ctrl: spi@1fa10000 {
+		compatible = "airoha,en7581-snand";
+		reg = <0x1fa10000 0x140>,
+		      <0x1fa11000 0x160>;
+
+		clocks = <&scu EN7523_CLK_SPI>;
+		clock-names = "spi";
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		nand: nand@0 {
+			compatible = "spi-nand";
+			reg = <0>;
+			spi-max-frequency = <50000000>;
+			spi-tx-bus-width = <1>;
+			spi-rx-bus-width = <2>;
+		};
+	};
+
 };
-- 
2.51.0

On 10/10/2025 22:45, Mikhail Kshevetskiy wrote:
> Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> ---
>  arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
> index b523a868c4ad..78e351eb787a 100644
> --- a/arch/arm/boot/dts/airoha/en7523.dtsi
> +++ b/arch/arm/boot/dts/airoha/en7523.dtsi
> @@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
>  			#interrupt-cells = <1>;
>  		};
>  	};
> +
> +	spi_ctrl: spi@1fa10000 {
> +		compatible = "airoha,en7581-snand";

NAK, now I found this... Respond to comments instead of ignoring them.

Three versions within few hours, that's not acceptable. Outside of the
merge window the expectation is minimum 24h difference. Within merge
window this is just spamming.

Best regards,
Krzysztof

On 11.10.2025 02:42, Krzysztof Kozlowski wrote:
> On 10/10/2025 22:45, Mikhail Kshevetskiy wrote:
>> Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.
>>
>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>> ---
>>  arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
>> index b523a868c4ad..78e351eb787a 100644
>> --- a/arch/arm/boot/dts/airoha/en7523.dtsi
>> +++ b/arch/arm/boot/dts/airoha/en7523.dtsi
>> @@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
>>  			#interrupt-cells = <1>;
>>  		};
>>  	};
>> +
>> +	spi_ctrl: spi@1fa10000 {
>> +		compatible = "airoha,en7581-snand";
> NAK, now I found this... Respond to comments instead of ignoring them.
>
> Three versions within few hours, that's not acceptable. Outside of the
> merge window the expectation is minimum 24h difference. Within merge
> window this is just spamming.


I already lost any hope to merge this to linux-3.18, so no problem.

Could you and Rob explain me this compatible issue? I got a feeling that
Rob telling me to keep "airoha,en7581-snand" compatible while you are
telling the opposite. As for me the use of "airoha,en7523-snand" or
maybe "airoha,en75xx-snand" for both en7523 & en7581 chips is the best.

Is there any policy? Could you provide a link?

Regards,
Mikhail Kshevetskiy


>
> Best regards,
> Krzysztof

On 11/10/2025 07:01, Mikhail Kshevetskiy wrote:
> On 11.10.2025 02:42, Krzysztof Kozlowski wrote:
>> On 10/10/2025 22:45, Mikhail Kshevetskiy wrote:
>>> Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.
>>>
>>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>>> ---
>>>  arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
>>> index b523a868c4ad..78e351eb787a 100644
>>> --- a/arch/arm/boot/dts/airoha/en7523.dtsi
>>> +++ b/arch/arm/boot/dts/airoha/en7523.dtsi
>>> @@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
>>>  			#interrupt-cells = <1>;
>>>  		};
>>>  	};
>>> +
>>> +	spi_ctrl: spi@1fa10000 {
>>> +		compatible = "airoha,en7581-snand";
>> NAK, now I found this... Respond to comments instead of ignoring them.
>>
>> Three versions within few hours, that's not acceptable. Outside of the
>> merge window the expectation is minimum 24h difference. Within merge
>> window this is just spamming.
> 
> 
> I already lost any hope to merge this to linux-3.18, so no problem.
> 
> Could you and Rob explain me this compatible issue? I got a feeling that
> Rob telling me to keep "airoha,en7581-snand" compatible while you are
> telling the opposite. As for me the use of "airoha,en7523-snand" or
> maybe "airoha,en75xx-snand" for both en7523 & en7581 chips is the best.
> 
> Is there any policy? Could you provide a link?

The policy is described in writing bindings. I also explained it in
greater details in my recent OSSEU introductory talk. You need two
compatibles.

Best regards,
Krzysztof