hwmon: gpd-fan: Fix return value when platform_get_resource() fails

[PATCH] hwmon: gpd-fan: Fix return value when platform_get_resource() fails

Posted by Harshit Mogalapalli 2 months, 1 week ago

When platform_get_resource() fails it returns NULL and not an error
pointer, accordingly change the error handling.

Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
This is based on static analysis with Smatch, only compile tested.
---
 drivers/hwmon/gpd-fan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
index 644dc3ca9df7..eebe39ef9677 100644
--- a/drivers/hwmon/gpd-fan.c
+++ b/drivers/hwmon/gpd-fan.c
@@ -615,8 +615,8 @@ static int gpd_fan_probe(struct platform_device *pdev)
 	const struct device *hwdev;
 
 	res = platform_get_resource(pdev, IORESOURCE_IO, 0);
-	if (IS_ERR(res))
-		return dev_err_probe(dev, PTR_ERR(res),
+	if (!res)
+		return dev_err_probe(dev, -EINVAL,
 				     "Failed to get platform resource\n");
 
 	region = devm_request_region(dev, res->start,
-- 
2.39.3

Re: [PATCH] hwmon: gpd-fan: Fix return value when platform_get_resource() fails

Posted by Guenter Roeck 2 months, 1 week ago

On Fri, Oct 10, 2025 at 01:43:59PM -0700, Harshit Mogalapalli wrote:
> When platform_get_resource() fails it returns NULL and not an error
> pointer, accordingly change the error handling.
> 
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

Applied.

Guenter

Re: [PATCH] hwmon: gpd-fan: Fix return value when platform_get_resource() fails

Posted by Cryolitia PukNgae 2 months, 1 week ago

On 11/10/2025 04.43, Harshit Mogalapalli wrote:
> When platform_get_resource() fails it returns NULL and not an error
> pointer, accordingly change the error handling.
> 
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis with Smatch, only compile tested.
> ---
>  drivers/hwmon/gpd-fan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
> index 644dc3ca9df7..eebe39ef9677 100644
> --- a/drivers/hwmon/gpd-fan.c
> +++ b/drivers/hwmon/gpd-fan.c
> @@ -615,8 +615,8 @@ static int gpd_fan_probe(struct platform_device *pdev)
>  	const struct device *hwdev;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_IO, 0);
> -	if (IS_ERR(res))
> -		return dev_err_probe(dev, PTR_ERR(res),
> +	if (!res)
> +		return dev_err_probe(dev, -EINVAL,
>  				     "Failed to get platform resource\n");
>  
>  	region = devm_request_region(dev, res->start,

Has it already been replaced by hwmon: gpd-fan: Fix error handling in gpd_fan_probe() ?

thx

Link: https://lore.kernel.org/all/20251010204447.94343-1-harshit.m.mogalapalli@oracle.com/

Best regards,
Cryolitia PukNgae