[PATCH] w1: ds28e17: Replace deprecated strcpy + strcat in w1_f19_add_slave

Thorsten Blum posted 1 patch 2 months, 1 week ago
drivers/w1/slaves/w1_ds28e17.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] w1: ds28e17: Replace deprecated strcpy + strcat in w1_f19_add_slave
Posted by Thorsten Blum 2 months, 1 week ago
strcpy() is deprecated and using strcat() is discouraged. Replace them with
scnprintf().  No functional changes.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/w1/slaves/w1_ds28e17.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/slaves/w1_ds28e17.c b/drivers/w1/slaves/w1_ds28e17.c
index 5738cbce1a37..e53bc41bde3c 100644
--- a/drivers/w1/slaves/w1_ds28e17.c
+++ b/drivers/w1/slaves/w1_ds28e17.c
@@ -719,8 +719,8 @@ static int w1_f19_add_slave(struct w1_slave *sl)
 	data->adapter.owner      = THIS_MODULE;
 	data->adapter.algo       = &w1_f19_i2c_algorithm;
 	data->adapter.algo_data  = sl;
-	strcpy(data->adapter.name, "w1-");
-	strcat(data->adapter.name, sl->name);
+	scnprintf(data->adapter.name, sizeof(data->adapter.name), "w1-%s",
+		  sl->name);
 	data->adapter.dev.parent = &sl->dev;
 	data->adapter.quirks     = &w1_f19_i2c_adapter_quirks;
 
-- 
2.51.0
Re: [PATCH] w1: ds28e17: Replace deprecated strcpy + strcat in w1_f19_add_slave
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On Thu, 09 Oct 2025 19:45:12 +0200, Thorsten Blum wrote:
> strcpy() is deprecated and using strcat() is discouraged. Replace them with
> scnprintf().  No functional changes.
> 
> 

Applied, thanks!

[1/1] w1: ds28e17: Replace deprecated strcpy + strcat in w1_f19_add_slave
      https://git.kernel.org/krzk/linux-w1/c/f3c6353d801a9826e234ad477af08b09a98d888b

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>