[v1] Add support for clean shutdown with MSHV

[PATCH 0/2] Add support for clean shutdown with MSHV

Posted by Praveen K Paladugu 2 months, 1 week ago

Add support for clean shutdown of the root partition when running on MSHV
hypervisor.

Praveen K Paladugu (2):
  hyperv: Add definitions for MSHV sleep state configuration
  hyperv: Enable clean shutdown for root partition with MSHV

 arch/x86/hyperv/hv_init.c      |   7 ++
 drivers/hv/hv_common.c         | 118 +++++++++++++++++++++++++++++++++
 include/asm-generic/mshyperv.h |   1 +
 include/hyperv/hvgdk_mini.h    |   4 +-
 include/hyperv/hvhdk_mini.h    |  33 +++++++++
 5 files changed, 162 insertions(+), 1 deletion(-)

-- 
2.51.0

Re: [PATCH 0/2] Add support for clean shutdown with MSHV

Posted by Stanislav Kinsburskii 2 months, 1 week ago

On Thu, Oct 09, 2025 at 10:58:49AM -0500, Praveen K Paladugu wrote:
> Add support for clean shutdown of the root partition when running on MSHV
> hypervisor.
> 
> Praveen K Paladugu (2):
>   hyperv: Add definitions for MSHV sleep state configuration
>   hyperv: Enable clean shutdown for root partition with MSHV
> 

There is no need to split this logic to two patches: the first one
doesn't make sense without the second one, so it would be better to
squash them.

Thanks,
Stanislav

>  arch/x86/hyperv/hv_init.c      |   7 ++
>  drivers/hv/hv_common.c         | 118 +++++++++++++++++++++++++++++++++
>  include/asm-generic/mshyperv.h |   1 +
>  include/hyperv/hvgdk_mini.h    |   4 +-
>  include/hyperv/hvhdk_mini.h    |  33 +++++++++
>  5 files changed, 162 insertions(+), 1 deletion(-)
> 
> -- 
> 2.51.0
>

Re: [PATCH 0/2] Add support for clean shutdown with MSHV

Posted by Wei Liu 2 months ago

On Thu, Oct 09, 2025 at 03:26:14PM -0700, Stanislav Kinsburskii wrote:
> On Thu, Oct 09, 2025 at 10:58:49AM -0500, Praveen K Paladugu wrote:
> > Add support for clean shutdown of the root partition when running on MSHV
> > hypervisor.
> > 
> > Praveen K Paladugu (2):
> >   hyperv: Add definitions for MSHV sleep state configuration
> >   hyperv: Enable clean shutdown for root partition with MSHV
> > 
> 
> There is no need to split this logic to two patches: the first one
> doesn't make sense without the second one, so it would be better to
> squash them.
> 

I would rather keep them separate. It is a bit easier to pick out only
the header changes that way.

Wei

> Thanks,
> Stanislav
> 
> >  arch/x86/hyperv/hv_init.c      |   7 ++
> >  drivers/hv/hv_common.c         | 118 +++++++++++++++++++++++++++++++++
> >  include/asm-generic/mshyperv.h |   1 +
> >  include/hyperv/hvgdk_mini.h    |   4 +-
> >  include/hyperv/hvhdk_mini.h    |  33 +++++++++
> >  5 files changed, 162 insertions(+), 1 deletion(-)
> > 
> > -- 
> > 2.51.0
> >

Re: [PATCH 0/2] Add support for clean shutdown with MSHV

Posted by Praveen K Paladugu 2 months ago


On 10/13/2025 2:05 PM, Wei Liu wrote:
> On Thu, Oct 09, 2025 at 03:26:14PM -0700, Stanislav Kinsburskii wrote:
>> On Thu, Oct 09, 2025 at 10:58:49AM -0500, Praveen K Paladugu wrote:
>>> Add support for clean shutdown of the root partition when running on MSHV
>>> hypervisor.
>>>
>>> Praveen K Paladugu (2):
>>>    hyperv: Add definitions for MSHV sleep state configuration
>>>    hyperv: Enable clean shutdown for root partition with MSHV
>>>
>>
>> There is no need to split this logic to two patches: the first one
>> doesn't make sense without the second one, so it would be better to
>> squash them.
>>
> 
> I would rather keep them separate. It is a bit easier to pick out only
> the header changes that way.
> 
Ack.
> Wei
> 
>> Thanks,
>> Stanislav
>>
>>>   arch/x86/hyperv/hv_init.c      |   7 ++
>>>   drivers/hv/hv_common.c         | 118 +++++++++++++++++++++++++++++++++
>>>   include/asm-generic/mshyperv.h |   1 +
>>>   include/hyperv/hvgdk_mini.h    |   4 +-
>>>   include/hyperv/hvhdk_mini.h    |  33 +++++++++
>>>   5 files changed, 162 insertions(+), 1 deletion(-)
>>>
>>> -- 
>>> 2.51.0
>>>