Add edp reference clock for qcom,edp-phy which is required
to be enabled before eDP PHY initialization.
Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
---
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
index eb97181cbb95..95e9210f4163 100644
--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
@@ -37,12 +37,13 @@ properties:
- description: PLL register block
clocks:
- maxItems: 2
+ maxItems: 3
clock-names:
items:
- const: aux
- const: cfg_ahb
+ - const: edp_ref
"#clock-cells":
const: 1
@@ -75,8 +76,8 @@ examples:
<0x0aec2600 0xa0>,
<0x0aec2000 0x19c>;
- clocks = <&dispcc 0>, <&dispcc 1>;
- clock-names = "aux", "cfg_ahb";
+ clocks = <&dispcc 0>, <&dispcc 1>, <&dispcc 2>;
+ clock-names = "aux", "cfg_ahb", "edp_ref";
#clock-cells = <1>;
#phy-cells = <0>;
--
2.17.1
On Thu, 09 Oct 2025 12:41:23 +0530, Ritesh Kumar wrote: > Add edp reference clock for qcom,edp-phy which is required > to be enabled before eDP PHY initialization. > > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com> > --- > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: phy@aec2a00 (qcom,sa8775p-edp-phy): clock-names: ['aux', 'cfg_ahb'] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,edp-phy.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: phy@aec2a00 (qcom,sa8775p-edp-phy): clocks: [[4294967295, 11], [4294967295, 1]] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,edp-phy.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.example.dtb: phy@aec2a00 (qcom,sc7280-edp-phy): clock-names: ['aux', 'cfg_ahb'] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,edp-phy.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.example.dtb: phy@aec2a00 (qcom,sc7280-edp-phy): clocks: [[4294967295, 0], [4294967295, 183]] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,edp-phy.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251009071127.26026-2-quic_riteshk@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 09/10/2025 16:11, Ritesh Kumar wrote: > Add edp reference clock for qcom,edp-phy which is required > to be enabled before eDP PHY initialization. > No, you need to first look what is happening in community. https://lore.kernel.org/all/20250909-phy-qcom-edp-add-missing-refclk-v3-1-4ec55a0512ab@linaro.org/ Best regards, Krzysztof
On 10/9/2025 2:57 PM, Krzysztof Kozlowski wrote: > On 09/10/2025 16:11, Ritesh Kumar wrote: > > Add edp reference clock for qcom,edp-phy which is required > > to be enabled before eDP PHY initialization. > > > > No, you need to first look what is happening in community. > > https://lore.kernel.org/all/20250909-phy-qcom-edp-add-missing-refclk-v3-1-4ec55a0512ab@linaro.org/ Thanks for the patch. I will pick this and add support for lemans and post v2. > > Best regards, > Krzysztof
© 2016 - 2025 Red Hat, Inc.