iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb

[PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb

Posted by Aashish Sharma 2 months, 1 week ago

Invalidation hint (ih) in the function 'qi_desc_iotlb' is
initialized to zero and never used. It is embedded in the 0th bit
of the 'addr' parameter. Get the correct 'ih' value from there.

Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition")
Signed-off-by: Aashish Sharma <aashish@aashishsharma.net>
---
 drivers/iommu/intel/iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h
index 3056583d7f56..dcc5466d35f9 100644
--- a/drivers/iommu/intel/iommu.h
+++ b/drivers/iommu/intel/iommu.h
@@ -1097,7 +1097,7 @@ static inline void qi_desc_iotlb(struct intel_iommu *iommu, u16 did, u64 addr,
 				 struct qi_desc *desc)
 {
 	u8 dw = 0, dr = 0;
-	int ih = 0;
+	int ih = addr & 1;
 
 	if (cap_write_drain(iommu->cap))
 		dw = 1;
-- 
2.51.0.710.ga91ca5db03-goog

Re: [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb

Posted by Baolu Lu 1 month ago

On 10/9/25 09:09, Aashish Sharma wrote:
> Invalidation hint (ih) in the function 'qi_desc_iotlb' is
> initialized to zero and never used. It is embedded in the 0th bit
> of the 'addr' parameter. Get the correct 'ih' value from there.
> 
> Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition")
> Signed-off-by: Aashish Sharma<aashish@aashishsharma.net>
> ---
>   drivers/iommu/intel/iommu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Queued for v6.19-rc1. Thanks!