The gs101-pmu binding is going to acquire various additional (pattern)
properties that don't apply to other PMUs supported by this binding.
To enable this, move google,gs101-pmu into a separate binding.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
.../bindings/soc/google/google,gs101-pmu.yaml | 67 ++++++++++++++++++++++
.../bindings/soc/samsung/exynos-pmu.yaml | 20 -------
MAINTAINERS | 1 +
3 files changed, 68 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..209ee2f80d449c3eec568188898b3c6f7ae0ddd4
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/samsung/google,gs101-pmu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google GS101 Power Management Unit (PMU)
+
+maintainers:
+ - André Draszik <andre.draszik@linaro.org>
+
+# Custom select to avoid matching all nodes with 'syscon'
+select:
+ properties:
+ compatible:
+ contains:
+ const: google,gs101-pmu
+ required:
+ - compatible
+
+properties:
+ compatible:
+ items:
+ - const: google,gs101-pmu
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ reboot-mode:
+ $ref: /schemas/power/reset/syscon-reboot-mode.yaml
+ type: object
+ description:
+ Reboot mode to alter bootloader behavior for the next boot
+
+ syscon-poweroff:
+ $ref: /schemas/power/reset/syscon-poweroff.yaml#
+ type: object
+ description:
+ Node for power off method
+
+ syscon-reboot:
+ $ref: /schemas/power/reset/syscon-reboot.yaml#
+ type: object
+ description:
+ Node for reboot method
+
+ google,pmu-intr-gen-syscon:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Phandle to PMU interrupt generation interface.
+
+required:
+ - compatible
+ - reg
+ - google,pmu-intr-gen-syscon
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ system-controller@17460000 {
+ compatible = "google,gs101-pmu", "syscon";
+ reg = <0x17460000 0x10000>;
+
+ google,pmu-intr-gen-syscon = <&pmu_intr_gen>;
+ };
diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..83f18a92fa1c4de75a90f00475cf17d5f0b652e4 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -15,7 +15,6 @@ select:
compatible:
contains:
enum:
- - google,gs101-pmu
- samsung,exynos3250-pmu
- samsung,exynos4210-pmu
- samsung,exynos4212-pmu
@@ -36,7 +35,6 @@ properties:
oneOf:
- items:
- enum:
- - google,gs101-pmu
- samsung,exynos3250-pmu
- samsung,exynos4210-pmu
- samsung,exynos4212-pmu
@@ -129,11 +127,6 @@ properties:
description:
Node for reboot method
- google,pmu-intr-gen-syscon:
- $ref: /schemas/types.yaml#/definitions/phandle
- description:
- Phandle to PMU interrupt generation interface.
-
required:
- compatible
- reg
@@ -194,19 +187,6 @@ allOf:
properties:
dp-phy: false
- - if:
- properties:
- compatible:
- contains:
- enum:
- - google,gs101-pmu
- then:
- required:
- - google,pmu-intr-gen-syscon
- else:
- properties:
- google,pmu-intr-gen-syscon: false
-
examples:
- |
#include <dt-bindings/clock/exynos5250.h>
diff --git a/MAINTAINERS b/MAINTAINERS
index 3439485437117aaffbe61b709468348231ca3cc4..9cf5b9300d4d96bfed8d1a75cc806925a884744b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10596,6 +10596,7 @@ S: Maintained
P: Documentation/process/maintainer-soc-clean-dts.rst
C: irc://irc.oftc.net/pixel6-kernel-dev
F: Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
+F: Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
F: Documentation/devicetree/bindings/soc/google/google,gs101-pmu-intr-gen.yaml
F: arch/arm64/boot/dts/exynos/google/
F: drivers/clk/samsung/clk-gs101.c
--
2.51.0.710.ga91ca5db03-goog
On Thu, Oct 09, 2025 at 04:25:04PM +0100, André Draszik wrote: > The gs101-pmu binding is going to acquire various additional (pattern) > properties that don't apply to other PMUs supported by this binding. > > To enable this, move google,gs101-pmu into a separate binding. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > .../bindings/soc/google/google,gs101-pmu.yaml | 67 ++++++++++++++++++++++ > .../bindings/soc/samsung/exynos-pmu.yaml | 20 ------- > MAINTAINERS | 1 + > 3 files changed, 68 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..209ee2f80d449c3eec568188898b3c6f7ae0ddd4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/samsung/google,gs101-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google GS101 Power Management Unit (PMU) > + > +maintainers: > + - André Draszik <andre.draszik@linaro.org> > + > +# Custom select to avoid matching all nodes with 'syscon' That's not necessary. > +select: > + properties: > + compatible: > + contains: > + const: google,gs101-pmu > + required: > + - compatible
On Thu, 09 Oct 2025 16:25:04 +0100, André Draszik wrote: > The gs101-pmu binding is going to acquire various additional (pattern) > properties that don't apply to other PMUs supported by this binding. > > To enable this, move google,gs101-pmu into a separate binding. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > .../bindings/soc/google/google,gs101-pmu.yaml | 67 ++++++++++++++++++++++ > .../bindings/soc/samsung/exynos-pmu.yaml | 20 ------- > MAINTAINERS | 1 + > 3 files changed, 68 insertions(+), 20 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/soc/samsung/google,gs101-pmu.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251009-gs101-pd-v2-2-3f4a6db2af39@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, 2025-10-10 at 07:23 -0500, Rob Herring (Arm) wrote: > > On Thu, 09 Oct 2025 16:25:04 +0100, André Draszik wrote: > > The gs101-pmu binding is going to acquire various additional (pattern) > > properties that don't apply to other PMUs supported by this binding. > > > > To enable this, move google,gs101-pmu into a separate binding. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > > .../bindings/soc/google/google,gs101-pmu.yaml | 67 ++++++++++++++++++++++ > > .../bindings/soc/samsung/exynos-pmu.yaml | 20 ------- > > MAINTAINERS | 1 + > > 3 files changed, 68 insertions(+), 20 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml: $id: Cannot determine base > path from $id, relative path/filename doesn't match actual path or filename > $id: http://devicetree.org/schemas/soc/samsung/google,gs101-pmu.yaml > file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml I moved the file ultimately but had restricted to samsung using DT_SCHEMA_FILES= during my binding check run :-( A.
© 2016 - 2026 Red Hat, Inc.