[PATCH 2/5] dt-bindings: crypto: ice: add freq-table-hz property to ICE schema

Abhinaba Rakshit posted 5 patches 2 months, 1 week ago
[PATCH 2/5] dt-bindings: crypto: ice: add freq-table-hz property to ICE schema
Posted by Abhinaba Rakshit 2 months, 1 week ago
Introduce the 'freq-table-hz' property to specify the minimum and maximum
frequencies supported by the Inline Crypto Engine (ICE) clock.

This property is added to the ICE device node because the ICE clock is
managed independently by the ICE driver and requires frequency information
to be available in the device tree for the proper configuration.

Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
---
 .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml       | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index 08fe6a707a3714ff11d01b36afc8a2aab1ad490c..88bef1d38013fc7d0e6842e370b2adb3bf3e8735 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -29,6 +29,11 @@ properties:
   clocks:
     maxItems: 1
 
+  freq-table-hz:
+    items:
+      - description: Minimum frequency for ICE core clock in Hz
+      - description: Maximum frequency for ICE core clock in Hz
+
 required:
   - compatible
   - reg
@@ -45,5 +50,6 @@ examples:
                    "qcom,inline-crypto-engine";
       reg = <0x01d88000 0x8000>;
       clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
+      freq-table-hz = <75000000 300000000>;
     };
 ...

-- 
2.34.1
Re: [PATCH 2/5] dt-bindings: crypto: ice: add freq-table-hz property to ICE schema
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On 09/10/2025 15:18, Abhinaba Rakshit wrote:
> Introduce the 'freq-table-hz' property to specify the minimum and maximum
> frequencies supported by the Inline Crypto Engine (ICE) clock.
> 
> This property is added to the ICE device node because the ICE clock is
> managed independently by the ICE driver and requires frequency information
> to be available in the device tree for the proper configuration.
> 
> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml       | 6 ++++++
>  1 file changed, 6 insertions(+)

This duplicates opp-table. Use OPPs instead.

Also, minimum and maximum frequencies are defined by compatible, no?

Best regards,
Krzysztof