1. Patchew
  2. linux
  3. View series

[PATCH] accel/amdxdna: Resume power for creating and destroying hardware context

Lizhi Hou posted 1 patch 4 months ago 
drivers/accel/amdxdna/aie2_ctx.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
[PATCH] accel/amdxdna: Resume power for creating and destroying hardware context
Posted by Lizhi Hou 4 months ago 
When the hardware is powered down by auto-suspend, creating or destroying
a hardware context without resuming power will fail.
Call amdxdna_pm_resume_get() before requesting the hardware to create or
destroy a hardware context.

Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
 drivers/accel/amdxdna/aie2_ctx.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
index 691fdb3b008f..ab4d66f1325d 100644
--- a/drivers/accel/amdxdna/aie2_ctx.c
+++ b/drivers/accel/amdxdna/aie2_ctx.c
@@ -610,10 +610,14 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
 		goto free_entity;
 	}
 
+	ret = amdxdna_pm_resume_get(xdna);
+	if (ret)
+		goto free_col_list;
+
 	ret = aie2_alloc_resource(hwctx);
 	if (ret) {
 		XDNA_ERR(xdna, "Alloc hw resource failed, ret %d", ret);
-		goto free_col_list;
+		goto suspend_put;
 	}
 
 	ret = aie2_map_host_buf(xdna->dev_handle, hwctx->fw_ctx_id,
@@ -628,6 +632,7 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
 		XDNA_ERR(xdna, "Create syncobj failed, ret %d", ret);
 		goto release_resource;
 	}
+	amdxdna_pm_suspend_put(xdna);
 
 	hwctx->status = HWCTX_STAT_INIT;
 	ndev = xdna->dev_handle;
@@ -640,6 +645,8 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
 
 release_resource:
 	aie2_release_resource(hwctx);
+suspend_put:
+	amdxdna_pm_suspend_put(xdna);
 free_col_list:
 	kfree(hwctx->col_list);
 free_entity:
-- 
2.34.1
Re: [PATCH] accel/amdxdna: Resume power for creating and destroying hardware context
Posted by Mario Limonciello 4 months ago 
On 10/7/25 11:53 PM, Lizhi Hou wrote:
> When the hardware is powered down by auto-suspend, creating or destroying
> a hardware context without resuming power will fail.
> Call amdxdna_pm_resume_get() before requesting the hardware to create or
> destroy a hardware context.
> 
> Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

> ---
>   drivers/accel/amdxdna/aie2_ctx.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 691fdb3b008f..ab4d66f1325d 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -610,10 +610,14 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>   		goto free_entity;
>   	}
>   
> +	ret = amdxdna_pm_resume_get(xdna);
> +	if (ret)
> +		goto free_col_list;
> +
>   	ret = aie2_alloc_resource(hwctx);
>   	if (ret) {
>   		XDNA_ERR(xdna, "Alloc hw resource failed, ret %d", ret);
> -		goto free_col_list;
> +		goto suspend_put;
>   	}
>   
>   	ret = aie2_map_host_buf(xdna->dev_handle, hwctx->fw_ctx_id,
> @@ -628,6 +632,7 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>   		XDNA_ERR(xdna, "Create syncobj failed, ret %d", ret);
>   		goto release_resource;
>   	}
> +	amdxdna_pm_suspend_put(xdna);
>   
>   	hwctx->status = HWCTX_STAT_INIT;
>   	ndev = xdna->dev_handle;
> @@ -640,6 +645,8 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>   
>   release_resource:
>   	aie2_release_resource(hwctx);
> +suspend_put:
> +	amdxdna_pm_suspend_put(xdna);
>   free_col_list:
>   	kfree(hwctx->col_list);
>   free_entity:
Re: [PATCH] accel/amdxdna: Resume power for creating and destroying hardware context
Posted by Lizhi Hou 4 months ago 
Applied to drm-misc-next

On 10/8/25 08:03, Mario Limonciello wrote:
> On 10/7/25 11:53 PM, Lizhi Hou wrote:
>> When the hardware is powered down by auto-suspend, creating or 
>> destroying
>> a hardware context without resuming power will fail.
>> Call amdxdna_pm_resume_get() before requesting the hardware to create or
>> destroy a hardware context.
>>
>> Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
>> ---
>>   drivers/accel/amdxdna/aie2_ctx.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index 691fdb3b008f..ab4d66f1325d 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -610,10 +610,14 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>>           goto free_entity;
>>       }
>>   +    ret = amdxdna_pm_resume_get(xdna);
>> +    if (ret)
>> +        goto free_col_list;
>> +
>>       ret = aie2_alloc_resource(hwctx);
>>       if (ret) {
>>           XDNA_ERR(xdna, "Alloc hw resource failed, ret %d", ret);
>> -        goto free_col_list;
>> +        goto suspend_put;
>>       }
>>         ret = aie2_map_host_buf(xdna->dev_handle, hwctx->fw_ctx_id,
>> @@ -628,6 +632,7 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>>           XDNA_ERR(xdna, "Create syncobj failed, ret %d", ret);
>>           goto release_resource;
>>       }
>> +    amdxdna_pm_suspend_put(xdna);
>>         hwctx->status = HWCTX_STAT_INIT;
>>       ndev = xdna->dev_handle;
>> @@ -640,6 +645,8 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>>     release_resource:
>>       aie2_release_resource(hwctx);
>> +suspend_put:
>> +    amdxdna_pm_suspend_put(xdna);
>>   free_col_list:
>>       kfree(hwctx->col_list);
>>   free_entity:
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.