[PATCH 0/3] mmc: renesas_sdhi: Handle resets

Claudiu posted 3 patches 4 months ago
There is a newer version of this series
drivers/mmc/host/renesas_sdhi.h               |  3 ++
drivers/mmc/host/renesas_sdhi_core.c          | 39 ++++++++++++++++++-
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 12 +++---
drivers/mmc/host/tmio_mmc.h                   |  2 -
drivers/mmc/host/tmio_mmc_core.c              |  2 -
5 files changed, 46 insertions(+), 12 deletions(-)
[PATCH 0/3] mmc: renesas_sdhi: Handle resets
Posted by Claudiu 4 months ago
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Hi,

Series adds suspend/resume hooks for the Renesas SDHI driver. These
are necessary on RZ/G3{E, S}, that supports a power saving mode where
power to most of the SoC components (including SDHI) is turned off.
Resume from this suspend mode is done with the help of bootloader
and it may choose to disable the SDHI clocks, resets after it is
done with the SDHIs.

Reset signal was deasserted/asserted on probe/remove as well to
avoid relying on previous bootloaders. This is also useful for
unbind/bind operations.

Along with it, driver was converted to use
SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() helpers.

Thank you,
Claudiu

Claudiu Beznea (3):
  mmc: renesas_sdhi: Deassert the reset signal on probe
  mmc: renesas_sdhi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS()
    and pm_ptr()
  mmc: renesas_sdhi: Add suspend/resume hooks

 drivers/mmc/host/renesas_sdhi.h               |  3 ++
 drivers/mmc/host/renesas_sdhi_core.c          | 39 ++++++++++++++++++-
 drivers/mmc/host/renesas_sdhi_internal_dmac.c | 12 +++---
 drivers/mmc/host/tmio_mmc.h                   |  2 -
 drivers/mmc/host/tmio_mmc_core.c              |  2 -
 5 files changed, 46 insertions(+), 12 deletions(-)

-- 
2.43.0
Re: [PATCH 0/3] mmc: renesas_sdhi: Handle resets
Posted by Claudiu Beznea 3 months ago
Hi,

On 10/8/25 07:25, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Hi,
> 
> Series adds suspend/resume hooks for the Renesas SDHI driver. These
> are necessary on RZ/G3{E, S}, that supports a power saving mode where
> power to most of the SoC components (including SDHI) is turned off.
> Resume from this suspend mode is done with the help of bootloader
> and it may choose to disable the SDHI clocks, resets after it is
> done with the SDHIs.
> 
> Reset signal was deasserted/asserted on probe/remove as well to
> avoid relying on previous bootloaders. This is also useful for
> unbind/bind operations.
> 
> Along with it, driver was converted to use
> SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() helpers.
> 
> Thank you,
> Claudiu
> 
> Claudiu Beznea (3):
>   mmc: renesas_sdhi: Deassert the reset signal on probe
>   mmc: renesas_sdhi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS()
>     and pm_ptr()
>   mmc: renesas_sdhi: Add suspend/resume hooks
Gentle ping on this series.

Thank you,
Claudiu
Re: [PATCH 0/3] mmc: renesas_sdhi: Handle resets
Posted by Wolfram Sang 2 months, 4 weeks ago
> Gentle ping on this series.

I had a look already but want to test this series on R-Car SoCs. Which
tests did you apply?

Re: [PATCH 0/3] mmc: renesas_sdhi: Handle resets
Posted by Claudiu Beznea 2 months, 3 weeks ago
Hi, Wolfram,

On 11/12/25 20:25, Wolfram Sang wrote:
> 
>> Gentle ping on this series.
> 
> I had a look already but want to test this series on R-Car SoCs. Which
> tests did you apply?
> 

On RZ/G3S the following were checked:
- run bonnie++ on all the SDHIs (with SD card and eMMC, where possible)
- unbind/bind on all the SDHIs and run bonnie++ (with SD card and eMMC,
  where possible) after re-bind
- 32 consecutive suspend/resume (s2idle and deep) and run bonnie++ (with SD
  card and eMMC where possible) after resume

bonnie++ tests were executed after boot on RZ/G2{H, M, N, L, UL}, RZ/V2L.

Thank you,
Claudiu
Re: [PATCH 0/3] mmc: renesas_sdhi: Handle resets
Posted by Wolfram Sang 2 months, 3 weeks ago
> On RZ/G3S the following were checked:
> - run bonnie++ on all the SDHIs (with SD card and eMMC, where possible)
> - unbind/bind on all the SDHIs and run bonnie++ (with SD card and eMMC,
>   where possible) after re-bind
> - 32 consecutive suspend/resume (s2idle and deep) and run bonnie++ (with SD
>   card and eMMC where possible) after resume
> 
> bonnie++ tests were executed after boot on RZ/G2{H, M, N, L, UL}, RZ/V2L.

Thanks, I did some lighter testing on R-Car D3 with bind/unbind and
suspend-to-ram. Focussing on areas you modified. No regressions, all
worked fine.

Can I get the I3C pinctrl patch for G3S now as a reward? :)

Re: [PATCH 0/3] mmc: renesas_sdhi: Handle resets
Posted by Claudiu Beznea 2 months, 3 weeks ago
Hi, Wolfram,

On 11/13/25 23:13, Wolfram Sang wrote:
> 
>> On RZ/G3S the following were checked:
>> - run bonnie++ on all the SDHIs (with SD card and eMMC, where possible)
>> - unbind/bind on all the SDHIs and run bonnie++ (with SD card and eMMC,
>>   where possible) after re-bind
>> - 32 consecutive suspend/resume (s2idle and deep) and run bonnie++ (with SD
>>   card and eMMC where possible) after resume
>>
>> bonnie++ tests were executed after boot on RZ/G2{H, M, N, L, UL}, RZ/V2L.
> 
> Thanks, I did some lighter testing on R-Car D3 with bind/unbind and
> suspend-to-ram. Focussing on areas you modified. No regressions, all
> worked fine.

Thank you for checking it!

> 
> Can I get the I3C pinctrl patch for G3S now as a reward? :)
> 
I'll do my best :)

Thank you,
Claudiu