[PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the freshly introduced driver

David Heidelberg via B4 Relay posted 7 patches 4 months ago
There is a newer version of this series
[PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the freshly introduced driver
Posted by David Heidelberg via B4 Relay 4 months ago
From: David Heidelberg <david@ixit.cz>

Switch from older effort to support different panels within one driver
(which already dropped support for the HW) to the freshly written one.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
index 7e75decfda052..55b3e94dd9726 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
@@ -32,7 +32,7 @@ battery: battery {
 &display_panel {
 	status = "okay";
 
-	compatible = "samsung,s6e3fc2x01";
+	compatible = "samsung,s6e3fc2x01-ams641rw";
 };
 
 &i2c4 {

-- 
2.51.0
Re: [PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the freshly introduced driver
Posted by Dmitry Baryshkov 4 months ago
On Wed, Oct 08, 2025 at 04:05:30PM +0200, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> Switch from older effort to support different panels within one driver
> (which already dropped support for the HW) to the freshly written one.

Please disconnect the driver and the DT description. DT can be used by
other instances (U-Boot, OpenBSD, etc.).

> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
> index 7e75decfda052..55b3e94dd9726 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
> @@ -32,7 +32,7 @@ battery: battery {
>  &display_panel {
>  	status = "okay";
>  
> -	compatible = "samsung,s6e3fc2x01";
> +	compatible = "samsung,s6e3fc2x01-ams641rw";
>  };
>  
>  &i2c4 {
> 
> -- 
> 2.51.0
> 
> 

-- 
With best wishes
Dmitry
Re: [PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the freshly introduced driver
Posted by David Heidelberg 4 months ago
On 08/10/2025 17:54, Dmitry Baryshkov wrote:
> On Wed, Oct 08, 2025 at 04:05:30PM +0200, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Switch from older effort to support different panels within one driver
>> (which already dropped support for the HW) to the freshly written one.
> 
> Please disconnect the driver and the DT description. DT can be used by
> other instances (U-Boot, OpenBSD, etc.).

Just to note, there are no users (anywhere) for this compatible.

Would be the change of the commit wording enough in this case?

If not, I would then propose to use for OnePlus 6T just an extension as

compatible = "samsung,s6e3fc2x01-ams641rw", "samsung,s6e3fc2x01";

Thank you

> 
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
>> index 7e75decfda052..55b3e94dd9726 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
>> @@ -32,7 +32,7 @@ battery: battery {
>>   &display_panel {
>>   	status = "okay";
>>   
>> -	compatible = "samsung,s6e3fc2x01";
>> +	compatible = "samsung,s6e3fc2x01-ams641rw";
>>   };
>>   
>>   &i2c4 {
>>
>> -- 
>> 2.51.0
>>
>>
> 

-- 
David Heidelberg
Re: [PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the freshly introduced driver
Posted by Dmitry Baryshkov 4 months ago
On Wed, Oct 08, 2025 at 06:09:19PM +0200, David Heidelberg wrote:
> On 08/10/2025 17:54, Dmitry Baryshkov wrote:
> > On Wed, Oct 08, 2025 at 04:05:30PM +0200, David Heidelberg via B4 Relay wrote:
> > > From: David Heidelberg <david@ixit.cz>
> > > 
> > > Switch from older effort to support different panels within one driver
> > > (which already dropped support for the HW) to the freshly written one.
> > 
> > Please disconnect the driver and the DT description. DT can be used by
> > other instances (U-Boot, OpenBSD, etc.).
> 
> Just to note, there are no users (anywhere) for this compatible.
> 
> Would be the change of the commit wording enough in this case?
> 
> If not, I would then propose to use for OnePlus 6T just an extension as
> 
> compatible = "samsung,s6e3fc2x01-ams641rw", "samsung,s6e3fc2x01";

I like this approach

-- 
With best wishes
Dmitry