[v1] sunrpc: fix handling of rq_bvec array in svc_rqst

[PATCH 0/2] sunrpc: fix handling of rq_bvec array in svc_rqst

Jeff Layton posted 2 patches 2 months, 1 week ago

Diff against v2 v3
Download series mbox

There is a newer version of this series

fs/nfsd/vfs.c        | 6 +++---
net/sunrpc/svc.c     | 3 ++-
net/sunrpc/svcsock.c | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH 0/2] sunrpc: fix handling of rq_bvec array in svc_rqst

Posted by Jeff Layton 2 months, 1 week ago

I've seen this message pop intermittently on some knfsd servers:

    rpc-srv/tcp: nfsd: sent 1045870 when sending 1045868 bytes - shutting down socket

Unfortunately, I've not been able to reproduce this on my own, but I've
noticed a bug that could cause this.

The first patch in this series fixes a bug in rq_bvec handling I noticed
by inspection. The second patch adds a slot to rq_bvec to account for
the slot used for the TCP record marker.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (2):
      sunrpc: account for TCP record marker in rq_bvec array when sending
      sunrpc: add a slot to rqstp->rq_bvec for TCP record marker

 fs/nfsd/vfs.c        | 6 +++---
 net/sunrpc/svc.c     | 3 ++-
 net/sunrpc/svcsock.c | 2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)
---
base-commit: 177818f176ef904fb18d237d1dbba00c2643aaf2
change-id: 20251008-rq_bvec-b66afd0fdbbb

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/2] sunrpc: fix handling of rq_bvec array in svc_rqst

Posted by Mike Snitzer 2 months, 1 week ago

On Wed, Oct 08, 2025 at 02:58:51PM -0400, Jeff Layton wrote:
> I've seen this message pop intermittently on some knfsd servers:
> 
>     rpc-srv/tcp: nfsd: sent 1045870 when sending 1045868 bytes - shutting down socket
> 

This ^ looks like useful info to include in the associated commit
header.