Add the Device Tree schema and examples for the Pinefeat cef168 lens
control board. This board interfaces Canon EF & EF-S lenses with
non-Canon camera bodies, enabling electronic control of focus and
aperture via V4L2.
Power supply is derived from fixed supplies via connector or GPIO
header. Therefore, the driver does not manage any regulator, so
representing any supply in the binding is redundant.
Signed-off-by: Aliaksandr Smirnou <asmirnou@pinefeat.co.uk>
---
.../bindings/media/i2c/pinefeat,cef168.yaml | 47 +++++++++++++++++++
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
MAINTAINERS | 6 +++
3 files changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml b/Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
new file mode 100644
index 000000000000..1295b1f4edeb
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2025 Pinefeat LLP
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/pinefeat,cef168.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Pinefeat cef168 lens driver
+
+maintainers:
+ - Aliaksandr Smirnou <support@pinefeat.co.uk>
+
+description: |
+ Pinefeat produces an adapter designed to interface between
+ Canon EF & EF-S lenses and non-Canon camera bodies, incorporating
+ features for electronic focus and aperture adjustment. The cef168
+ circuit board, included with the adapter, provides a software
+ programming interface that allows control of lens focus and
+ aperture positions.
+
+properties:
+ compatible:
+ enum:
+ - pinefeat,cef168
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera-lens@d {
+ compatible = "pinefeat,cef168";
+ reg = <0x0d>;
+ };
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index f1d1882009ba..4f50c35ed670 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1241,6 +1241,8 @@ patternProperties:
description: Picochip Ltd
"^pine64,.*":
description: Pine64
+ "^pinefeat,.*":
+ description: Pinefeat LLP
"^pineriver,.*":
description: Shenzhen PineRiver Designs Co., Ltd.
"^pixcir,.*":
diff --git a/MAINTAINERS b/MAINTAINERS
index 5a2cde903910..a59cd27caf11 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20332,6 +20332,12 @@ S: Supported
F: Documentation/devicetree/bindings/input/pine64,pinephone-keyboard.yaml
F: drivers/input/keyboard/pinephone-keyboard.c
+PINEFEAT CEF168 LENS DRIVER
+M: Aliaksandr Smirnou <support@pinefeat.co.uk>
+L: linux-media@vger.kernel.org
+S: Supported
+F: Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
+
PLANTOWER PMS7003 AIR POLLUTION SENSOR DRIVER
M: Tomasz Duszynski <tduszyns@gmail.com>
S: Maintained
--
2.34.1On 08/10/2025 04:57, Aliaksandr Smirnou wrote: > Add the Device Tree schema and examples for the Pinefeat cef168 lens > control board. This board interfaces Canon EF & EF-S lenses with > non-Canon camera bodies, enabling electronic control of focus and > aperture via V4L2. > > Power supply is derived from fixed supplies via connector or GPIO > header. Therefore, the driver does not manage any regulator, so > representing any supply in the binding is redundant. > > Signed-off-by: Aliaksandr Smirnou <asmirnou@pinefeat.co.uk> You already got review at v4! Why are you forcing us to do the job multiple times? <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On Thu, 9 Oct 2025 08:46:44 +0900, Krzysztof Kozlowski wrote: > You already got review at v4! Why are you forcing us to do the job > multiple times? Apologies for the oversight. There were no changes in the dt-bindings patch; I should have kept the Reviewed-by tag from the earlier one. I'll make sure to include it next time.
On Tue, Oct 07, 2025 at 08:57:31PM +0100, Aliaksandr Smirnou wrote: > Add the Device Tree schema and examples for the Pinefeat cef168 lens > control board. This board interfaces Canon EF & EF-S lenses with > non-Canon camera bodies, enabling electronic control of focus and > aperture via V4L2. > > Power supply is derived from fixed supplies via connector or GPIO > header. Therefore, the driver does not manage any regulator, so > representing any supply in the binding is redundant. > > Signed-off-by: Aliaksandr Smirnou <asmirnou@pinefeat.co.uk> I acked v5, any reason for not applying it? https://lore.kernel.org/all/20251007-geologic-epidemic-2f667f232cf6@spud/#t
On Tue, 7 Oct 2025 21:47:29 +0100, Conor Dooley wrote: > I acked v5, any reason for not applying it? > https://lore.kernel.org/all/20251007-geologic-epidemic-2f667f232cf6@spud/#t Yes, the dt-bindings patch can be applied. The v6 series does not change anything in the dt-bindings patch - only another patch in the series was updated, so v6 was sent. Apologies - I wasn't aware that an acked patch could be omitted from the new revision.
On Wed, Oct 08, 2025 at 06:50:36PM +0100, Aliaksandr Smirnou wrote: > On Tue, 7 Oct 2025 21:47:29 +0100, Conor Dooley wrote: > > > I acked v5, any reason for not applying it? > > https://lore.kernel.org/all/20251007-geologic-epidemic-2f667f232cf6@spud/#t > > Yes, the dt-bindings patch can be applied. > The v6 series does not change anything in the dt-bindings patch - only > another patch in the series was updated, so v6 was sent. > > Apologies - I wasn't aware that an acked patch could be omitted from > the new revision. No no, it's not that it should have been omitted - it's that you should have applied my ack on v5 when submitting your v6. I guess timing worked against you because I sent it like 20 mins before you sent v6. Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Tue, 7 Oct 2025 21:47:29 +0100, Conor Dooley wrote: > On Wed, Oct 08, 2025 at 06:50:36PM +0100, Aliaksandr Smirnou wrote: > > On Tue, 7 Oct 2025 21:47:29 +0100, Conor Dooley wrote: > > > > > I acked v5, any reason for not applying it? > > > https://lore.kernel.org/all/20251007-geologic-epidemic-2f667f232cf6@spud/#t > > > > Yes, the dt-bindings patch can be applied. > > The v6 series does not change anything in the dt-bindings patch - only > > another patch in the series was updated, so v6 was sent. > > > > Apologies - I wasn't aware that an acked patch could be omitted from > > the new revision. > > No no, it's not that it should have been omitted - it's that you should > have applied my ack on v5 when submitting your v6. I guess timing worked > against you because I sent it like 20 mins before you sent v6. > Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks for clarifying. I'll make sure to include your Acked-by tag in the next version.
© 2016 - 2025 Red Hat, Inc.