[RFC PATCH 3/5] m68k: amiga: Allow PCI

Daniel Palmer posted 5 patches 4 months ago
[RFC PATCH 3/5] m68k: amiga: Allow PCI
Posted by Daniel Palmer 4 months ago
The Amiga has various options for adding a PCI bus so select HAVE_PCI.

Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
 arch/m68k/Kconfig.machine | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
index de39f23b180e..b170ebf39273 100644
--- a/arch/m68k/Kconfig.machine
+++ b/arch/m68k/Kconfig.machine
@@ -7,6 +7,7 @@ config AMIGA
 	bool "Amiga support"
 	depends on MMU
 	select LEGACY_TIMER_TICK
+	select HAVE_PCI
 	help
 	  This option enables support for the Amiga series of computers. If
 	  you plan to use this kernel on an Amiga, say Y here and browse the
-- 
2.51.0
Re: [RFC PATCH 3/5] m68k: amiga: Allow PCI
Posted by Geert Uytterhoeven 4 months ago
Hi Daniel,

On Tue, 7 Oct 2025 at 11:33, Daniel Palmer <daniel@thingy.jp> wrote:
> The Amiga has various options for adding a PCI bus so select HAVE_PCI.
>
> Signed-off-by: Daniel Palmer <daniel@thingy.jp>

Thanks for your patch!

> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -7,6 +7,7 @@ config AMIGA
>         bool "Amiga support"
>         depends on MMU
>         select LEGACY_TIMER_TICK
> +       select HAVE_PCI
>         help
>           This option enables support for the Amiga series of computers. If
>           you plan to use this kernel on an Amiga, say Y here and browse the

This doesn't make much sense without upstream support for actual
PCI host bridge controllers.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [RFC PATCH 3/5] m68k: amiga: Allow PCI
Posted by John Paul Adrian Glaubitz 4 months ago
Hi Geert,

On Tue, 2025-10-07 at 11:37 +0200, Geert Uytterhoeven wrote:
> Hi Daniel,
> 
> On Tue, 7 Oct 2025 at 11:33, Daniel Palmer <daniel@thingy.jp> wrote:
> > The Amiga has various options for adding a PCI bus so select HAVE_PCI.
> > 
> > Signed-off-by: Daniel Palmer <daniel@thingy.jp>
> 
> Thanks for your patch!
> 
> > --- a/arch/m68k/Kconfig.machine
> > +++ b/arch/m68k/Kconfig.machine
> > @@ -7,6 +7,7 @@ config AMIGA
> >         bool "Amiga support"
> >         depends on MMU
> >         select LEGACY_TIMER_TICK
> > +       select HAVE_PCI
> >         help
> >           This option enables support for the Amiga series of computers. If
> >           you plan to use this kernel on an Amiga, say Y here and browse the
> 
> This doesn't make much sense without upstream support for actual
> PCI host bridge controllers.

Isn't this what patch 5 does?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Re: [RFC PATCH 3/5] m68k: amiga: Allow PCI
Posted by Geert Uytterhoeven 4 months ago
Hi Adrian,

On Tue, 7 Oct 2025 at 11:41, John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> On Tue, 2025-10-07 at 11:37 +0200, Geert Uytterhoeven wrote:
> > On Tue, 7 Oct 2025 at 11:33, Daniel Palmer <daniel@thingy.jp> wrote:
> > > The Amiga has various options for adding a PCI bus so select HAVE_PCI.
> > >
> > > Signed-off-by: Daniel Palmer <daniel@thingy.jp>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/m68k/Kconfig.machine
> > > +++ b/arch/m68k/Kconfig.machine
> > > @@ -7,6 +7,7 @@ config AMIGA
> > >         bool "Amiga support"
> > >         depends on MMU
> > >         select LEGACY_TIMER_TICK
> > > +       select HAVE_PCI
> > >         help
> > >           This option enables support for the Amiga series of computers. If
> > >           you plan to use this kernel on an Amiga, say Y here and browse the
> >
> > This doesn't make much sense without upstream support for actual
> > PCI host bridge controllers.
>
> Isn't this what patch 5 does?

Oops, sorry, I hadn't realized this is part of a series, as I somehow
haven't received the other patches from the series yet...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [RFC PATCH 3/5] m68k: amiga: Allow PCI
Posted by Daniel Palmer 4 months ago
Hi Geert, Adrian,

On Tue, 7 Oct 2025 at 19:22, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Adrian,
>
> On Tue, 7 Oct 2025 at 11:41, John Paul Adrian Glaubitz
> <glaubitz@physik.fu-berlin.de> wrote:
> > On Tue, 2025-10-07 at 11:37 +0200, Geert Uytterhoeven wrote:
> > > On Tue, 7 Oct 2025 at 11:33, Daniel Palmer <daniel@thingy.jp> wrote:

> > Isn't this what patch 5 does?

Sorry, I guess the ordering could have been better... There is also a
reference to the Kconfig symbol added in patch 5 in one of the earlier
patches.
If this has a hope of being merged I'll fix that for the next try.

Thanks,

Daniel