[v1] media: platform: rga: Add RGA3 support

[PATCH 13/16] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

Posted by Sven Püschel 4 months ago

Add a new compatible for the rk3588 Rockchip SoC, which features an
RGA3, which is described in the TRM Part2.

Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
---
 Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
index ac17cda65191be047fc61d0c806f806c6af07c7b..11e86333c56aab55d9358dc88e45e7c1ebfaae9e 100644
--- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
@@ -20,6 +20,7 @@ properties:
     oneOf:
       - const: rockchip,rk3288-rga
       - const: rockchip,rk3399-rga
+      - const: rockchip,rk3588-rga3
       - items:
           - enum:
               - rockchip,rk3228-rga

-- 
2.51.0

Re: [PATCH 13/16] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

Posted by Krzysztof Kozlowski 4 months ago

On 07/10/2025 17:32, Sven Püschel wrote:
> Add a new compatible for the rk3588 Rockchip SoC, which features an
> RGA3, which is described in the TRM Part2.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> index ac17cda65191be047fc61d0c806f806c6af07c7b..11e86333c56aab55d9358dc88e45e7c1ebfaae9e 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> @@ -20,6 +20,7 @@ properties:
>      oneOf:
>        - const: rockchip,rk3288-rga
>        - const: rockchip,rk3399-rga
> +      - const: rockchip,rk3588-rga3

There is already rk3588-rga, so please explain in commit msg
differences, including compatibility or lack thereof. I am confused why
there are two completely different 2D accelerators simultaneously on
that SoC.

Best regards,
Krzysztof

Re: [PATCH 13/16] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

Posted by Nicolas Dufresne 4 months ago

Hi,

Le mardi 07 octobre 2025 à 17:38 +0900, Krzysztof Kozlowski a écrit :
> On 07/10/2025 17:32, Sven Püschel wrote:
> > Add a new compatible for the rk3588 Rockchip SoC, which features an
> > RGA3, which is described in the TRM Part2.

Please write something here. You can't explain why RK did this, but at least
explain what are the differences and additional feature. It should also be super
clear through your patchset everything you didn't support, since when reading
your set, it really have nothing extra implemented.

> > 
> > Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > index
> > ac17cda65191be047fc61d0c806f806c6af07c7b..11e86333c56aab55d9358dc88e45e7c1eb
> > faae9e 100644
> > --- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > +++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > @@ -20,6 +20,7 @@ properties:
> >      oneOf:
> >        - const: rockchip,rk3288-rga
> >        - const: rockchip,rk3399-rga
> > +      - const: rockchip,rk3588-rga3
> 
> There is already rk3588-rga, so please explain in commit msg
> differences, including compatibility or lack thereof. I am confused why
> there are two completely different 2D accelerators simultaneously on
> that SoC.

It is quite strange hardware design, but this is really how the hardware is. I
personally don't expect an explanation from a third party. Its a mirror of the
VOP2 planes really.

Nicolas

> 
> Best regards,
> Krzysztof