Add soundcard compatible for QRB2210 (QCM2290) platforms.
While at this, also add QRB2210 RB1 entry which is set to be
compatible with QRB2210 soundcard.
Cc: Srinivas Kandagatla <srini@kernel.org>
Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
---
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -21,6 +21,10 @@ properties:
- lenovo,yoga-c630-sndcard
- qcom,db845c-sndcard
- const: qcom,sdm845-sndcard
+ - items:
+ - enum:
+ - qcom,qrb2210-rb1-sndcard
+ - const: qcom,qrb2210-sndcard
- items:
- enum:
- qcom,sm8550-sndcard
@@ -37,6 +41,7 @@ properties:
- qcom,qcs8275-sndcard
- qcom,qcs9075-sndcard
- qcom,qcs9100-sndcard
+ - qcom,qrb2210-sndcard
- qcom,qrb4210-rb2-sndcard
- qcom,qrb5165-rb5-sndcard
- qcom,sc7180-qdsp6-sndcard
--
2.47.3On 10/7/25 2:26 AM, Alexey Klimov wrote: > Add soundcard compatible for QRB2210 (QCM2290) platforms. > While at this, also add QRB2210 RB1 entry which is set to be > compatible with QRB2210 soundcard. > > Cc: Srinivas Kandagatla <srini@kernel.org> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -21,6 +21,10 @@ properties: > - lenovo,yoga-c630-sndcard > - qcom,db845c-sndcard > - const: qcom,sdm845-sndcard > + - items: > + - enum: > + - qcom,qrb2210-rb1-sndcard I don't think you need rb1 specific compatible here, unless there this is totally different to what the base compatible can provide. --srini> + - const: qcom,qrb2210-sndcard > - items: > - enum: > - qcom,sm8550-sndcard > @@ -37,6 +41,7 @@ properties: > - qcom,qcs8275-sndcard > - qcom,qcs9075-sndcard > - qcom,qcs9100-sndcard > + - qcom,qrb2210-sndcard > - qcom,qrb4210-rb2-sndcard > - qcom,qrb5165-rb5-sndcard > - qcom,sc7180-qdsp6-sndcard >
On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> wrote: > > > > On 10/7/25 2:26 AM, Alexey Klimov wrote: > > Add soundcard compatible for QRB2210 (QCM2290) platforms. > > While at this, also add QRB2210 RB1 entry which is set to be > > compatible with QRB2210 soundcard. > > > > Cc: Srinivas Kandagatla <srini@kernel.org> > > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > > --- > > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > > index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 > > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > > @@ -21,6 +21,10 @@ properties: > > - lenovo,yoga-c630-sndcard > > - qcom,db845c-sndcard > > - const: qcom,sdm845-sndcard > > + - items: > > + - enum: > > + - qcom,qrb2210-rb1-sndcard > I don't think you need rb1 specific compatible here, unless there this > is totally different to what the base compatible can provide. Why do we need to deviate from other platforms which declare board-specific compat too? > > --srini> + - const: qcom,qrb2210-sndcard Broken quoting > > - items: > > - enum: > > - qcom,sm8550-sndcard > > @@ -37,6 +41,7 @@ properties: > > - qcom,qcs8275-sndcard > > - qcom,qcs9075-sndcard > > - qcom,qcs9100-sndcard > > + - qcom,qrb2210-sndcard > > - qcom,qrb4210-rb2-sndcard > > - qcom,qrb5165-rb5-sndcard > > - qcom,sc7180-qdsp6-sndcard > > > -- With best wishes Dmitry
On Thu Oct 16, 2025 at 8:46 PM BST, Dmitry Baryshkov wrote: > On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla > <srinivas.kandagatla@oss.qualcomm.com> wrote: >> >> >> >> On 10/7/25 2:26 AM, Alexey Klimov wrote: >> > Add soundcard compatible for QRB2210 (QCM2290) platforms. >> > While at this, also add QRB2210 RB1 entry which is set to be >> > compatible with QRB2210 soundcard. >> > >> > Cc: Srinivas Kandagatla <srini@kernel.org> >> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> >> > --- >> > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >> > index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 >> > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >> > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >> > @@ -21,6 +21,10 @@ properties: >> > - lenovo,yoga-c630-sndcard >> > - qcom,db845c-sndcard >> > - const: qcom,sdm845-sndcard >> > + - items: >> > + - enum: >> > + - qcom,qrb2210-rb1-sndcard >> I don't think you need rb1 specific compatible here, unless there this >> is totally different to what the base compatible can provide. > > Why do we need to deviate from other platforms which declare > board-specific compat too? There seems to be now a few incompatible suggestions for rb1 sndcard: - make it compatible/fallback to qcom,sm8250-sndcard (1); - make it compatible/fallback to qcom,qrb4210-rb2-sndcard (2); - add separate compatible/enum for rb1 sndcard as qcom,qrb2210-rb1-sndcard (3); - add base compatible as qcom,qrb2210-sndcard and fallback rb1 sndcard compatible to it. The latter one is ruled out because base compatible should be used and it is not going to. As far as I can see the last addition went simply with (3). Which one finally you all want? Best regards, Alexey
On 10/17/25 8:35 AM, Alexey Klimov wrote: > On Thu Oct 16, 2025 at 8:46 PM BST, Dmitry Baryshkov wrote: >> On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla >> <srinivas.kandagatla@oss.qualcomm.com> wrote: >>> >>> >>> >>> On 10/7/25 2:26 AM, Alexey Klimov wrote: >>>> Add soundcard compatible for QRB2210 (QCM2290) platforms. >>>> While at this, also add QRB2210 RB1 entry which is set to be >>>> compatible with QRB2210 soundcard. >>>> >>>> Cc: Srinivas Kandagatla <srini@kernel.org> >>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 >>>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> @@ -21,6 +21,10 @@ properties: >>>> - lenovo,yoga-c630-sndcard >>>> - qcom,db845c-sndcard >>>> - const: qcom,sdm845-sndcard >>>> + - items: >>>> + - enum: >>>> + - qcom,qrb2210-rb1-sndcard >>> I don't think you need rb1 specific compatible here, unless there this >>> is totally different to what the base compatible can provide. >> >> Why do we need to deviate from other platforms which declare >> board-specific compat too? > > There seems to be now a few incompatible suggestions for rb1 sndcard: > - make it compatible/fallback to qcom,sm8250-sndcard (1); > - make it compatible/fallback to qcom,qrb4210-rb2-sndcard (2); > - add separate compatible/enum for rb1 sndcard as qcom,qrb2210-rb1-sndcard (3); > - add base compatible as qcom,qrb2210-sndcard and fallback > rb1 sndcard compatible to it. > > The latter one is ruled out because base compatible should be used and > it is not going to. > > As far as I can see the last addition went simply with (3). > Which one finally you all want? Am fine with either "qcom,sm8250-sndcard" or "qcom,qrb4210-rb1-sndcard" as long as we reflect that correct driver name in machine driver. traditionally we have SoC level compatible which works fine for 99% of the boards for that SoC, expectation was that if there is any deviation or board specific changes required, this can be accommodate using model information. am fine with board specific compatible too, however am not okay with both "qcom,sm8250-sndcard" and "qcom,qrb4210-rb1-sndcard" or falling back to another board compatible for various reason one being ucm. So 1 and 2 re *NOK* I hope this provides some clarity here. thanks, Srini> > Best regards, > Alexey >
On Fri Oct 17, 2025 at 12:27 PM BST, Srinivas Kandagatla wrote: > On 10/17/25 8:35 AM, Alexey Klimov wrote: >> On Thu Oct 16, 2025 at 8:46 PM BST, Dmitry Baryshkov wrote: >>> On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla >>> <srinivas.kandagatla@oss.qualcomm.com> wrote: >>>> >>>> >>>> >>>> On 10/7/25 2:26 AM, Alexey Klimov wrote: >>>>> Add soundcard compatible for QRB2210 (QCM2290) platforms. >>>>> While at this, also add QRB2210 RB1 entry which is set to be >>>>> compatible with QRB2210 soundcard. >>>>> >>>>> Cc: Srinivas Kandagatla <srini@kernel.org> >>>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> >>>>> --- >>>>> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>>> index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 >>>>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>>> @@ -21,6 +21,10 @@ properties: >>>>> - lenovo,yoga-c630-sndcard >>>>> - qcom,db845c-sndcard >>>>> - const: qcom,sdm845-sndcard >>>>> + - items: >>>>> + - enum: >>>>> + - qcom,qrb2210-rb1-sndcard >>>> I don't think you need rb1 specific compatible here, unless there this >>>> is totally different to what the base compatible can provide. >>> >>> Why do we need to deviate from other platforms which declare >>> board-specific compat too? >> >> There seems to be now a few incompatible suggestions for rb1 sndcard: >> - make it compatible/fallback to qcom,sm8250-sndcard (1); >> - make it compatible/fallback to qcom,qrb4210-rb2-sndcard (2); >> - add separate compatible/enum for rb1 sndcard as qcom,qrb2210-rb1-sndcard (3); >> - add base compatible as qcom,qrb2210-sndcard and fallback >> rb1 sndcard compatible to it. >> >> The latter one is ruled out because base compatible should be used and >> it is not going to. >> >> As far as I can see the last addition went simply with (3). >> Which one finally you all want? > > Am fine with either "qcom,sm8250-sndcard" or "qcom,qrb4210-rb1-sndcard" > as long as we reflect that correct driver name in machine driver. > > traditionally we have SoC level compatible which works fine for 99% of > the boards for that SoC, expectation was that if there is any deviation > or board specific changes required, this can be accommodate using model > information. am fine with board specific compatible too, however am not > okay with both "qcom,sm8250-sndcard" and "qcom,qrb4210-rb1-sndcard" or > falling back to another board compatible for various reason one being ucm. > > So 1 and 2 re *NOK* > > I hope this provides some clarity here. Yes. Thanks. I went with SoC-level compatible in the latest version. Thanks, Alexey
On Fri, Oct 17, 2025 at 12:27:55PM +0100, Srinivas Kandagatla wrote: > On 10/17/25 8:35 AM, Alexey Klimov wrote: > > On Thu Oct 16, 2025 at 8:46 PM BST, Dmitry Baryshkov wrote: > >> On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla > >> <srinivas.kandagatla@oss.qualcomm.com> wrote: > >>> > >>> > >>> > >>> On 10/7/25 2:26 AM, Alexey Klimov wrote: > >>>> Add soundcard compatible for QRB2210 (QCM2290) platforms. > >>>> While at this, also add QRB2210 RB1 entry which is set to be > >>>> compatible with QRB2210 soundcard. > >>>> > >>>> Cc: Srinivas Kandagatla <srini@kernel.org> > >>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> > >>>> --- > >>>> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ > >>>> 1 file changed, 5 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > >>>> index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 > >>>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > >>>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > >>>> @@ -21,6 +21,10 @@ properties: > >>>> - lenovo,yoga-c630-sndcard > >>>> - qcom,db845c-sndcard > >>>> - const: qcom,sdm845-sndcard > >>>> + - items: > >>>> + - enum: > >>>> + - qcom,qrb2210-rb1-sndcard > >>> I don't think you need rb1 specific compatible here, unless there this > >>> is totally different to what the base compatible can provide. > >> > >> Why do we need to deviate from other platforms which declare > >> board-specific compat too? > > > > There seems to be now a few incompatible suggestions for rb1 sndcard: > > - make it compatible/fallback to qcom,sm8250-sndcard (1); > > - make it compatible/fallback to qcom,qrb4210-rb2-sndcard (2); > > - add separate compatible/enum for rb1 sndcard as qcom,qrb2210-rb1-sndcard (3); > > - add base compatible as qcom,qrb2210-sndcard and fallback > > rb1 sndcard compatible to it. > > > > The latter one is ruled out because base compatible should be used and > > it is not going to. > > > > As far as I can see the last addition went simply with (3). > > Which one finally you all want? > > Am fine with either "qcom,sm8250-sndcard" or "qcom,qrb4210-rb1-sndcard" > as long as we reflect that correct driver name in machine driver. > > traditionally we have SoC level compatible which works fine for 99% of > the boards for that SoC, expectation was that if there is any deviation > or board specific changes required, this can be accommodate using model > information. am fine with board specific compatible too, however am not > okay with both "qcom,sm8250-sndcard" and "qcom,qrb4210-rb1-sndcard" or > falling back to another board compatible for various reason one being ucm. > > So 1 and 2 re *NOK* > > I hope this provides some clarity here. My preference would be to follow the established pattern, unless there is a good reason to deviate from it. And... it seems we have several trends there. - qcom,SoC-sndcard (with possible fallback to earlier SoC). 35 usages out of 49, including the recent ones as X1E8, SM[4567]50, SC8280XP, QCS8300 and others - Two users of qcom,SoC-qdsp6-sndcard, let's ignore them. - 12 users of Board-specific compat string, which includes RB2, RB3, RB5, RB3 Gen2, FP4 and FP5 (and several other platforms). Some (3 SDM845 devices) of these devices use an SoC compat as a fallback string, which adds weight to the first bucket. The "winner" is obvious, but I couldn't help but notice the lack of generic approach (and yes, before i grepped '-sndcard' I was under assumption that the board-specific sndcard is a recommended approach, looking at the boards and phones I cared most). TL;DR. Alexey, I'm sorry for the possible misguidance earlier. It seems this device should also use a generic name "qcom,qcm2290-sndcard" (or "qcom,qrb2210-sndcard"). -- With best wishes Dmitry
On 07/10/2025 10:26, Alexey Klimov wrote: > Add soundcard compatible for QRB2210 (QCM2290) platforms. > While at this, also add QRB2210 RB1 entry which is set to be > compatible with QRB2210 soundcard. You explained here what you did, but you should explain why. I don't quite get why SoC sound card and RB1 sound card are both needed. I would just go with one. Please use subject prefixes matching the subsystem. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > Best regards, Krzysztof
On Tue Oct 7, 2025 at 2:45 AM BST, Krzysztof Kozlowski wrote: > On 07/10/2025 10:26, Alexey Klimov wrote: >> Add soundcard compatible for QRB2210 (QCM2290) platforms. >> While at this, also add QRB2210 RB1 entry which is set to be >> compatible with QRB2210 soundcard. > > > You explained here what you did, but you should explain why. I don't > quite get why SoC sound card and RB1 sound card are both needed. I would > just go with one. I wanted to go with none in the first place and just make it rb2 sndcard compatible (as a fallback). Then Dmitry suggested to follow other sndcards patterns and implmenet it like this. There is also at least one qrb2210/qcm2290-based board -- UNO Q and at this point I can't say if it will need separate compatble or can use qcom,qrb2210-sndcard as a fallback. > Please use subject prefixes matching the subsystem. For bindings, the > preferred subjects are explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters So the order in subject should be reversed. Got it. Thanks, Alexey
On 08/10/2025 11:40, Alexey Klimov wrote: > On Tue Oct 7, 2025 at 2:45 AM BST, Krzysztof Kozlowski wrote: >> On 07/10/2025 10:26, Alexey Klimov wrote: >>> Add soundcard compatible for QRB2210 (QCM2290) platforms. >>> While at this, also add QRB2210 RB1 entry which is set to be >>> compatible with QRB2210 soundcard. >> >> >> You explained here what you did, but you should explain why. I don't >> quite get why SoC sound card and RB1 sound card are both needed. I would >> just go with one. > > > I wanted to go with none in the first place and just make it rb2 > sndcard compatible (as a fallback). Then Dmitry suggested to follow other > sndcards patterns and implmenet it like this. But this does not match other sound cards either. You add here RB1 compatible, which is not used. Look at SM8750 - the front compatible is used. Whatever you decide, please explain in the commit msg the rationale, because currently it looks different than standard/typical choice. > > There is also at least one qrb2210/qcm2290-based board -- UNO Q and at this > point I can't say if it will need separate compatble or can use > qcom,qrb2210-sndcard as a fallback. > > >> Please use subject prefixes matching the subsystem. For bindings, the >> preferred subjects are explained here: >> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > So the order in subject should be reversed. Got it. Not entirely, there is no prefix sound. `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.