Document the USB PHY bindings for Google Tensor SoCs.
Signed-off-by: Roy Luo <royluo@google.com>
---
.../bindings/phy/google,usb-phy.yaml | 91 +++++++++++++++++++
1 file changed, 91 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/google,usb-phy.yaml
diff --git a/Documentation/devicetree/bindings/phy/google,usb-phy.yaml b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml
new file mode 100644
index 000000000000..5552696edfff
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2025, Google LLC
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/google,usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google USB PHY
+
+maintainers:
+ - Roy Luo <royluo@google.com>
+
+description:
+ Describes the USB PHY block on Google Tensor SoCs.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - google,lga-usb-phy
+ - const: google,usb-phy
+
+ reg:
+ minItems: 3
+ maxItems: 3
+
+ reg-names:
+ items:
+ - const: usb2_cfg_csr
+ - const: dp_top_csr
+ - const: usb_top_cfg_csr
+
+ "#phy-cells":
+ const: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: usb2_phy_clk
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ items:
+ - const: usb2_phy_reset
+
+ power-domains:
+ maxItems: 1
+
+ orientation-switch:
+ type: boolean
+ description:
+ Indicates the PHY as a handler of USB Type-C orientation changes
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - "#phy-cells"
+ - clocks
+ - clock-names
+ - resets
+ - reset-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ usb_phy: usb_phy@c410000 {
+ compatible = "google,lga-usb-phy", "google,usb-phy";
+ reg = <0 0x0c450014 0 0xc>,
+ <0 0x0c637000 0 0xa0>,
+ <0 0x0c45002c 0 0x4>;
+ reg-names = "usb2_cfg_csr", "dp_top_csr", "usb_top_cfg_csr";
+ #phy-cells = <1>;
+ clocks = <&hsion_usb2_phy_reset_clk>;
+ clock-names = "usb2_phy_clk";
+ resets = <&hsion_resets_usb2_phy>;
+ reset-names = "usb2_phy_reset";
+ power-domains = <&hsio_n_usb_pd>;
+ orientation-switch;
+ };
+ };
+...
--
2.51.0.618.g983fd99d29-googOn 07/10/2025 08:21, Roy Luo wrote: > Document the USB PHY bindings for Google Tensor SoCs. > > Signed-off-by: Roy Luo <royluo@google.com> > --- > .../bindings/phy/google,usb-phy.yaml | 91 +++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/google,usb-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/google,usb-phy.yaml b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml > new file mode 100644 > index 000000000000..5552696edfff > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2025, Google LLC > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/google,usb-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google USB PHY > + > +maintainers: > + - Roy Luo <royluo@google.com> > + > +description: > + Describes the USB PHY block on Google Tensor SoCs. Which ones? You need to be VERY specific here. > + > +properties: > + compatible: > + items: > + - enum: > + - google,lga-usb-phy > + - const: google,usb-phy Please read carefully bindings. You cannot have generic compatible. Plus you are duplicating existing Samsung bindings. Best regards, Krzysztof
On Mon, Oct 6, 2025 at 5:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 07/10/2025 08:21, Roy Luo wrote: > > Document the USB PHY bindings for Google Tensor SoCs. > > > > Signed-off-by: Roy Luo <royluo@google.com> > > --- > > .../bindings/phy/google,usb-phy.yaml | 91 +++++++++++++++++++ > > 1 file changed, 91 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/google,usb-phy.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/google,usb-phy.yaml b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml > > new file mode 100644 > > index 000000000000..5552696edfff > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/google,usb-phy.yaml > > @@ -0,0 +1,91 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (C) 2025, Google LLC > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/google,usb-phy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google USB PHY > > + > > +maintainers: > > + - Roy Luo <royluo@google.com> > > + > > +description: > > + Describes the USB PHY block on Google Tensor SoCs. > > Which ones? You need to be VERY specific here. This USB PHY is specific to Tensor G5 SoC (and future generations) and thus necessitates new drivers and new bindings. Will update the description and commit message in the next patchset. > > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - google,lga-usb-phy > > + - const: google,usb-phy > > Please read carefully bindings. You cannot have generic compatible. > Plus you are duplicating existing Samsung bindings. > > Best regards, > Krzysztof Will refrain from using generic compatible in the next patchset. Thanks, Roy Luo
© 2016 - 2025 Red Hat, Inc.