[PATCH v5 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible

Wesley Cheng posted 10 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH v5 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible
Posted by Wesley Cheng 2 months, 1 week ago
Add the Glymur compatible to the M31 eUSB2 PHY, and use the SM8750 as
the fallback.

Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
---
 .../bindings/phy/qcom,m31-eusb2-phy.yaml      | 21 ++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
index c84c62d0e8cb..0d5db71e0ad8 100644
--- a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
@@ -15,9 +15,12 @@ description:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - qcom,sm8750-m31-eusb2-phy
+    oneOf:
+      - items:
+          - enum:
+              - qcom,glymur-m31-eusb2-phy
+          - const: qcom,sm8750-m31-eusb2-phy
+      - const: qcom,sm8750-m31-eusb2-phy
 
   reg:
     maxItems: 1
@@ -53,12 +56,20 @@ required:
   - compatible
   - reg
   - "#phy-cells"
-  - clocks
-  - clock-names
   - resets
   - vdd-supply
   - vdda12-supply
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          const: qcom,sm8750-m31-eusb2-phy
+    then:
+      required:
+        - clocks
+        - clock-names
+
 additionalProperties: false
 
 examples:
Re: [PATCH v5 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On 07/10/2025 00:19, Wesley Cheng wrote:
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: qcom,sm8750-m31-eusb2-phy
> +    then:
> +      required:
> +        - clocks
> +        - clock-names

Nothing in commit msg explains why the new phy can run magically without
any clock. Seems unlikely, hardware does not work like that, so this
seems wrong.


Also, don't combine USB patches into other subsystems. I already asked
about this qcom few times.

Best regards,
Krzysztof