[PATCH v5 00/10] Introduce Glymur USB support

Wesley Cheng posted 10 patches 2 months, 1 week ago
There is a newer version of this series
.../bindings/phy/qcom,m31-eusb2-phy.yaml      |  21 +-
.../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  35 +
.../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    |  72 +-
.../phy/qcom,snps-eusb2-repeater.yaml         |   1 +
.../bindings/usb/qcom,snps-dwc3.yaml          |  26 +
.../phy/qualcomm/phy-qcom-eusb2-repeater.c    |  18 +
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c     |   2 +-
drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 352 +++++++++-
.../phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h    |  12 +
.../phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h    |  17 +
.../phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h   |  12 +
.../phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h   |  12 +
.../qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h   | 639 ++++++++++++++++++
drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 163 +++++
.../phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h  |  33 +
.../phy-qcom-qmp-usb43-qserdes-com-v8.h       | 224 ++++++
drivers/phy/qualcomm/phy-qcom-qmp.h           |   2 +
17 files changed, 1622 insertions(+), 19 deletions(-)
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-qserdes-com-v8.h
[PATCH v5 00/10] Introduce Glymur USB support
Posted by Wesley Cheng 2 months, 1 week ago
This series enables the PHY level changes that are required to support
the type C based controllers and the multiport controller.  The typeC
ports utilize a usb43dp based QMP PHY for the SSUSB path, while using
the M31 eUSB2 PHY for the HSUSB path.  For the multiport controller,
it will utilize two QMP UNI PHYs for the SSUSB path, and two M31 eUSB2
PHYs for the HSUSB path.

-----
Changes in v5:
- Moved phy-qcom-qmp-usb43-pcs-v8.h into USB specific QMP driver
- Fixed DT bindings for clock properties for QMP combo PHY

Changes in v4:
- Updated DT bindings change for QMP combo PHY to have IF/THEN blocks
to handle the newly added clkref, and fixed the commit message as well
- Added a new header with v8 offsets for the PCS MISC register set,
and refgen current load for the QMP combo PHY driver
- RE-added the headers for the QMP combo PHY

Changes in v3:
- Fixed some incorrect patch ordering.
- Alphabetized Glymur QMP settings for combo and UNI setting arrays

Changes in v2:
- Updated QMP combo PHY to properly handle the refgen-supply and to
remove the primary core reference/tag
- Updated QMP UNI PHY to properly handle the refgen-supply and added
a separate IF/THEN block to handle the new clkref
- Updated M31 eUSB2 to make clocks and clocks-name required for sm8750
and optional for Glymur
- Fixed missing PCS MISC table
- Added SMB2370 repeater changes

Wesley Cheng (10):
  dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible
  dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible
  dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible
  dt-bindings: usb: qcom,snps-dwc3: Add Glymur compatible
  dt-bindings: phy: qcom,snps-eusb2-repeater: Add SMB2370 compatible
  phy: qualcomm: Update the QMP clamp register for V6
  phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings
  phy: qualcomm: qmp-usb: Add support for Glymur USB UNI PHY
  phy: qualcomm: m31-eusb2: Make clkref an optional resource
  phy: qualcomm: eusb2-repeater: Add SMB2370 eUSB2 repeater support

 .../bindings/phy/qcom,m31-eusb2-phy.yaml      |  21 +-
 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  35 +
 .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    |  72 +-
 .../phy/qcom,snps-eusb2-repeater.yaml         |   1 +
 .../bindings/usb/qcom,snps-dwc3.yaml          |  26 +
 .../phy/qualcomm/phy-qcom-eusb2-repeater.c    |  18 +
 drivers/phy/qualcomm/phy-qcom-m31-eusb2.c     |   2 +-
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 352 +++++++++-
 .../phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h    |  12 +
 .../phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h    |  17 +
 .../phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h   |  12 +
 .../phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h   |  12 +
 .../qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h   | 639 ++++++++++++++++++
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 163 +++++
 .../phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h  |  33 +
 .../phy-qcom-qmp-usb43-qserdes-com-v8.h       | 224 ++++++
 drivers/phy/qualcomm/phy-qcom-qmp.h           |   2 +
 17 files changed, 1622 insertions(+), 19 deletions(-)
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h
 create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-qserdes-com-v8.h
Re: [PATCH v5 00/10] Introduce Glymur USB support
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On 07/10/2025 07:19, Wesley Cheng wrote:
> This series enables the PHY level changes that are required to support
> the type C based controllers and the multiport controller.  The typeC
> ports utilize a usb43dp based QMP PHY for the SSUSB path, while using
> the M31 eUSB2 PHY for the HSUSB path.  For the multiport controller,
> it will utilize two QMP UNI PHYs for the SSUSB path, and two M31 eUSB2
> PHYs for the HSUSB path.
> 
> -----
> Changes in v5:
> - Moved phy-qcom-qmp-usb43-pcs-v8.h into USB specific QMP driver
> - Fixed DT bindings for clock properties for QMP combo PHY
> 

Where are lore links? Why aren't you using b4?

Best regards,
Krzysztof
Re: [PATCH v5 00/10] Introduce Glymur USB support
Posted by Dmitry Baryshkov 2 months, 1 week ago
On Tue, Oct 07, 2025 at 10:02:11AM +0900, Krzysztof Kozlowski wrote:
> On 07/10/2025 07:19, Wesley Cheng wrote:
> > This series enables the PHY level changes that are required to support
> > the type C based controllers and the multiport controller.  The typeC
> > ports utilize a usb43dp based QMP PHY for the SSUSB path, while using
> > the M31 eUSB2 PHY for the HSUSB path.  For the multiport controller,
> > it will utilize two QMP UNI PHYs for the SSUSB path, and two M31 eUSB2
> > PHYs for the HSUSB path.
> > 
> > -----
> > Changes in v5:
> > - Moved phy-qcom-qmp-usb43-pcs-v8.h into USB specific QMP driver
> > - Fixed DT bindings for clock properties for QMP combo PHY
> > 
> 
> Where are lore links? Why aren't you using b4?

Using b4 is the best current practice and it is strongly recommended,
but I don't think that it is a requirement for contributing to Linux
kernel.

-- 
With best wishes
Dmitry
Re: [PATCH v5 00/10] Introduce Glymur USB support
Posted by Wesley Cheng 2 months, 1 week ago

On 10/6/2025 6:02 PM, Krzysztof Kozlowski wrote:
> On 07/10/2025 07:19, Wesley Cheng wrote:
>> This series enables the PHY level changes that are required to support
>> the type C based controllers and the multiport controller.  The typeC
>> ports utilize a usb43dp based QMP PHY for the SSUSB path, while using
>> the M31 eUSB2 PHY for the HSUSB path.  For the multiport controller,
>> it will utilize two QMP UNI PHYs for the SSUSB path, and two M31 eUSB2
>> PHYs for the HSUSB path.
>>
>> -----
>> Changes in v5:
>> - Moved phy-qcom-qmp-usb43-pcs-v8.h into USB specific QMP driver
>> - Fixed DT bindings for clock properties for QMP combo PHY
>>
> 
> Where are lore links? Why aren't you using b4?
> 

Sorry, I'm confused?  Lore links to what exactly?  There aren't any 
dependencies here, in case you mixed up this series with the DT one.

Thanks
Wesley Cheng
Re: [PATCH v5 00/10] Introduce Glymur USB support
Posted by Krzysztof Kozlowski 2 months, 1 week ago
On 07/10/2025 10:05, Wesley Cheng wrote:
> 
> 
> On 10/6/2025 6:02 PM, Krzysztof Kozlowski wrote:
>> On 07/10/2025 07:19, Wesley Cheng wrote:
>>> This series enables the PHY level changes that are required to support
>>> the type C based controllers and the multiport controller.  The typeC
>>> ports utilize a usb43dp based QMP PHY for the SSUSB path, while using
>>> the M31 eUSB2 PHY for the HSUSB path.  For the multiport controller,
>>> it will utilize two QMP UNI PHYs for the SSUSB path, and two M31 eUSB2
>>> PHYs for the HSUSB path.
>>>
>>> -----
>>> Changes in v5:
>>> - Moved phy-qcom-qmp-usb43-pcs-v8.h into USB specific QMP driver
>>> - Fixed DT bindings for clock properties for QMP combo PHY
>>>
>>
>> Where are lore links? Why aren't you using b4?
>>
> 
> Sorry, I'm confused?  Lore links to what exactly?  There aren't any 
> dependencies here, in case you mixed up this series with the DT one.

Lore links to the previous versions. They are added automatically.

Best regards,
Krzysztof