From: Arnd Bergmann <arnd@arndb.de>

Old binutils versions require a slightly stricter syntax for the .arch_extension
directive and fail with the extra semicolon:

/tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'

Drop the semicolon to make it work with all supported toolchain version.

Link: https://lore.kernel.org/all/20251001163655.GA370262@ax162/
Reported-by: Paolo Abeni <pabeni@redhat.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Fixes: fd8c8216648c ("net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/mellanox/mlx5/core/wc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
index c281153bd411..05e5fd777d4f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
@@ -266,7 +266,7 @@ static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
 	if (cpu_has_neon()) {
 		kernel_neon_begin();
 		asm volatile
-		(".arch_extension simd;\n\t"
+		(".arch_extension simd\n\t"
 		"ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%0]\n\t"
 		"st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%1]"
 		:
-- 
2.39.5

On Mon, Oct 06, 2025 at 01:56:34PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Old binutils versions require a slightly stricter syntax for the .arch_extension
> directive and fail with the extra semicolon:
> 
> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
> 
> Drop the semicolon to make it work with all supported toolchain version.
> 
> Link: https://lore.kernel.org/all/20251001163655.GA370262@ax162/
> Reported-by: Paolo Abeni <pabeni@redhat.com>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Fixes: fd8c8216648c ("net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/wc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> index c281153bd411..05e5fd777d4f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> @@ -266,7 +266,7 @@ static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
>  	if (cpu_has_neon()) {
>  		kernel_neon_begin();
>  		asm volatile
> -		(".arch_extension simd;\n\t"
> +		(".arch_extension simd\n\t"
>  		"ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%0]\n\t"
>  		"st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%1]"
>  		:
> -- 
> 2.39.5
>

On Mon,  6 Oct 2025 13:56:34 +0200 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Old binutils versions require a slightly stricter syntax for the .arch_extension
> directive and fail with the extra semicolon:
> 
> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
> 
> Drop the semicolon to make it work with all supported toolchain version.

Saeed, could you ack? I think we should get this merged quickly since
it's a build fix.

Thanks Arnd

On 10/6/2025 9:21 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon,  6 Oct 2025 13:56:34 +0200 Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Old binutils versions require a slightly stricter syntax for the .arch_extension
>> directive and fail with the extra semicolon:
>>
>> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
>>
>> Drop the semicolon to make it work with all supported toolchain version.
Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
> Saeed, could you ack? I think we should get this merged quickly since
> it's a build fix.

If my ack is enough you can merge, was planning to send this fix myself.

Thanks,
Patrisious.