Hi,

There here patches clean up the scheduler 'change' pattern and related locking
some. They are the less controversial bit of some proposed sched_ext changes
and stand on their own.

I would like to queue them into sched/core after the merge window.


Also in:

  git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/cleanup

---
 include/linux/cleanup.h  |   5 +
 include/linux/sched.h    |   4 +-
 kernel/cgroup/cpuset.c   |   2 +-
 kernel/kthread.c         |  15 +--
 kernel/sched/core.c      | 327 ++++++++++++++++++-----------------------------
 kernel/sched/deadline.c  |  20 +--
 kernel/sched/ext.c       |  47 +++----
 kernel/sched/fair.c      |  15 ++-
 kernel/sched/idle.c      |   9 +-
 kernel/sched/rt.c        |   7 +-
 kernel/sched/sched.h     | 198 ++++++++++++++++++++--------
 kernel/sched/stats.h     |   2 +-
 kernel/sched/stop_task.c |   9 +-
 kernel/sched/syscalls.c  |  84 ++++--------
 14 files changed, 373 insertions(+), 371 deletions(-)

On 06/10/25 12:44, Peter Zijlstra wrote:
> Hi,
>
> There here patches clean up the scheduler 'change' pattern and related locking
> some. They are the less controversial bit of some proposed sched_ext changes
> and stand on their own.
>
> I would like to queue them into sched/core after the merge window.
>
>
> Also in:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/cleanup
>

Other than what's already been said, that LGTM. It's good to finally have a
canonical change pattern... pattern? :-)

Reviewed-by: Valentin Schneider <vschneid@redhat.com>

On Mon, Oct 06, 2025 at 12:44:02PM +0200, Peter Zijlstra wrote:
> 
> Hi,
> 
> There here patches clean up the scheduler 'change' pattern and related locking
> some. They are the less controversial bit of some proposed sched_ext changes
> and stand on their own.
> 
> I would like to queue them into sched/core after the merge window.

FWIW, all look good to me.

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

On Mon, 6 Oct 2025 at 12:46, Peter Zijlstra <peterz@infradead.org> wrote:
>
>
> Hi,
>
> There here patches clean up the scheduler 'change' pattern and related locking
> some. They are the less controversial bit of some proposed sched_ext changes
> and stand on their own.
>
> I would like to queue them into sched/core after the merge window.

Acked-by: Vincent Guittot <vincent.guittot@linaro.org> for the serie
in addition to the reviewed-by for patch 4

>
>
> Also in:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/cleanup
>
> ---
>  include/linux/cleanup.h  |   5 +
>  include/linux/sched.h    |   4 +-
>  kernel/cgroup/cpuset.c   |   2 +-
>  kernel/kthread.c         |  15 +--
>  kernel/sched/core.c      | 327 ++++++++++++++++++-----------------------------
>  kernel/sched/deadline.c  |  20 +--
>  kernel/sched/ext.c       |  47 +++----
>  kernel/sched/fair.c      |  15 ++-
>  kernel/sched/idle.c      |   9 +-
>  kernel/sched/rt.c        |   7 +-
>  kernel/sched/sched.h     | 198 ++++++++++++++++++++--------
>  kernel/sched/stats.h     |   2 +-
>  kernel/sched/stop_task.c |   9 +-
>  kernel/sched/syscalls.c  |  84 ++++--------
>  14 files changed, 373 insertions(+), 371 deletions(-)
>
>
>

Hi Peter,

On 06/10/25 12:44, Peter Zijlstra wrote:
> 
> Hi,
> 
> There here patches clean up the scheduler 'change' pattern and related locking
> some. They are the less controversial bit of some proposed sched_ext changes
> and stand on their own.
> 
> I would like to queue them into sched/core after the merge window.

The set looks good to me.

Reviewed-by: Juri Lelli <juri.lelli@redhat.com>

For the DEADLINE bits also

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Best,
Juri

Hi Peter,

On Mon, Oct 06, 2025 at 12:44:02PM +0200, Peter Zijlstra wrote:
> 
> Hi,
> 
> There here patches clean up the scheduler 'change' pattern and related locking
> some. They are the less controversial bit of some proposed sched_ext changes
> and stand on their own.
> 
> I would like to queue them into sched/core after the merge window.

They all look sane changes to me. I've also stress-tested this quite a bit,
even with the sched_ext dl_server patch set applied, and everything appears
to work well.

Therefore, from a sched_ext perspective:

Acked-by: Andrea Righi <arighi@nvidia.com>

Thanks!
-Andrea

> 
> 
> Also in:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/cleanup
> 
> ---
>  include/linux/cleanup.h  |   5 +
>  include/linux/sched.h    |   4 +-
>  kernel/cgroup/cpuset.c   |   2 +-
>  kernel/kthread.c         |  15 +--
>  kernel/sched/core.c      | 327 ++++++++++++++++++-----------------------------
>  kernel/sched/deadline.c  |  20 +--
>  kernel/sched/ext.c       |  47 +++----
>  kernel/sched/fair.c      |  15 ++-
>  kernel/sched/idle.c      |   9 +-
>  kernel/sched/rt.c        |   7 +-
>  kernel/sched/sched.h     | 198 ++++++++++++++++++++--------
>  kernel/sched/stats.h     |   2 +-
>  kernel/sched/stop_task.c |   9 +-
>  kernel/sched/syscalls.c  |  84 ++++--------
>  14 files changed, 373 insertions(+), 371 deletions(-)
> 
>