.../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
This reverts commit 3bad7fe22796a420c6e16b591c37ed1bd6cc2a30.
Referencing the usb-switch.yaml also imports the ports definition which
collides with the definition in the qcom,sc8280xp-qmp-usb43dp bindings
and also enforces ports as required which breaks DT bidnings check on
a lot of boards DT.
Until the granularity of the usb-switch.yaml bindings allows us to
only reference the mode-switch & orientation-switch, it's simpler to
revert the change and start again.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v2:
- Instead of splitting or loosely referencing usb-switch, just revert and start again
- Link to v1: https://lore.kernel.org/r/20250930-topic-sm8x50-fix-qmp-usb43dp-usb-switch-v1-1-060568de9538@linaro.org
---
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
index c8bc512df08b5694c8599f475de78679a4438449..38ce04c35d945d0d8d319191c241920810ee9005 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
@@ -73,8 +73,10 @@ properties:
description:
See include/dt-bindings/phy/phy-qcom-qmp.h
- mode-switch: true
- orientation-switch: true
+ orientation-switch:
+ description:
+ Flag the PHY as possible handler of USB Type-C orientation switching
+ type: boolean
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -104,7 +106,6 @@ required:
- "#phy-cells"
allOf:
- - $ref: /schemas/usb/usb-switch.yaml#
- if:
properties:
compatible:
---
base-commit: 262858079afde6d367ce3db183c74d8a43a0e83f
change-id: 20250930-topic-sm8x50-fix-qmp-usb43dp-usb-switch-0c84e0b5f361
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
On Mon, 06 Oct 2025 10:49:04 +0200, Neil Armstrong wrote: > This reverts commit 3bad7fe22796a420c6e16b591c37ed1bd6cc2a30. > > Referencing the usb-switch.yaml also imports the ports definition which > collides with the definition in the qcom,sc8280xp-qmp-usb43dp bindings > and also enforces ports as required which breaks DT bidnings check on > a lot of boards DT. > > Until the granularity of the usb-switch.yaml bindings allows us to > only reference the mode-switch & orientation-switch, it's simpler to > revert the change and start again. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Changes in v2: > - Instead of splitting or loosely referencing usb-switch, just revert and start again > - Link to v1: https://lore.kernel.org/r/20250930-topic-sm8x50-fix-qmp-usb43dp-usb-switch-v1-1-060568de9538@linaro.org > --- > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
© 2016 - 2026 Red Hat, Inc.