timers/migration: Remove redundant ternary operator

[PATCH] timers/migration: Remove redundant ternary operator

Posted by Fushuai Wang 2 months, 1 week ago

The ternary operator is redundant here, so remove it.

Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
 kernel/time/timer_migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
index c0c54dc5314c..b869b244025f 100644
--- a/kernel/time/timer_migration.c
+++ b/kernel/time/timer_migration.c
@@ -751,7 +751,7 @@ bool tmigr_update_events(struct tmigr_group *group, struct tmigr_group *child,
 		 * be scheduled. If the activate wins, the event is properly
 		 * ignored.
 		 */
-		ignore = (nextexp == KTIME_MAX) ? true : false;
+		ignore = (nextexp == KTIME_MAX);
 		WRITE_ONCE(evt->ignore, ignore);
 	} else {
 		nextexp = data->nextexp;
-- 
2.36.1

Re: [PATCH] timers/migration: Remove redundant ternary operator

Posted by Thomas Gleixner 1 month, 2 weeks ago

On Sun, Oct 05 2025 at 15:30, Fushuai Wang wrote:

> The ternary operator is redundant here, so remove it.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> ---
>  kernel/time/timer_migration.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
> index c0c54dc5314c..b869b244025f 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -751,7 +751,7 @@ bool tmigr_update_events(struct tmigr_group *group, struct tmigr_group *child,
>  		 * be scheduled. If the activate wins, the event is properly
>  		 * ignored.
>  		 */
> -		ignore = (nextexp == KTIME_MAX) ? true : false;
> +		ignore = (nextexp == KTIME_MAX);

The parentheses are pointless too, no?