[PATCH v4 06/19] iio: accel: bma220: cleanup includes

Petre Rodan posted 19 patches 2 months, 1 week ago
[PATCH v4 06/19] iio: accel: bma220: cleanup includes
Posted by Petre Rodan 2 months, 1 week ago
Tweak includes based on requirements.

Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
v4 split from bigger patch (Andy)
---
 drivers/iio/accel/bma220_spi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c
index 45ac0d7ee27de65b204bd2766f26024e4ed57f4c..abff24a48e5aaa5efb05cdf1924ffea24f4da4c5 100644
--- a/drivers/iio/accel/bma220_spi.c
+++ b/drivers/iio/accel/bma220_spi.c
@@ -6,9 +6,10 @@
  */
 
 #include <linux/bits.h>
-#include <linux/kernel.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/pm.h>
 #include <linux/types.h>
 #include <linux/spi/spi.h>
 

-- 
2.49.1
Re: [PATCH v4 06/19] iio: accel: bma220: cleanup includes
Posted by Jonathan Cameron 2 months ago
On Sun, 05 Oct 2025 16:12:15 +0300
Petre Rodan <petre.rodan@subdimension.ro> wrote:

> Tweak includes based on requirements.
> 
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
see next patch. I tweaked this as below
> ---
> v4 split from bigger patch (Andy)
> ---
>  drivers/iio/accel/bma220_spi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c
> index 45ac0d7ee27de65b204bd2766f26024e4ed57f4c..abff24a48e5aaa5efb05cdf1924ffea24f4da4c5 100644
> --- a/drivers/iio/accel/bma220_spi.c
> +++ b/drivers/iio/accel/bma220_spi.c
> @@ -6,9 +6,10 @@
>   */
>  
>  #include <linux/bits.h>

#include <linux/errno.h>

which otherwise was added in next patch with no related code changes that I could spot.
It definitely should be here for EBUSY etc.

> -#include <linux/kernel.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/pm.h>
>  #include <linux/types.h>
>  #include <linux/spi/spi.h>
>  
>
Re: [PATCH v4 06/19] iio: accel: bma220: cleanup includes
Posted by Jonathan Cameron 2 months ago
On Sun, 05 Oct 2025 16:12:15 +0300
Petre Rodan <petre.rodan@subdimension.ro> wrote:

> Tweak includes based on requirements.
> 
> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
Applied.