usb: serial: fix: trainling statements `break` should be on next line

[PATCH] usb: serial: fix: trainling statements `break` should be on next line

Posted by vivekyadav1207731111@gmail.com 2 months, 2 weeks ago

From: Vivek Yadav <vivekyadav1207731111@gmail.com>

Run `checkpatch.pl` script on path `drivers/usb/serial/*`
Find ERROR: trailing statements should be on next line

Doesn't claim any functionality changes in any of the modified
file.

Signed-off-by: Vivek Yadav <vivekyadav1207731111@gmail.com>
---
 drivers/usb/serial/mct_u232.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index 2bce8cc03aca..41b80a075b87 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -153,16 +153,17 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
 		   divider = 115200/value;
 		   real baud = 115200/divider */
 		switch (value) {
-		case 300: break;
-		case 600: break;
-		case 1200: break;
-		case 2400: break;
-		case 4800: break;
-		case 9600: break;
-		case 19200: break;
-		case 38400: break;
-		case 57600: break;
-		case 115200: break;
+		case 300:
+		case 600:
+		case 1200:
+		case 2400:
+		case 4800:
+		case 9600:
+		case 19200:
+		case 38400:
+		case 57600:
+		case 115200:
+			break;
 		default:
 			value = 9600;
 			*result = 9600;
-- 
2.43.0

Re: [PATCH] usb: serial: fix: trainling statements `break` should be on next line

Posted by David Hunter 2 months, 1 week ago

On 10/4/25 04:01, vivekyadav1207731111@gmail.com wrote:

> +		case 300:
> +		case 600:
> +		case 1200:
> +		case 2400:
> +		case 4800:
> +		case 9600:
> +		case 19200:
> +		case 38400:
> +		case 57600:
> +		case 115200:
> +			break;

It is generally considered best practice to use the breaks after each
case. Here is a good article on this:

https://lwn.net/Articles/794944/


Also, same here. no top-posting:

https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

Re: [PATCH] usb: serial: fix: trainling statements `break` should be on next line

Posted by Johan Hovold 2 months, 1 week ago

On Sat, Oct 04, 2025 at 01:31:23PM +0530, vivekyadav1207731111@gmail.com wrote:
> From: Vivek Yadav <vivekyadav1207731111@gmail.com>
> 
> Run `checkpatch.pl` script on path `drivers/usb/serial/*`

Same here, don't do that.

Johan

Re: [PATCH] usb: serial: fix: trainling statements `break` should be on next line

Posted by vivek yadav 2 months, 1 week ago

Hi Johan,
Thanks for giving time for the review of my patch.
I understand your point and will avoid such kind of practice.


~~Vivek

On Mon, Oct 6, 2025 at 5:43 PM Johan Hovold <johan@kernel.org> wrote:
>
> On Sat, Oct 04, 2025 at 01:31:23PM +0530, vivekyadav1207731111@gmail.com wrote:
> > From: Vivek Yadav <vivekyadav1207731111@gmail.com>
> >
> > Run `checkpatch.pl` script on path `drivers/usb/serial/*`
>
> Same here, don't do that.
>
> Johan