drivers/usb/serial/ark3116.c | 12 ++++++------ drivers/usb/serial/ftdi_sio.c | 2 +- drivers/usb/serial/iuu_phoenix.c | 4 ++-- drivers/usb/serial/keyspan_usa90msg.h | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-)
From: Vivek Yadav <vivekyadav1207731111@gmail.com>
Run `checkpatch.pl` script on path `drivers/usb/serial/*`.
Find ERROR: space prohibited before that ',' (ctx:WxE).
Doesn't claim any functionality changes in any of the modified
file.
Signed-off-by: Vivek Yadav <vivekyadav1207731111@gmail.com>
---
drivers/usb/serial/ark3116.c | 12 ++++++------
drivers/usb/serial/ftdi_sio.c | 2 +-
drivers/usb/serial/iuu_phoenix.c | 4 ++--
drivers/usb/serial/keyspan_usa90msg.h | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index 800b04fe37fa..f1cc4e36e4e6 100644
--- a/drivers/usb/serial/ark3116.c
+++ b/drivers/usb/serial/ark3116.c
@@ -143,18 +143,18 @@ static int ark3116_port_probe(struct usb_serial_port *port)
ark3116_write_reg(serial, UART_FCR, 0);
/* handshake control */
priv->hcr = 0;
- ark3116_write_reg(serial, 0x8 , 0);
+ ark3116_write_reg(serial, 0x8, 0);
/* modem control */
priv->mcr = 0;
ark3116_write_reg(serial, UART_MCR, 0);
if (!(priv->irda)) {
- ark3116_write_reg(serial, 0xb , 0);
+ ark3116_write_reg(serial, 0xb, 0);
} else {
- ark3116_write_reg(serial, 0xb , 1);
- ark3116_write_reg(serial, 0xc , 0);
- ark3116_write_reg(serial, 0xd , 0x41);
- ark3116_write_reg(serial, 0xa , 1);
+ ark3116_write_reg(serial, 0xb, 1);
+ ark3116_write_reg(serial, 0xc, 0);
+ ark3116_write_reg(serial, 0xd, 0x41);
+ ark3116_write_reg(serial, 0xa, 1);
}
/* setup baudrate */
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 49666c33b41f..f5d4335c4f6c 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -190,7 +190,7 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_ALT_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_232RL_PID) },
- { USB_DEVICE(FTDI_VID, FTDI_8U2232C_PID) ,
+ { USB_DEVICE(FTDI_VID, FTDI_8U2232C_PID),
.driver_info = (kernel_ulong_t)&ftdi_8u2232c_quirk },
{ USB_DEVICE(FTDI_VID, FTDI_4232H_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_232H_PID) },
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index c21dcc9b6f05..fc71aaea3229 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -360,7 +360,7 @@ static void iuu_led_activity_on(struct urb *urb)
usb_fill_bulk_urb(port->write_urb, port->serial->dev,
usb_sndbulkpipe(port->serial->dev,
port->bulk_out_endpointAddress),
- port->write_urb->transfer_buffer, 8 ,
+ port->write_urb->transfer_buffer, 8,
iuu_rxcmd, port);
usb_submit_urb(port->write_urb, GFP_ATOMIC);
}
@@ -380,7 +380,7 @@ static void iuu_led_activity_off(struct urb *urb)
usb_fill_bulk_urb(port->write_urb, port->serial->dev,
usb_sndbulkpipe(port->serial->dev,
port->bulk_out_endpointAddress),
- port->write_urb->transfer_buffer, 8 ,
+ port->write_urb->transfer_buffer, 8,
iuu_rxcmd, port);
usb_submit_urb(port->write_urb, GFP_ATOMIC);
}
diff --git a/drivers/usb/serial/keyspan_usa90msg.h b/drivers/usb/serial/keyspan_usa90msg.h
index c4ca0f631d20..e01df75140c7 100644
--- a/drivers/usb/serial/keyspan_usa90msg.h
+++ b/drivers/usb/serial/keyspan_usa90msg.h
@@ -69,7 +69,7 @@ struct keyspan_usa90_portControlMessage
txMode, // TXMODE_DMA or TXMODE_BYHAND
setTxFlowControl, // host requests tx flow control be set
- txFlowControl , // use TX_FLOW... bits below
+ txFlowControl, // use TX_FLOW... bits below
setRxFlowControl, // host requests rx flow control be set
rxFlowControl, // use RX_FLOW... bits below
sendXoff, // host requests XOFF transmitted immediately
--
2.43.0On Sat, Oct 04, 2025 at 12:26:18PM +0530, vivekyadav1207731111@gmail.com wrote: > From: Vivek Yadav <vivekyadav1207731111@gmail.com> > > Run `checkpatch.pl` script on path `drivers/usb/serial/*`. Yeah, don't do that, that is, don't run checkpatch on code that's already in the tree. Use it on your on patches before submitting them to catch potential issues, but always use your own judgement when considering its output. If you just want to practise sending patches, changes like these are accepted for drivers/staging for that purpose. Johan
Hi Johan, Thanks for giving time for the review of my patch. I understand your point and will avoid such kind of practice. ~~Vivek On Mon, Oct 6, 2025 at 5:42 PM Johan Hovold <johan@kernel.org> wrote: > > On Sat, Oct 04, 2025 at 12:26:18PM +0530, vivekyadav1207731111@gmail.com wrote: > > From: Vivek Yadav <vivekyadav1207731111@gmail.com> > > > > Run `checkpatch.pl` script on path `drivers/usb/serial/*`. > > Yeah, don't do that, that is, don't run checkpatch on code that's > already in the tree. Use it on your on patches before submitting them to > catch potential issues, but always use your own judgement when > considering its output. > > If you just want to practise sending patches, changes like these are > accepted for drivers/staging for that purpose. > > Johan
On 10/6/25 13:54, vivek yadav wrote: > Hi Johan, > Thanks for giving time for the review of my patch. > I understand your point and will avoid such kind of practice. > > > ~~Vivek > > On Mon, Oct 6, 2025 at 5:42 PM Johan Hovold <johan@kernel.org> wrote: >> >> On Sat, Oct 04, 2025 at 12:26:18PM +0530, vivekyadav1207731111@gmail.com wrote: >>> From: Vivek Yadav <vivekyadav1207731111@gmail.com> >>> >>> Run `checkpatch.pl` script on path `drivers/usb/serial/*`. >> >> Yeah, don't do that, that is, don't run checkpatch on code that's >> already in the tree. Use it on your on patches before submitting them to >> catch potential issues, but always use your own judgement when >> considering its output. >> >> If you just want to practise sending patches, changes like these are >> accepted for drivers/staging for that purpose. >> >> Johan Please don't top-post. please look at the following wikipedia page to see what top-post means: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
© 2016 - 2025 Red Hat, Inc.