[PATCH 2/2] arm64: dts: qcom: pmi8950: Fix VADC channel scaling factors

Antony Kurniawan Soemardi posted 2 patches 2 months, 2 weeks ago
[PATCH 2/2] arm64: dts: qcom: pmi8950: Fix VADC channel scaling factors
Posted by Antony Kurniawan Soemardi 2 months, 2 weeks ago
Fix USBIN/DCIN scaling to match the downstream implementation [1].

Downstream defines the following scaling mappings [2], corresponding
to mainline pre-scaling values:

  <4>  ->  <1 20>
  <1>  ->  <1 3>

[1] https://github.com/LineageOS/android_kernel_qcom_msm8953/blob/e6b46fc6f52e754eef5ce6265c7d82a3622e0b0f/arch/arm64/boot/dts/qcom/pmi8950.dtsi#L55-L86
[2] https://github.com/LineageOS/android_kernel_qcom_msm8953/blob/e6b46fc6f52e754eef5ce6265c7d82a3622e0b0f/include/linux/qpnp/qpnp-adc.h#L342-L357

Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com>
---
 arch/arm64/boot/dts/qcom/pmi8950.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index 16e436b68a7c161b1afd4f3eac3d7d8564e40512..5bd91a5cd1245f34ef37d98b1a2669582e84876c 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -22,19 +22,19 @@ pmi8950_vadc: adc@3100 {
 
 			channel@0 {
 				reg = <VADC_USBIN>;
-				qcom,pre-scaling = <1 4>;
+				qcom,pre-scaling = <1 20>;
 				label = "usbin";
 			};
 
 			channel@1 {
 				reg = <VADC_DCIN>;
-				qcom,pre-scaling = <1 4>;
+				qcom,pre-scaling = <1 20>;
 				label = "dcin";
 			};
 
 			channel@2 {
 				reg = <VADC_VCHG_SNS>;
-				qcom,pre-scaling = <1 1>;
+				qcom,pre-scaling = <1 3>;
 				label = "vchg_sns";
 			};
 

-- 
2.34.1
Re: [PATCH 2/2] arm64: dts: qcom: pmi8950: Fix VADC channel scaling factors
Posted by Konrad Dybcio 2 months, 1 week ago
On 10/4/25 3:12 PM, Antony Kurniawan Soemardi wrote:
> Fix USBIN/DCIN scaling to match the downstream implementation [1].
> 
> Downstream defines the following scaling mappings [2], corresponding
> to mainline pre-scaling values:
> 
>   <4>  ->  <1 20>
>   <1>  ->  <1 3>
> 
> [1] https://github.com/LineageOS/android_kernel_qcom_msm8953/blob/e6b46fc6f52e754eef5ce6265c7d82a3622e0b0f/arch/arm64/boot/dts/qcom/pmi8950.dtsi#L55-L86
> [2] https://github.com/LineageOS/android_kernel_qcom_msm8953/blob/e6b46fc6f52e754eef5ce6265c7d82a3622e0b0f/include/linux/qpnp/qpnp-adc.h#L342-L357
> 
> Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad