[PATCH 1/2] arm64: dts: qcom: pmi8950: Add missing VADC channels

Antony Kurniawan Soemardi posted 2 patches 2 months, 2 weeks ago
[PATCH 1/2] arm64: dts: qcom: pmi8950: Add missing VADC channels
Posted by Antony Kurniawan Soemardi 2 months, 2 weeks ago
When booting msm8953-based devices, the following kernel message
appears:
[ 13.090800] qcom-spmi-vadc 200f000.spmi:pmic@2:adc@3100: Please define VDD channel

It turns out the pmi8950 uses same VDD and GND channels as other
Qualcomm's PMICs, so we can simply copy the channel definition from
the other Qualcomm's PMIC dtsi.

Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com>
---
 arch/arm64/boot/dts/qcom/pmi8950.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index 3d3b1cd97cc3d04b2c5a78c06fbeb3fee3c5af8d..16e436b68a7c161b1afd4f3eac3d7d8564e40512 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -55,6 +55,14 @@ channel@d {
 				qcom,pre-scaling = <1 1>;
 				label = "chg_temp";
 			};
+
+			channel@e {
+				reg = <VADC_GND_REF>;
+			};
+
+			channel@f {
+				reg = <VADC_VDD_VADC>;
+			};
 		};
 
 		pmi8950_mpps: mpps@a000 {

-- 
2.34.1
Re: [PATCH 1/2] arm64: dts: qcom: pmi8950: Add missing VADC channels
Posted by Konrad Dybcio 2 months, 1 week ago
On 10/4/25 3:12 PM, Antony Kurniawan Soemardi wrote:
> When booting msm8953-based devices, the following kernel message
> appears:
> [ 13.090800] qcom-spmi-vadc 200f000.spmi:pmic@2:adc@3100: Please define VDD channel
> 
> It turns out the pmi8950 uses same VDD and GND channels as other
> Qualcomm's PMICs, so we can simply copy the channel definition from
> the other Qualcomm's PMIC dtsi.
> 
> Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad