MAINTAINERS: add Denis Benato as maintainer for asus notebooks

[PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by Denis Benato 4 months, 1 week ago

Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
DRIVERS" as suggested by Hans de Goede and Armin Wolf.

Signed-off-by: Denis Benato <benato.denis96@gmail.com>
Link: https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 156fa8eefa69..81bcb934748d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3841,6 +3841,7 @@ F:	drivers/hwmon/asus-ec-sensors.c
 ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
 M:	Corentin Chary <corentin.chary@gmail.com>
 M:	Luke D. Jones <luke@ljones.dev>
+M:	Denis Benato <benato.denis96@gmail.com>
 L:	platform-driver-x86@vger.kernel.org
 S:	Maintained
 W:	https://asus-linux.org/
-- 
2.51.0

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by luke@ljones.dev 4 months ago


> On 3 Oct 2025, at 20:49, Denis Benato <benato.denis96@gmail.com> wrote:
> 
> Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
> DRIVERS" as suggested by Hans de Goede and Armin Wolf.
> 
> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
> Link: https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 156fa8eefa69..81bcb934748d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3841,6 +3841,7 @@ F: drivers/hwmon/asus-ec-sensors.c
> ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
> M: Corentin Chary <corentin.chary@gmail.com>
> M: Luke D. Jones <luke@ljones.dev>
> +M: Denis Benato <benato.denis96@gmail.com>
> L: platform-driver-x86@vger.kernel.org
> S: Maintained
> W: https://asus-linux.org/
> -- 
> 2.51.0
> 

Acked-by: Luke Jones <luke@ljones.dev>

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by Hans de Goede 4 months, 1 week ago

Hi,

On 3-Oct-25 8:49 PM, Denis Benato wrote:
> Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
> DRIVERS" as suggested by Hans de Goede and Armin Wolf.
> 
> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
> Link: https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans



> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 156fa8eefa69..81bcb934748d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3841,6 +3841,7 @@ F:	drivers/hwmon/asus-ec-sensors.c
>  ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
>  M:	Corentin Chary <corentin.chary@gmail.com>
>  M:	Luke D. Jones <luke@ljones.dev>
> +M:	Denis Benato <benato.denis96@gmail.com>
>  L:	platform-driver-x86@vger.kernel.org
>  S:	Maintained
>  W:	https://asus-linux.org/

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by Mario Limonciello (AMD) (kernel.org) 4 months ago


On 10/3/2025 1:58 PM, Hans de Goede wrote:
> Hi,
> 
> On 3-Oct-25 8:49 PM, Denis Benato wrote:
>> Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
>> DRIVERS" as suggested by Hans de Goede and Armin Wolf.
>>
>> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
>> Link: https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com
> 
> Thanks, patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hansg@kernel.org>
> 
> Regards,
> 
> Hans

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

Luke,

You are planning to step down from maintainer too, right?  Can you send 
a last patch doing that too?  Or let Denis send one and Ack that?

> 
> 
> 
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 156fa8eefa69..81bcb934748d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3841,6 +3841,7 @@ F:	drivers/hwmon/asus-ec-sensors.c
>>   ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
>>   M:	Corentin Chary <corentin.chary@gmail.com>
>>   M:	Luke D. Jones <luke@ljones.dev>
>> +M:	Denis Benato <benato.denis96@gmail.com>
>>   L:	platform-driver-x86@vger.kernel.org
>>   S:	Maintained
>>   W:	https://asus-linux.org/
> 
>

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by Ilpo Järvinen 4 months ago

On Fri, 3 Oct 2025, Mario Limonciello (AMD) (kernel.org) wrote:
> On 10/3/2025 1:58 PM, Hans de Goede wrote:
> > On 3-Oct-25 8:49 PM, Denis Benato wrote:
> > > Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
> > > DRIVERS" as suggested by Hans de Goede and Armin Wolf.
> > > 
> > > Signed-off-by: Denis Benato <benato.denis96@gmail.com>
> > > Link:
> > > https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com
> > 
> > Thanks, patch looks good to me:
> > 
> > Reviewed-by: Hans de Goede <hansg@kernel.org>
> > 
> > Regards,
> > 
> > Hans
> 
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> 
> Luke,
> 
> You are planning to step down from maintainer too, right?  Can you send a last
> patch doing that too?  Or let Denis send one and Ack that?
> 
> > 
> > 
> > 
> > > ---
> > >   MAINTAINERS | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 156fa8eefa69..81bcb934748d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -3841,6 +3841,7 @@ F:	drivers/hwmon/asus-ec-sensors.c
> > >   ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
> > >   M:	Corentin Chary <corentin.chary@gmail.com>
> > >   M:	Luke D. Jones <luke@ljones.dev>
> > > +M:	Denis Benato <benato.denis96@gmail.com>
> > >   L:	platform-driver-x86@vger.kernel.org
> > >   S:	Maintained
> > >   W:	https://asus-linux.org/

Hi all,

Unrelated to the patch itself, I'm more wondering if Corentin Chary 
<corentin.chary@gmail.com> is still around as I don't recall ever hearing 
anything from that address in any context. The latest email from that 
address lore.kernel.org could find is from 2017.

Maybe we should remove that address from the maintainers list?

-- 
 i.

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by luke@ljones.dev 4 months ago


> On 6 Oct 2025, at 10:31, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> 
> On Fri, 3 Oct 2025, Mario Limonciello (AMD) (kernel.org) wrote:
>> On 10/3/2025 1:58 PM, Hans de Goede wrote:
>>> On 3-Oct-25 8:49 PM, Denis Benato wrote:
>>>> Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
>>>> DRIVERS" as suggested by Hans de Goede and Armin Wolf.
>>>> 
>>>> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
>>>> Link:
>>>> https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com
>>> 
>>> Thanks, patch looks good to me:
>>> 
>>> Reviewed-by: Hans de Goede <hansg@kernel.org>
>>> 
>>> Regards,
>>> 
>>> Hans
>> 
>> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>> 
>> Luke,
>> 
>> You are planning to step down from maintainer too, right?  Can you send a last
>> patch doing that too?  Or let Denis send one and Ack that?

I will eventually step down yes. Denis asked me to stay on for the moment.

>> 
>>> 
>>> 
>>> 
>>>> ---
>>>>  MAINTAINERS | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>> 
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 156fa8eefa69..81bcb934748d 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -3841,6 +3841,7 @@ F: drivers/hwmon/asus-ec-sensors.c
>>>>  ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
>>>>  M: Corentin Chary <corentin.chary@gmail.com>
>>>>  M: Luke D. Jones <luke@ljones.dev>
>>>> +M: Denis Benato <benato.denis96@gmail.com>
>>>>  L: platform-driver-x86@vger.kernel.org
>>>>  S: Maintained
>>>>  W: https://asus-linux.org/
> 
> Hi all,
> 
> Unrelated to the patch itself, I'm more wondering if Corentin Chary 
> <corentin.chary@gmail.com> is still around as I don't recall ever hearing 
> anything from that address in any context. The latest email from that 
> address lore.kernel.org could find is from 2017.
> 
> Maybe we should remove that address from the maintainers list?

I’d been wondering if that should be done. Though never was sure of the process or if that was okay.

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by Ilpo Järvinen 4 months ago

On Mon, 6 Oct 2025, luke@ljones.dev wrote:
> > On 6 Oct 2025, at 10:31, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> > On Fri, 3 Oct 2025, Mario Limonciello (AMD) (kernel.org) wrote:
> >> On 10/3/2025 1:58 PM, Hans de Goede wrote:
> >>> On 3-Oct-25 8:49 PM, Denis Benato wrote:
> >>>> Add myself as maintainer for "ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS
> >>>> DRIVERS" as suggested by Hans de Goede and Armin Wolf.
> >>>> 
> >>>> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
> >>>> Link:
> >>>> https://lore.kernel.org/all/8128cd6b-50e3-464c-90c2-781f61c3963e@gmail.com
> >>> 
> >>> Thanks, patch looks good to me:
> >>> 
> >>> Reviewed-by: Hans de Goede <hansg@kernel.org>
> >>> 
> >>> Regards,
> >>> 
> >>> Hans
> >> 
> >> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> >> 
> >> Luke,
> >> 
> >> You are planning to step down from maintainer too, right?  Can you send a last
> >> patch doing that too?  Or let Denis send one and Ack that?
> 
> I will eventually step down yes. Denis asked me to stay on for the moment.

Fine, no pressure either way.

Could you please send your Acked-by tag to this thread so it will get 
captured into this thread so the tools will capture it when I'm applying 
the patch (assuming you're okay with him becoming a co-maintainer with 
you, which I think is the case here :-)).

> >>>> ---
> >>>>  MAINTAINERS | 1 +
> >>>>  1 file changed, 1 insertion(+)
> >>>> 
> >>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>> index 156fa8eefa69..81bcb934748d 100644
> >>>> --- a/MAINTAINERS
> >>>> +++ b/MAINTAINERS
> >>>> @@ -3841,6 +3841,7 @@ F: drivers/hwmon/asus-ec-sensors.c
> >>>>  ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS
> >>>>  M: Corentin Chary <corentin.chary@gmail.com>
> >>>>  M: Luke D. Jones <luke@ljones.dev>
> >>>> +M: Denis Benato <benato.denis96@gmail.com>
> >>>>  L: platform-driver-x86@vger.kernel.org
> >>>>  S: Maintained
> >>>>  W: https://asus-linux.org/
> > 
> > Hi all,
> > 
> > Unrelated to the patch itself, I'm more wondering if Corentin Chary 
> > <corentin.chary@gmail.com> is still around as I don't recall ever hearing 
> > anything from that address in any context. The latest email from that 
> > address lore.kernel.org could find is from 2017.
> > 
> > Maybe we should remove that address from the maintainers list?
> 
> I’d been wondering if that should be done. Though never was sure of the 
> process or if that was okay.

Hans, any thoughts?

My opinion is we remove that address, there's little point in keeping 
people around when they've stopped communicating years ago. For this 
driver it's easy, but that address also appears for samsung-laptop.c
which doesn't have another maintainer.


-- 
 i.

Re: [PATCH] MAINTAINERS: add Denis Benato as maintainer for asus notebooks

Posted by Andy Shevchenko 3 months, 3 weeks ago

On Mon, Oct 06, 2025 at 12:12:12PM +0300, Ilpo Järvinen wrote:
> On Mon, 6 Oct 2025, luke@ljones.dev wrote:

...

> My opinion is we remove that address, there's little point in keeping 
> people around when they've stopped communicating years ago. For this 
> driver it's easy, but that address also appears for samsung-laptop.c
> which doesn't have another maintainer.

The latter case should also switch to Orphaned or get removed the whole
MAINTAINERS record for it.

But before doing that have you checked `git log --grep'$First $Last'` (i.e. w/o
email) to see if there is any new activity? Also any other emails available
from googling / duckduckgo'ing?

-- 
With Best Regards,
Andy Shevchenko