Add a driver for the regulators found on all types of the MediaTek
MT6316 SPMI PMIC, fully controlled by SPMI interface and featuring
four step down DCDC (buck) converters.
In particular, this includes support for:
- MT6316(BP/VP): 2+2 Phase (Phase 1: buck1+2, Phase 2: buck3+4)
- MT6316(CP/HP/KP): 3+1 Phase (Phase 1: buck1+2+4, Phase 2: buck3)
- MT6316(DP/TP): 4+0 Phase (Single phase, buck1+2+3+4)
Please note that the set/clear registers for the enable bits are
not documented in the datasheet version that I used as reference,
but those are used in the downstream driver and I verified that
are actually working as expected.
Besides, it's also worth clearly mentioning that the MT6316 PMICs
voltage selector register uses a weird 9-bits Big Endian format,
for which a driver-private helper is provided.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/regulator/Kconfig | 10 +
drivers/regulator/Makefile | 1 +
drivers/regulator/mt6316-regulator.c | 345 +++++++++++++++++++++++++++
3 files changed, 356 insertions(+)
create mode 100644 drivers/regulator/mt6316-regulator.c
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index e252bb11ae66..0ba2b7216d37 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -873,6 +873,16 @@ config REGULATOR_MT6315
This driver supports the control of different power rails of device
through regulator interface.
+config REGULATOR_MT6316
+ tristate "MT6316 SPMI PMIC regulator driver"
+ depends on SPMI || COMPILE_TEST
+ select REGMAP_SPMI
+ help
+ Say Y here to enable support for 2+2, 3+1 and 4 phase regulators
+ found in the MediaTek MT6316 BP, CP, DP, HP, VP and TP SPMI PMICs.
+ This driver supports the control of different power rails of device
+ through regulator interface.
+
config REGULATOR_MT6323
tristate "MediaTek MT6323 PMIC"
depends on MFD_MT6397
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 76b02d12b758..87c91e71eb22 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -104,6 +104,7 @@ obj-$(CONFIG_REGULATOR_MP886X) += mp886x.o
obj-$(CONFIG_REGULATOR_MPQ7920) += mpq7920.o
obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o
obj-$(CONFIG_REGULATOR_MT6315) += mt6315-regulator.o
+obj-$(CONFIG_REGULATOR_MT6315) += mt6316-regulator.o
obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o
obj-$(CONFIG_REGULATOR_MT6331) += mt6331-regulator.o
obj-$(CONFIG_REGULATOR_MT6332) += mt6332-regulator.o
diff --git a/drivers/regulator/mt6316-regulator.c b/drivers/regulator/mt6316-regulator.c
new file mode 100644
index 000000000000..952852bbe923
--- /dev/null
+++ b/drivers/regulator/mt6316-regulator.c
@@ -0,0 +1,345 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (c) 2024 MediaTek Inc.
+// Copyright (c) 2025 Collabora Ltd
+// AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+#include <linux/spmi.h>
+
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>
+#include <linux/regulator/of_regulator.h>
+
+#define MT6316_BUCK_MODE_AUTO 0
+#define MT6316_BUCK_MODE_FORCE_PWM 1
+#define MT6316_BUCK_MODE_LP 2
+
+#define MT6316_CHIP_ID 0x20b
+#define MT6316_BUCK_TOP_CON0 0x1440
+#define EN_SET_OFFSET 0x1
+#define EN_CLR_OFFSET 0x2
+
+#define MT6316_BUCK_TOP_CON1 0x1443
+
+#define MT6316_BUCK_TOP_ELR0 0x1448
+#define MT6316_BUCK_TOP_ELR2 0x144a
+#define MT6316_BUCK_TOP_ELR4 0x144c
+#define MT6316_BUCK_TOP_ELR6 0x144e
+#define MT6316_VSEL_MASK GENMASK(8, 0)
+
+#define MT6316_VBUCK1_DBG 0x14a8
+#define MT6316_VBUCK2_DBG 0x1528
+#define MT6316_VBUCK3_DBG 0x15a8
+#define MT6316_VBUCK4_DBG 0x1628
+#define MT6316_BUCK_QI BIT(0)
+
+#define MT6316_BUCK_TOP_4PHASE_TOP_ANA_CON0 0x1688
+#define MT6316_BUCK_TOP_4PHASE_TOP_ELR_0 0x1690
+
+enum mt6316_type {
+ MT6316_TYPE_2PHASE,
+ MT6316_TYPE_3PHASE,
+ MT6316_TYPE_4PHASE
+};
+
+/**
+ * struct mt6316_regulator_info - MT6316 regulators information
+ * @desc: Regulator description structure
+ * @debug_reg: Debug register for regulator status
+ * @lp_mode_reg: Low Power mode register (normal/idle)
+ * @lp_mode_mask: Low Power mode regulator mask
+ * @modeset_reg: AUTO/PWM mode register
+ * @modeset_mask: AUTO/PWM regulator mask
+ */
+struct mt6316_regulator_info {
+ struct regulator_desc desc;
+ u16 debug_reg;
+ u16 lp_mode_reg;
+ u16 lp_mode_mask;
+ u16 modeset_reg;
+ u16 modeset_mask;
+};
+
+#define MT6316_BUCK(match, vreg_id, min, max, step, vs_reg) \
+{ \
+ .desc = { \
+ .name = match, \
+ .of_match = of_match_ptr(match), \
+ .ops = &mt6316_vreg_setclr_ops, \
+ .type = REGULATOR_VOLTAGE, \
+ .owner = THIS_MODULE, \
+ .n_voltages = (max - min) / step + 1, \
+ .min_uV = min, \
+ .uV_step = step, \
+ .enable_reg = MT6316_BUCK_TOP_CON0, \
+ .enable_mask = BIT(vreg_id - 1), \
+ .vsel_reg = vs_reg, \
+ .vsel_mask = MT6316_VSEL_MASK, \
+ .of_map_mode = mt6316_map_mode, \
+ }, \
+ .lp_mode_reg = MT6316_BUCK_TOP_CON1, \
+ .lp_mode_mask = BIT(vreg_id - 1), \
+ .modeset_reg = MT6316_BUCK_TOP_4PHASE_TOP_ANA_CON0, \
+ .modeset_mask = BIT(vreg_id - 1), \
+ .debug_reg = MT6316_VBUCK##vreg_id##_DBG, \
+}
+
+/* Values in some MT6316 registers are big endian, 9 bits long... */
+static inline u16 mt6316_be9_to_cpu(u16 val)
+{
+ return ((val >> 8) & BIT(0)) | ((val & GENMASK(7, 0)) << 1);
+}
+
+static inline u16 mt6316_cpu_to_be9(u16 val)
+{
+ return ((val & BIT(0)) << 8) | (val >> 1);
+}
+
+static unsigned int mt6316_map_mode(u32 mode)
+{
+ switch (mode) {
+ case MT6316_BUCK_MODE_AUTO:
+ return REGULATOR_MODE_NORMAL;
+ case MT6316_BUCK_MODE_FORCE_PWM:
+ return REGULATOR_MODE_FAST;
+ case MT6316_BUCK_MODE_LP:
+ return REGULATOR_MODE_IDLE;
+ default:
+ return REGULATOR_MODE_INVALID;
+ }
+}
+
+static int mt6316_vreg_enable_setclr(struct regulator_dev *rdev)
+{
+ return regmap_write(rdev->regmap, rdev->desc->enable_reg + EN_SET_OFFSET,
+ rdev->desc->enable_mask);
+}
+
+static int mt6316_vreg_disable_setclr(struct regulator_dev *rdev)
+{
+ return regmap_write(rdev->regmap, rdev->desc->enable_reg + EN_CLR_OFFSET,
+ rdev->desc->enable_mask);
+}
+
+static int mt6316_regulator_set_voltage_sel(struct regulator_dev *rdev, unsigned int selector)
+{
+ u16 val = mt6316_cpu_to_be9(selector);
+
+ return regmap_bulk_write(rdev->regmap, rdev->desc->vsel_reg, &val, sizeof(val));
+}
+
+static int mt6316_regulator_get_voltage_sel(struct regulator_dev *rdev)
+{
+ u16 val;
+ int ret;
+
+ ret = regmap_bulk_read(rdev->regmap, rdev->desc->vsel_reg, &val, sizeof(val));
+ if (ret)
+ return ret;
+
+ return mt6316_be9_to_cpu(val & rdev->desc->vsel_mask);
+}
+
+static int mt6316_regulator_get_status(struct regulator_dev *rdev)
+{
+ struct mt6316_regulator_info *info = rdev_get_drvdata(rdev);
+ u32 val;
+ int ret;
+
+ ret = regmap_read(rdev->regmap, info->debug_reg, &val);
+ if (ret)
+ return ret;
+
+ return val & MT6316_BUCK_QI ? REGULATOR_STATUS_ON : REGULATOR_STATUS_OFF;
+}
+
+static unsigned int mt6316_regulator_get_mode(struct regulator_dev *rdev)
+{
+ struct mt6316_regulator_info *info = rdev_get_drvdata(rdev);
+ unsigned int val;
+ int ret;
+
+ ret = regmap_read(rdev->regmap, info->modeset_reg, &val);
+ if (ret) {
+ dev_err(&rdev->dev, "Failed to get mode: %d\n", ret);
+ return ret;
+ }
+
+ if ((val & info->modeset_mask) == info->modeset_mask)
+ return REGULATOR_MODE_FAST;
+
+ ret = regmap_read(rdev->regmap, info->lp_mode_reg, &val);
+ val &= info->lp_mode_mask;
+ if (ret) {
+ dev_err(&rdev->dev, "Failed to get lp mode: %d\n", ret);
+ return ret;
+ }
+
+ return val ? REGULATOR_MODE_IDLE : REGULATOR_MODE_NORMAL;
+}
+
+static int mt6316_regulator_set_mode(struct regulator_dev *rdev,
+ unsigned int mode)
+{
+ struct mt6316_regulator_info *info = rdev_get_drvdata(rdev);
+ struct regmap *regmap = rdev->regmap;
+ int cur_mode, ret;
+
+ switch (mode) {
+ case REGULATOR_MODE_FAST:
+ ret = regmap_set_bits(regmap, info->modeset_reg, info->modeset_mask);
+ break;
+ case REGULATOR_MODE_NORMAL:
+ cur_mode = mt6316_regulator_get_mode(rdev);
+ if (cur_mode < 0) {
+ ret = cur_mode;
+ break;
+ }
+
+ if (cur_mode == REGULATOR_MODE_FAST) {
+ ret = regmap_clear_bits(regmap, info->modeset_reg, info->modeset_mask);
+ break;
+ } else if (cur_mode == REGULATOR_MODE_IDLE) {
+ ret = regmap_clear_bits(regmap, info->lp_mode_reg, info->lp_mode_mask);
+ if (ret == 0)
+ usleep_range(100, 200);
+ } else {
+ ret = 0;
+ }
+ break;
+ case REGULATOR_MODE_IDLE:
+ ret = regmap_set_bits(regmap, info->lp_mode_reg, info->lp_mode_mask);
+ break;
+ default:
+ ret = -EINVAL;
+ }
+
+ if (ret) {
+ dev_err(&rdev->dev, "Failed to set mode %u: %d\n", mode, ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static const struct regulator_ops mt6316_vreg_setclr_ops = {
+ .list_voltage = regulator_list_voltage_linear,
+ .map_voltage = regulator_map_voltage_linear,
+ .set_voltage_sel = mt6316_regulator_set_voltage_sel,
+ .get_voltage_sel = mt6316_regulator_get_voltage_sel,
+ .set_voltage_time_sel = regulator_set_voltage_time_sel,
+ .enable = mt6316_vreg_enable_setclr,
+ .disable = mt6316_vreg_disable_setclr,
+ .is_enabled = regulator_is_enabled_regmap,
+ .get_status = mt6316_regulator_get_status,
+ .set_mode = mt6316_regulator_set_mode,
+ .get_mode = mt6316_regulator_get_mode,
+};
+
+/* MT6316BP/VP - 2+2 phase buck */
+static struct mt6316_regulator_info mt6316bv_regulators[] = {
+ MT6316_BUCK("vbuck12", 1, 0, 1277500, 2500, MT6316_BUCK_TOP_ELR0),
+ MT6316_BUCK("vbuck34", 3, 0, 1277500, 2500, MT6316_BUCK_TOP_ELR4),
+};
+
+/* MT6316CP/HP/KP - 3+1 phase buck */
+static struct mt6316_regulator_info mt6316chk_regulators[] = {
+ MT6316_BUCK("vbuck124", 1, 0, 1277500, 2500, MT6316_BUCK_TOP_ELR0),
+ MT6316_BUCK("vbuck3", 3, 0, 1277500, 2500, MT6316_BUCK_TOP_ELR4),
+};
+
+/* MT6316DP/TP - 4 phase buck */
+static struct mt6316_regulator_info mt6316dt_regulators[] = {
+ MT6316_BUCK("vbuck1234", 1, 0, 1277500, 2500, MT6316_BUCK_TOP_ELR0),
+};
+
+static const struct regmap_config mt6316_spmi_regmap_config = {
+ .reg_bits = 16,
+ .val_bits = 8,
+ .max_register = 0x1700,
+ .fast_io = true,
+};
+
+static int mt6316_regulator_probe(struct spmi_device *sdev)
+{
+ struct regulator_config config = {};
+ struct mt6316_regulator_info *info;
+ struct regulator_dev *rdev;
+ enum mt6316_type type;
+ int num_vregs, ret;
+ unsigned int i;
+ u32 chip_id;
+
+ config.regmap = devm_regmap_init_spmi_ext(sdev, &mt6316_spmi_regmap_config);
+ if (IS_ERR(config.regmap))
+ return PTR_ERR(config.regmap);
+
+ /*
+ * The first read is expected to fail: this PMIC needs to be woken up
+ * and that can be done with any activity over the SPMI bus.
+ */
+ regmap_read(config.regmap, MT6316_CHIP_ID, &chip_id);
+
+ /* The second read, instead, shall not fail! */
+ ret = regmap_read(config.regmap, MT6316_CHIP_ID, &chip_id);
+ if (ret) {
+ dev_err(&sdev->dev, "Cannot read Chip ID!\n");
+ return ret;
+ }
+ dev_dbg(&sdev->dev, "Chip ID: 0x%x\n", chip_id);
+
+ config.dev = &sdev->dev;
+
+ type = (uintptr_t)device_get_match_data(&sdev->dev);
+ switch (type) {
+ case MT6316_TYPE_2PHASE:
+ info = mt6316bv_regulators;
+ num_vregs = ARRAY_SIZE(mt6316bv_regulators);
+ break;
+ case MT6316_TYPE_3PHASE:
+ info = mt6316chk_regulators;
+ num_vregs = ARRAY_SIZE(mt6316chk_regulators);
+ break;
+ case MT6316_TYPE_4PHASE:
+ info = mt6316dt_regulators;
+ num_vregs = ARRAY_SIZE(mt6316dt_regulators);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ for (i = 0; i < num_vregs; i++) {
+ config.driver_data = &info[i];
+
+ rdev = devm_regulator_register(&sdev->dev, &info[i].desc, &config);
+ if (IS_ERR(rdev))
+ return dev_err_probe(&sdev->dev, PTR_ERR(rdev),
+ "failed to register %s\n", info[i].desc.name);
+ }
+
+ return 0;
+}
+
+static const struct of_device_id mt6316_regulator_match[] = {
+ { .compatible = "mediatek,mt6316b-regulator", .data = (void *)MT6316_TYPE_2PHASE },
+ { .compatible = "mediatek,mt6316c-regulator", .data = (void *)MT6316_TYPE_3PHASE },
+ { .compatible = "mediatek,mt6316d-regulator", .data = (void *)MT6316_TYPE_4PHASE },
+ { /* sentinel */ }
+};
+
+static struct spmi_driver mt6316_regulator_driver = {
+ .driver = {
+ .name = "mt6316-regulator",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
+ .of_match_table = mt6316_regulator_match,
+ },
+ .probe = mt6316_regulator_probe,
+};
+module_spmi_driver(mt6316_regulator_driver);
+
+MODULE_AUTHOR("AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>");
+MODULE_DESCRIPTION("Regulator Driver for MediaTek MT6316 PMIC");
+MODULE_LICENSE("GPL");
--
2.51.0Hi AngeloGioacchino,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-regulator/for-next]
[also build test ERROR on lee-mfd/for-mfd-next jic23-iio/togreg lee-leds/for-leds-next lee-mfd/for-mfd-fixes linus/master v6.17 next-20251010]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/dt-bindings-regulator-Document-MediaTek-MT6316-PMIC-Regulators/20251003-171606
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
patch link: https://lore.kernel.org/r/20251003091158.26748-3-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v8 2/9] regulator: Add support for MediaTek MT6316 SPMI PMIC Regulators
config: alpha-randconfig-r073-20251009 (https://download.01.org/0day-ci/archive/20251011/202510110504.A2lR6quW-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251011/202510110504.A2lR6quW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510110504.A2lR6quW-lkp@intel.com/
All errors (new ones prefixed by >>):
`xe_configfs_exit' referenced in section `.data.rel.ro' of drivers/gpu/drm/xe/xe_module.o: defined in discarded section `.exit.text' of drivers/gpu/drm/xe/xe_configfs.o
alpha-linux-ld: drivers/base/regmap/regmap-spmi.o: in function `regmap_spmi_base_read':
>> drivers/base/regmap/regmap-spmi.c:26:(.text+0x11c): undefined reference to `spmi_register_read'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:26:(.text+0x124): undefined reference to `spmi_register_read'
alpha-linux-ld: drivers/base/regmap/regmap-spmi.o: in function `regmap_spmi_base_gather_write':
>> drivers/base/regmap/regmap-spmi.c:46:(.text+0x1f0): undefined reference to `spmi_register_zero_write'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:46:(.text+0x1f4): undefined reference to `spmi_register_zero_write'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:56:(.text+0x220): undefined reference to `spmi_register_write'
alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:56:(.text+0x228): undefined reference to `spmi_register_write'
alpha-linux-ld: drivers/base/regmap/regmap-spmi.o: in function `regmap_spmi_ext_read':
>> drivers/base/regmap/regmap-spmi.c:124:(.text+0x3f0): undefined reference to `spmi_ext_register_read'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:124:(.text+0x404): undefined reference to `spmi_ext_register_read'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:136:(.text+0x444): undefined reference to `spmi_ext_register_readl'
alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:136:(.text+0x458): undefined reference to `spmi_ext_register_readl'
alpha-linux-ld: drivers/base/regmap/regmap-spmi.o: in function `regmap_spmi_ext_gather_write':
>> drivers/base/regmap/regmap-spmi.c:164:(.text+0x528): undefined reference to `spmi_ext_register_write'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:164:(.text+0x53c): undefined reference to `spmi_ext_register_write'
>> alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:176:(.text+0x57c): undefined reference to `spmi_ext_register_writel'
alpha-linux-ld: drivers/base/regmap/regmap-spmi.c:176:(.text+0x590): undefined reference to `spmi_ext_register_writel'
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for REGMAP_SPMI
Depends on [n]: SPMI [=n]
Selected by [y]:
- REGULATOR_MT6316 [=y] && REGULATOR [=y] && (SPMI [=n] || COMPILE_TEST [=y])
vim +26 drivers/base/regmap/regmap-spmi.c
a01779f89fc8a2 Josh Cartwright 2013-10-28 15
c9afbb05a9ffbe Josh Cartwright 2014-02-12 16 static int regmap_spmi_base_read(void *context,
a01779f89fc8a2 Josh Cartwright 2013-10-28 17 const void *reg, size_t reg_size,
a01779f89fc8a2 Josh Cartwright 2013-10-28 18 void *val, size_t val_size)
a01779f89fc8a2 Josh Cartwright 2013-10-28 19 {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 20 u8 addr = *(u8 *)reg;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 21 int err = 0;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 22
c9afbb05a9ffbe Josh Cartwright 2014-02-12 23 BUG_ON(reg_size != 1);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 24
c9afbb05a9ffbe Josh Cartwright 2014-02-12 25 while (val_size-- && !err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 @26 err = spmi_register_read(context, addr++, val++);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 27
c9afbb05a9ffbe Josh Cartwright 2014-02-12 28 return err;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 29 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 30
c9afbb05a9ffbe Josh Cartwright 2014-02-12 31 static int regmap_spmi_base_gather_write(void *context,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 32 const void *reg, size_t reg_size,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 33 const void *val, size_t val_size)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 34 {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 35 const u8 *data = val;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 36 u8 addr = *(u8 *)reg;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 37 int err = 0;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 38
c9afbb05a9ffbe Josh Cartwright 2014-02-12 39 BUG_ON(reg_size != 1);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 40
c9afbb05a9ffbe Josh Cartwright 2014-02-12 41 /*
c9afbb05a9ffbe Josh Cartwright 2014-02-12 42 * SPMI defines a more bandwidth-efficient 'Register 0 Write' sequence,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 43 * use it when possible.
c9afbb05a9ffbe Josh Cartwright 2014-02-12 44 */
c9afbb05a9ffbe Josh Cartwright 2014-02-12 45 if (addr == 0 && val_size) {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 @46 err = spmi_register_zero_write(context, *data);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 47 if (err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 48 goto err_out;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 49
c9afbb05a9ffbe Josh Cartwright 2014-02-12 50 data++;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 51 addr++;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 52 val_size--;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 53 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 54
c9afbb05a9ffbe Josh Cartwright 2014-02-12 55 while (val_size) {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 @56 err = spmi_register_write(context, addr, *data);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 57 if (err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 58 goto err_out;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 59
c9afbb05a9ffbe Josh Cartwright 2014-02-12 60 data++;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 61 addr++;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 62 val_size--;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 63 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 64
c9afbb05a9ffbe Josh Cartwright 2014-02-12 65 err_out:
c9afbb05a9ffbe Josh Cartwright 2014-02-12 66 return err;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 67 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 68
c9afbb05a9ffbe Josh Cartwright 2014-02-12 69 static int regmap_spmi_base_write(void *context, const void *data,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 70 size_t count)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 71 {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 72 BUG_ON(count < 1);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 73 return regmap_spmi_base_gather_write(context, data, 1, data + 1,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 74 count - 1);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 75 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 76
9c2e5cb38da220 Julia Lawall 2017-08-11 77 static const struct regmap_bus regmap_spmi_base = {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 78 .read = regmap_spmi_base_read,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 79 .write = regmap_spmi_base_write,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 80 .gather_write = regmap_spmi_base_gather_write,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 81 .reg_format_endian_default = REGMAP_ENDIAN_NATIVE,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 82 .val_format_endian_default = REGMAP_ENDIAN_NATIVE,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 83 };
c9afbb05a9ffbe Josh Cartwright 2014-02-12 84
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 85 struct regmap *__regmap_init_spmi_base(struct spmi_device *sdev,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 86 const struct regmap_config *config,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 87 struct lock_class_key *lock_key,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 88 const char *lock_name)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 89 {
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 90 return __regmap_init(&sdev->dev, ®map_spmi_base, sdev, config,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 91 lock_key, lock_name);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 92 }
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 93 EXPORT_SYMBOL_GPL(__regmap_init_spmi_base);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 94
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 95 struct regmap *__devm_regmap_init_spmi_base(struct spmi_device *sdev,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 96 const struct regmap_config *config,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 97 struct lock_class_key *lock_key,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 98 const char *lock_name)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 99 {
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 100 return __devm_regmap_init(&sdev->dev, ®map_spmi_base, sdev, config,
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 101 lock_key, lock_name);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 102 }
3cfe7a74d42b7e Nicolas Boichat 2015-07-08 103 EXPORT_SYMBOL_GPL(__devm_regmap_init_spmi_base);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 104
c9afbb05a9ffbe Josh Cartwright 2014-02-12 105 static int regmap_spmi_ext_read(void *context,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 106 const void *reg, size_t reg_size,
c9afbb05a9ffbe Josh Cartwright 2014-02-12 107 void *val, size_t val_size)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 108 {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 109 int err = 0;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 110 size_t len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 111 u16 addr;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 112
a01779f89fc8a2 Josh Cartwright 2013-10-28 113 BUG_ON(reg_size != 2);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 114
c9afbb05a9ffbe Josh Cartwright 2014-02-12 115 addr = *(u16 *)reg;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 116
c9afbb05a9ffbe Josh Cartwright 2014-02-12 117 /*
c9afbb05a9ffbe Josh Cartwright 2014-02-12 118 * Split accesses into two to take advantage of the more
c9afbb05a9ffbe Josh Cartwright 2014-02-12 119 * bandwidth-efficient 'Extended Register Read' command when possible
c9afbb05a9ffbe Josh Cartwright 2014-02-12 120 */
c9afbb05a9ffbe Josh Cartwright 2014-02-12 121 while (addr <= 0xFF && val_size) {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 122 len = min_t(size_t, val_size, 16);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 123
c9afbb05a9ffbe Josh Cartwright 2014-02-12 @124 err = spmi_ext_register_read(context, addr, val, len);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 125 if (err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 126 goto err_out;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 127
c9afbb05a9ffbe Josh Cartwright 2014-02-12 128 addr += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 129 val += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 130 val_size -= len;
a01779f89fc8a2 Josh Cartwright 2013-10-28 131 }
a01779f89fc8a2 Josh Cartwright 2013-10-28 132
c9afbb05a9ffbe Josh Cartwright 2014-02-12 133 while (val_size) {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 134 len = min_t(size_t, val_size, 8);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 135
dec8e8f6e6504a Jack Pham 2016-04-14 @136 err = spmi_ext_register_readl(context, addr, val, len);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 137 if (err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 138 goto err_out;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 139
c9afbb05a9ffbe Josh Cartwright 2014-02-12 140 addr += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 141 val += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 142 val_size -= len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 143 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 144
c9afbb05a9ffbe Josh Cartwright 2014-02-12 145 err_out:
c9afbb05a9ffbe Josh Cartwright 2014-02-12 146 return err;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 147 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 148
c9afbb05a9ffbe Josh Cartwright 2014-02-12 149 static int regmap_spmi_ext_gather_write(void *context,
a01779f89fc8a2 Josh Cartwright 2013-10-28 150 const void *reg, size_t reg_size,
a01779f89fc8a2 Josh Cartwright 2013-10-28 151 const void *val, size_t val_size)
a01779f89fc8a2 Josh Cartwright 2013-10-28 152 {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 153 int err = 0;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 154 size_t len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 155 u16 addr;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 156
a01779f89fc8a2 Josh Cartwright 2013-10-28 157 BUG_ON(reg_size != 2);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 158
c9afbb05a9ffbe Josh Cartwright 2014-02-12 159 addr = *(u16 *)reg;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 160
c9afbb05a9ffbe Josh Cartwright 2014-02-12 161 while (addr <= 0xFF && val_size) {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 162 len = min_t(size_t, val_size, 16);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 163
c9afbb05a9ffbe Josh Cartwright 2014-02-12 @164 err = spmi_ext_register_write(context, addr, val, len);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 165 if (err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 166 goto err_out;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 167
c9afbb05a9ffbe Josh Cartwright 2014-02-12 168 addr += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 169 val += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 170 val_size -= len;
a01779f89fc8a2 Josh Cartwright 2013-10-28 171 }
a01779f89fc8a2 Josh Cartwright 2013-10-28 172
c9afbb05a9ffbe Josh Cartwright 2014-02-12 173 while (val_size) {
c9afbb05a9ffbe Josh Cartwright 2014-02-12 174 len = min_t(size_t, val_size, 8);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 175
c9afbb05a9ffbe Josh Cartwright 2014-02-12 @176 err = spmi_ext_register_writel(context, addr, val, len);
c9afbb05a9ffbe Josh Cartwright 2014-02-12 177 if (err)
c9afbb05a9ffbe Josh Cartwright 2014-02-12 178 goto err_out;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 179
c9afbb05a9ffbe Josh Cartwright 2014-02-12 180 addr += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 181 val += len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 182 val_size -= len;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 183 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 184
c9afbb05a9ffbe Josh Cartwright 2014-02-12 185 err_out:
c9afbb05a9ffbe Josh Cartwright 2014-02-12 186 return err;
c9afbb05a9ffbe Josh Cartwright 2014-02-12 187 }
c9afbb05a9ffbe Josh Cartwright 2014-02-12 188
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
© 2016 - 2026 Red Hat, Inc.