[PATCH v3 4/8] nvmet: Expose nvmet_stop_keep_alive_timer publically

alistair23@gmail.com posted 8 patches 4 months, 1 week ago
There is a newer version of this series
[PATCH v3 4/8] nvmet: Expose nvmet_stop_keep_alive_timer publically
Posted by alistair23@gmail.com 4 months, 1 week ago
From: Alistair Francis <alistair.francis@wdc.com>

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 drivers/nvme/target/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index 0dd7bd99afa3..bed1c6ebe83a 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -430,6 +430,7 @@ void nvmet_stop_keep_alive_timer(struct nvmet_ctrl *ctrl)
 
 	cancel_delayed_work_sync(&ctrl->ka_work);
 }
+EXPORT_SYMBOL_GPL(nvmet_stop_keep_alive_timer);
 
 u16 nvmet_req_find_ns(struct nvmet_req *req)
 {
-- 
2.51.0
Re: [PATCH v3 4/8] nvmet: Expose nvmet_stop_keep_alive_timer publically
Posted by Hannes Reinecke 4 months ago
On 10/3/25 06:31, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>   drivers/nvme/target/core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index 0dd7bd99afa3..bed1c6ebe83a 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -430,6 +430,7 @@ void nvmet_stop_keep_alive_timer(struct nvmet_ctrl *ctrl)
>   
>   	cancel_delayed_work_sync(&ctrl->ka_work);
>   }
> +EXPORT_SYMBOL_GPL(nvmet_stop_keep_alive_timer);
>   
>   u16 nvmet_req_find_ns(struct nvmet_req *req)
>   {
Please reshuffle the patchset to keep the host and target side patches
together. And explain why this one is needed.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Re: [PATCH v3 4/8] nvmet: Expose nvmet_stop_keep_alive_timer publically
Posted by Christoph Hellwig 4 months, 1 week ago
On Fri, Oct 03, 2025 at 02:31:35PM +1000, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Please explain why making it available is a good idea.  Because it
feels a bit sketchy as-is.