[PATCH 1/4] x86/mm: delete disabled debug code

Brendan Jackman posted 4 patches 2 months, 2 weeks ago
[PATCH 1/4] x86/mm: delete disabled debug code
Posted by Brendan Jackman 2 months, 2 weeks ago
This code doesn't run. Since 2008 the kernel has gained more flexible
logging and tracing capabilities; presumably if anyone wanted to take
advantage of this log message they would have got rid of the
"if (0)" so they could use these capabilities.

Since they haven't, just delete it.

Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
 arch/x86/mm/init_64.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index b9426fce5f3e3f17df57df7b12338f3c0ef4c288..9e45b371a6234b41bd7177b81b5d432341ae7214 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -504,9 +504,6 @@ phys_pte_init(pte_t *pte_page, unsigned long paddr, unsigned long paddr_end,
 			continue;
 		}
 
-		if (0)
-			pr_info("   pte=%p addr=%lx pte=%016lx\n", pte, paddr,
-				pfn_pte(paddr >> PAGE_SHIFT, PAGE_KERNEL).pte);
 		pages++;
 		set_pte_init(pte, pfn_pte(paddr >> PAGE_SHIFT, prot), init);
 		paddr_last = (paddr & PAGE_MASK) + PAGE_SIZE;

-- 
2.50.1
[tip: x86/cleanups] x86/mm: Delete disabled debug code
Posted by tip-bot2 for Brendan Jackman 2 weeks, 6 days ago
The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     3d1f1088455d9a9bce51f0c1e6a81f518a5cb468
Gitweb:        https://git.kernel.org/tip/3d1f1088455d9a9bce51f0c1e6a81f518a5cb468
Author:        Brendan Jackman <jackmanb@google.com>
AuthorDate:    Fri, 03 Oct 2025 16:56:41 
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Thu, 27 Nov 2025 14:32:16 +01:00

x86/mm: Delete disabled debug code

This code doesn't run. Since 2008:

  4f9c11dd49fb ("x86, 64-bit: adjust mapping of physical pagetables to work with Xen")

the kernel has gained more flexible logging and tracing capabilities;
presumably if anyone wanted to take advantage of this log message they would
have got rid of the "if (0)" so they could use these capabilities.

Since they haven't, just delete it.

Signed-off-by: Brendan Jackman <jackmanb@google.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20251003-x86-init-cleanup-v1-1-f2b7994c2ad6@google.com
---
 arch/x86/mm/init_64.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 0e4270e..1044aaf 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -504,9 +504,6 @@ phys_pte_init(pte_t *pte_page, unsigned long paddr, unsigned long paddr_end,
 			continue;
 		}
 
-		if (0)
-			pr_info("   pte=%p addr=%lx pte=%016lx\n", pte, paddr,
-				pfn_pte(paddr >> PAGE_SHIFT, PAGE_KERNEL).pte);
 		pages++;
 		set_pte_init(pte, pfn_pte(paddr >> PAGE_SHIFT, prot), init);
 		paddr_last = (paddr & PAGE_MASK) + PAGE_SIZE;