[v2] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)

[PATCH net v2 0/6] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)

Posted by Jacob Keller 2 months, 2 weeks ago

For idpf:
Milena fixes a memory leak in the idpf reset logic when the driver resets
with an outstanding Tx timestamp.

For ixgbe and ixgbevf:
Jedrzej fixes an issue with reporting link speed on E610 VFs.

Jedrzej also fixes the VF mailbox API incompatibilities caused by the
confusion with API v1.4, v1.5, and v1.6. The v1.4 API introduced IPSEC
offload, but this was only supported on Linux hosts. The v1.5 API
introduced a new mailbox API which is necessary to resolve issues on ESX
hosts. The v1.6 API introduced a new link management API for E610. Jedrzej
introduces a new v1.7 API with a feature negotiation which enables properly
checking if features such as IPSEC or the ESX mailbox APIs are supported.
This resolves issues with compatibility on different hosts, and aligns the
API across hosts instead of having Linux require custom mailbox API
versions for IPSEC offload.

Koichiro fixes a KASAN use-after-free bug in ixgbe_remove().

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Changes in v2:
- Drop Emil's idpf_vport_open race fix for now.
- Add my signature.
- Link to v1: https://lore.kernel.org/r/20251001-jk-iwl-net-2025-10-01-v1-0-49fa99e86600@intel.com

---
Jedrzej Jagielski (4):
      ixgbevf: fix getting link speed data for E610 devices
      ixgbe: handle IXGBE_VF_GET_PF_LINK_STATE mailbox operation
      ixgbevf: fix mailbox API compatibility by negotiating supported features
      ixgbe: handle IXGBE_VF_FEATURES_NEGOTIATE mbox cmd

Koichiro Den (1):
      ixgbe: fix too early devlink_free() in ixgbe_remove()

Milena Olech (1):
      idpf: cleanup remaining SKBs in PTP flows

 drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h       |  15 ++
 drivers/net/ethernet/intel/ixgbevf/defines.h       |   1 +
 drivers/net/ethernet/intel/ixgbevf/ixgbevf.h       |   7 +
 drivers/net/ethernet/intel/ixgbevf/mbx.h           |   8 +
 drivers/net/ethernet/intel/ixgbevf/vf.h            |   1 +
 drivers/net/ethernet/intel/idpf/idpf_ptp.c         |   3 +
 .../net/ethernet/intel/idpf/idpf_virtchnl_ptp.c    |   1 +
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |   3 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c     |  79 +++++++++
 drivers/net/ethernet/intel/ixgbevf/ipsec.c         |  10 ++
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c  |  34 +++-
 drivers/net/ethernet/intel/ixgbevf/vf.c            | 182 +++++++++++++++++----
 12 files changed, 310 insertions(+), 34 deletions(-)
---
base-commit: daa26ea63c6f848159821cd9b3cbe47cddbb0a1c
change-id: 20251001-jk-iwl-net-2025-10-01-92cd2a626ff7

Best regards,
--  
Jacob Keller <jacob.e.keller@intel.com>

Re: [PATCH net v2 0/6] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)

Posted by Simon Horman 2 months, 2 weeks ago

On Fri, Oct 03, 2025 at 06:09:43PM -0700, Jacob Keller wrote:
> For idpf:
> Milena fixes a memory leak in the idpf reset logic when the driver resets
> with an outstanding Tx timestamp.
> 
> For ixgbe and ixgbevf:
> Jedrzej fixes an issue with reporting link speed on E610 VFs.
> 
> Jedrzej also fixes the VF mailbox API incompatibilities caused by the
> confusion with API v1.4, v1.5, and v1.6. The v1.4 API introduced IPSEC
> offload, but this was only supported on Linux hosts. The v1.5 API
> introduced a new mailbox API which is necessary to resolve issues on ESX
> hosts. The v1.6 API introduced a new link management API for E610. Jedrzej
> introduces a new v1.7 API with a feature negotiation which enables properly
> checking if features such as IPSEC or the ESX mailbox APIs are supported.
> This resolves issues with compatibility on different hosts, and aligns the
> API across hosts instead of having Linux require custom mailbox API
> versions for IPSEC offload.
> 
> Koichiro fixes a KASAN use-after-free bug in ixgbe_remove().
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> Changes in v2:
> - Drop Emil's idpf_vport_open race fix for now.
> - Add my signature.
> - Link to v1: https://lore.kernel.org/r/20251001-jk-iwl-net-2025-10-01-v1-0-49fa99e86600@intel.com

Hi Jake,

Maybe I'm missing something simple here.

But this series doesn't seem to apply to net due to the presence of
commit 7a5a03869801 ("idpf: add HW timestamping statistics")

Re: [PATCH net v2 0/6] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)

Posted by Jacob Keller 2 months, 1 week ago


On 10/4/2025 9:56 AM, Simon Horman wrote:
> On Fri, Oct 03, 2025 at 06:09:43PM -0700, Jacob Keller wrote:
>> For idpf:
>> Milena fixes a memory leak in the idpf reset logic when the driver resets
>> with an outstanding Tx timestamp.
>>
>> For ixgbe and ixgbevf:
>> Jedrzej fixes an issue with reporting link speed on E610 VFs.
>>
>> Jedrzej also fixes the VF mailbox API incompatibilities caused by the
>> confusion with API v1.4, v1.5, and v1.6. The v1.4 API introduced IPSEC
>> offload, but this was only supported on Linux hosts. The v1.5 API
>> introduced a new mailbox API which is necessary to resolve issues on ESX
>> hosts. The v1.6 API introduced a new link management API for E610. Jedrzej
>> introduces a new v1.7 API with a feature negotiation which enables properly
>> checking if features such as IPSEC or the ESX mailbox APIs are supported.
>> This resolves issues with compatibility on different hosts, and aligns the
>> API across hosts instead of having Linux require custom mailbox API
>> versions for IPSEC offload.
>>
>> Koichiro fixes a KASAN use-after-free bug in ixgbe_remove().
>>
>> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
>> ---
>> Changes in v2:
>> - Drop Emil's idpf_vport_open race fix for now.
>> - Add my signature.
>> - Link to v1: https://lore.kernel.org/r/20251001-jk-iwl-net-2025-10-01-v1-0-49fa99e86600@intel.com
> 
> Hi Jake,
> 
> Maybe I'm missing something simple here.
> 
> But this series doesn't seem to apply to net due to the presence of
> commit 7a5a03869801 ("idpf: add HW timestamping statistics")

Hm. I based this on net when I created it, but I guess I was too early,
probably before a tree merge happened.

Will fix.

Thanks,
Jake