s390/uv: Fix the comment of the uv_find_secret() function

[PATCH] s390/uv: Fix the comment of the uv_find_secret() function

Posted by Thomas Huth 4 months, 1 week ago

From: Thomas Huth <thuth@redhat.com>

The uv_get_secret_metadata() function has been removed some
months ago, so we should not mention it in the comment anymore.

Fixes: a42831f0b74dc ("s390/uv: Remove uv_get_secret_metadata function")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 arch/s390/kernel/uv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index 47f574cd1728a..324cd549807a5 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -866,8 +866,8 @@ static int find_secret_in_page(const u8 secret_id[UV_SECRET_ID_LEN],
 	return -ENOENT;
 }
 
-/*
- * Do the actual search for `uv_get_secret_metadata`.
+/**
+ * uv_find_secret() - search secret metadata for a given secret id.
  * @secret_id: search pattern.
  * @list: ephemeral buffer space
  * @secret: output data, containing the secret's metadata.
-- 
2.51.0

Re: [PATCH] s390/uv: Fix the comment of the uv_find_secret() function

Posted by Janosch Frank 4 months ago

On 10/2/25 5:54 PM, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The uv_get_secret_metadata() function has been removed some
> months ago, so we should not mention it in the comment anymore.
> 
> Fixes: a42831f0b74dc ("s390/uv: Remove uv_get_secret_metadata function")
> Signed-off-by: Thomas Huth <thuth@redhat.com>

FYI:
The 390 team has picked this up and will move it through their repository.

Re: [PATCH] s390/uv: Fix the comment of the uv_find_secret() function

Posted by Claudio Imbrenda 4 months, 1 week ago

On Thu,  2 Oct 2025 17:54:23 +0200
Thomas Huth <thuth@redhat.com> wrote:

> From: Thomas Huth <thuth@redhat.com>
> 
> The uv_get_secret_metadata() function has been removed some
> months ago, so we should not mention it in the comment anymore.
> 
> Fixes: a42831f0b74dc ("s390/uv: Remove uv_get_secret_metadata function")
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  arch/s390/kernel/uv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index 47f574cd1728a..324cd549807a5 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -866,8 +866,8 @@ static int find_secret_in_page(const u8 secret_id[UV_SECRET_ID_LEN],
>  	return -ENOENT;
>  }
>  
> -/*
> - * Do the actual search for `uv_get_secret_metadata`.
> +/**
> + * uv_find_secret() - search secret metadata for a given secret id.
>   * @secret_id: search pattern.
>   * @list: ephemeral buffer space
>   * @secret: output data, containing the secret's metadata.