rust_binder: remove warning about orphan mappings

[PATCH] rust_binder: remove warning about orphan mappings

Posted by Alice Ryhl 2 months, 2 weeks ago

This condition occurs if a thread dies while processing a transaction.
We should not print anything in this scenario.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
 drivers/android/binder/process.rs | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
--- a/drivers/android/binder/process.rs
+++ b/drivers/android/binder/process.rs
@@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
                 .alloc
                 .take_for_each(|offset, size, debug_id, odata| {
                     let ptr = offset + address;
-                    pr_warn!(
-                        "{}: removing orphan mapping {offset}:{size}\n",
-                        self.pid_in_current_ns()
-                    );
                     let mut alloc =
                         Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
                     if let Some(data) = odata {

---
base-commit: eafedbc7c050c44744fbdf80bdf3315e860b7513
change-id: 20251002-binder-orphan-d1bc4bcd9777

Best regards,
-- 
Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] rust_binder: remove warning about orphan mappings

Posted by Carlos Llamas 2 months, 2 weeks ago

On Thu, Oct 02, 2025 at 09:25:29AM +0000, Alice Ryhl wrote:
> This condition occurs if a thread dies while processing a transaction.
> We should not print anything in this scenario.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
>  drivers/android/binder/process.rs | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
> --- a/drivers/android/binder/process.rs
> +++ b/drivers/android/binder/process.rs
> @@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
>                  .alloc
>                  .take_for_each(|offset, size, debug_id, odata| {
>                      let ptr = offset + address;
> -                    pr_warn!(
> -                        "{}: removing orphan mapping {offset}:{size}\n",
> -                        self.pid_in_current_ns()
> -                    );
>                      let mut alloc =
>                          Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
>                      if let Some(data) = odata {
> 

LGTM!

Acked-by: Carlos Llamas <cmllamas@google.com>

Re: [PATCH] rust_binder: remove warning about orphan mappings

Posted by Joel Fernandes 2 months, 2 weeks ago


On 10/2/2025 5:25 AM, Alice Ryhl wrote:
> This condition occurs if a thread dies while processing a transaction.
> We should not print anything in this scenario.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>

thanks,

 - Joel

> ---
>  drivers/android/binder/process.rs | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
> --- a/drivers/android/binder/process.rs
> +++ b/drivers/android/binder/process.rs
> @@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
>                  .alloc
>                  .take_for_each(|offset, size, debug_id, odata| {
>                      let ptr = offset + address;
> -                    pr_warn!(
> -                        "{}: removing orphan mapping {offset}:{size}\n",
> -                        self.pid_in_current_ns()
> -                    );
>                      let mut alloc =
>                          Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
>                      if let Some(data) = odata {
> 
> ---
> base-commit: eafedbc7c050c44744fbdf80bdf3315e860b7513
> change-id: 20251002-binder-orphan-d1bc4bcd9777
> 
> Best regards,