From: Steven Rostedt <rostedt@goodmis.org>
Tracepoints that are defined take up around 5K each, even if they are not
used. If they are defined and not used, then they waste memory for unused
code. Soon unused tracepoints will cause warnings.
Remove the unused tracepoints of the cfg80211 subsystem. They are:
cfg80211_chandef_dfs_required
cfg80211_return_u32
cfg80211_return_uint
cfg80211_send_rx_auth
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Link: https://lore.kernel.org/20250828221759.131160ee@batman.local.home
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
net/wireless/trace.h | 56 --------------------------------------------
1 file changed, 56 deletions(-)
diff --git a/net/wireless/trace.h b/net/wireless/trace.h
index 34c584a215e5..9b6074155d59 100644
--- a/net/wireless/trace.h
+++ b/net/wireless/trace.h
@@ -3137,23 +3137,6 @@ DEFINE_EVENT(cfg80211_netdev_mac_evt, cfg80211_notify_new_peer_candidate,
TP_ARGS(netdev, macaddr)
);
-DECLARE_EVENT_CLASS(netdev_evt_only,
- TP_PROTO(struct net_device *netdev),
- TP_ARGS(netdev),
- TP_STRUCT__entry(
- NETDEV_ENTRY
- ),
- TP_fast_assign(
- NETDEV_ASSIGN;
- ),
- TP_printk(NETDEV_PR_FMT , NETDEV_PR_ARG)
-);
-
-DEFINE_EVENT(netdev_evt_only, cfg80211_send_rx_auth,
- TP_PROTO(struct net_device *netdev),
- TP_ARGS(netdev)
-);
-
TRACE_EVENT(cfg80211_send_rx_assoc,
TP_PROTO(struct net_device *netdev,
const struct cfg80211_rx_assoc_resp_data *data),
@@ -3480,21 +3463,6 @@ TRACE_EVENT(cfg80211_reg_can_beacon,
__entry->prohibited_flags, __entry->permitting_flags)
);
-TRACE_EVENT(cfg80211_chandef_dfs_required,
- TP_PROTO(struct wiphy *wiphy, struct cfg80211_chan_def *chandef),
- TP_ARGS(wiphy, chandef),
- TP_STRUCT__entry(
- WIPHY_ENTRY
- CHAN_DEF_ENTRY
- ),
- TP_fast_assign(
- WIPHY_ASSIGN;
- CHAN_DEF_ASSIGN(chandef);
- ),
- TP_printk(WIPHY_PR_FMT ", " CHAN_DEF_PR_FMT,
- WIPHY_PR_ARG, CHAN_DEF_PR_ARG)
-);
-
TRACE_EVENT(cfg80211_ch_switch_notify,
TP_PROTO(struct net_device *netdev,
struct cfg80211_chan_def *chandef,
@@ -3862,30 +3830,6 @@ DEFINE_EVENT(cfg80211_bss_evt, cfg80211_return_bss,
TP_ARGS(pub)
);
-TRACE_EVENT(cfg80211_return_uint,
- TP_PROTO(unsigned int ret),
- TP_ARGS(ret),
- TP_STRUCT__entry(
- __field(unsigned int, ret)
- ),
- TP_fast_assign(
- __entry->ret = ret;
- ),
- TP_printk("ret: %d", __entry->ret)
-);
-
-TRACE_EVENT(cfg80211_return_u32,
- TP_PROTO(u32 ret),
- TP_ARGS(ret),
- TP_STRUCT__entry(
- __field(u32, ret)
- ),
- TP_fast_assign(
- __entry->ret = ret;
- ),
- TP_printk("ret: %u", __entry->ret)
-);
-
TRACE_EVENT(cfg80211_report_wowlan_wakeup,
TP_PROTO(struct wiphy *wiphy, struct wireless_dev *wdev,
struct cfg80211_wowlan_wakeup *wakeup),
--
2.50.1
On Wed, 2025-10-01 at 10:46 -0400, Steven Rostedt wrote: > From: Steven Rostedt <rostedt@goodmis.org> > > Tracepoints that are defined take up around 5K each, even if they are not > used. If they are defined and not used, then they waste memory for unused > code. Soon unused tracepoints will cause warnings. > > Remove the unused tracepoints of the cfg80211 subsystem. They are: > > cfg80211_chandef_dfs_required > cfg80211_return_u32 > cfg80211_return_uint > cfg80211_send_rx_auth This is in net-next [1], should go to Linus's tree whenever that is pulled [2]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=58febb47b961a91d0d12ee0c1618a7843c0908ce [2] https://lore.kernel.org/lkml/20251001131156.27805-1-pabeni@redhat.com/ johannes
On Wed, 01 Oct 2025 16:49:29 +0200 Johannes Berg <johannes@sipsolutions.net> wrote: > On Wed, 2025-10-01 at 10:46 -0400, Steven Rostedt wrote: > > From: Steven Rostedt <rostedt@goodmis.org> > > > > Tracepoints that are defined take up around 5K each, even if they are not > > used. If they are defined and not used, then they waste memory for unused > > code. Soon unused tracepoints will cause warnings. > > > > Remove the unused tracepoints of the cfg80211 subsystem. They are: > > > > cfg80211_chandef_dfs_required > > cfg80211_return_u32 > > cfg80211_return_uint > > cfg80211_send_rx_auth > > This is in net-next [1], should go to Linus's tree whenever that is > pulled [2]. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=58febb47b961a91d0d12ee0c1618a7843c0908ce > > [2] https://lore.kernel.org/lkml/20251001131156.27805-1-pabeni@redhat.com/ > Thanks, I didn't see any notification it went into net-next. I'll drop it. -- Steve
© 2016 - 2025 Red Hat, Inc.