spi: aspeed: Improve clock, timing and address decoding logic

[PATCH 0/6] spi: aspeed: Improve clock, timing and address decoding logic

Posted by Chin-Ting Kuo 4 months, 1 week ago

This patch series introduces several improvements to the
ASPEED SPI driver, targeting better stability, compatibility
and, flexibility across multiple ASPEED platforms.

Key changes include:

* Clock selection strategy update
  Improves fallback logic when timing calibration is skipped or
  fails, ensuring reliable boot behavior.

* Timing calibration enhancement for AST2600
  Replaces the previous "first-pass" strategy with a more robust
  algorithm that selects the optimal timing point.

* Default address decoding assignment
  Ensures each chip select (CS) has a valid decoding range during
  probe, avoiding detection failures due to missing or incorrect
  bootloader setup.

* Centralized address decoding management
  Refactors the decoding logic to centrally assign address windows,
  preventing improper trimming and improving layout flexibility.

* Per-platform decoding adjustment
  Introduces platform-specific `adjust_window` callbacks to handle
  platform specific hardware constraints for address decoding range.

* Selective memory mapping
  Optimizes memory usage by mapping only the required address window
  per CS to avoid exhaustion.

Chin-Ting Kuo (6):
  spi: aspeed: Update clock selection strategy
  spi: aspeed: Improve timing calibration algorithm for AST2600 platform
  spi: aspeed: Force default address decoding range assignment for each
    CS
  spi: aspeed: Centralize address decoding region management
  spi: aspeed: Add per-platform adjust_window callback for decoding
    range
  spi: aspeed: Only map necessary address window region

 drivers/spi/spi-aspeed-smc.c | 644 ++++++++++++++++++++++++++---------
 1 file changed, 489 insertions(+), 155 deletions(-)

-- 
2.34.1

Re: [PATCH 0/6] spi: aspeed: Improve clock, timing and address decoding logic

Posted by Mark Brown 3 months, 3 weeks ago

On Wed, 01 Oct 2025 19:25:59 +0800, Chin-Ting Kuo wrote:
> This patch series introduces several improvements to the
> ASPEED SPI driver, targeting better stability, compatibility
> and, flexibility across multiple ASPEED platforms.
> 
> Key changes include:
> 
> * Clock selection strategy update
>   Improves fallback logic when timing calibration is skipped or
>   fails, ensuring reliable boot behavior.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/6] spi: aspeed: Update clock selection strategy
      commit: 31dcc7e1f8a9377d8fd9f967f84c121c5ba8f89c
[2/6] spi: aspeed: Improve timing calibration algorithm for AST2600 platform
      commit: efb79de36e947d136517bac14c139d494fcc72fa
[3/6] spi: aspeed: Force default address decoding range assignment for each CS
      commit: 630a185fd06109193574d10f38b29812986c21de
[4/6] spi: aspeed: Centralize address decoding region management
      commit: b546e0023a203e7edf9377ac8f4f490a6965afd6
[5/6] spi: aspeed: Add per-platform adjust_window callback for decoding range
      commit: 0586b53d4a0c7c5a132629f99da934cc674ea4cd
[6/6] spi: aspeed: Only map necessary address window region
      commit: 64d87ccfae3326a9561fe41dc6073064a083e0df

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark