dma-mapping: fix direction in dma_alloc direction traces

[PATCH] dma-mapping: fix direction in dma_alloc direction traces

Posted by Petr Tesarik 4 months, 1 week ago

Set __entry->dir to the actual "dir" parameter of all trace events
in dma_alloc_class. This struct member was left uninitialized by
mistake.

Signed-off-by: Petr Tesarik <ptesarik@suse.com>
Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
---
 include/trace/events/dma.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
index d8ddc27b6a7c8..945fcbaae77e9 100644
--- a/include/trace/events/dma.h
+++ b/include/trace/events/dma.h
@@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
 		__entry->dma_addr = dma_addr;
 		__entry->size = size;
 		__entry->flags = flags;
+		__entry->dir = dir;
 		__entry->attrs = attrs;
 	),
 
-- 
2.51.0

Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces

Posted by Marek Szyprowski 4 months, 1 week ago

On 01.10.2025 08:10, Petr Tesarik wrote:
> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")

Applied to dma-mapping-for-next (for v6.18-rc1) branch. Thanks!

> ---
>   include/trace/events/dma.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
>   		__entry->dma_addr = dma_addr;
>   		__entry->size = size;
>   		__entry->flags = flags;
> +		__entry->dir = dir;
>   		__entry->attrs = attrs;
>   	),
>   

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces

Posted by Petr Tesarik 4 months, 1 week ago

On Fri, 3 Oct 2025 09:00:13 +0200
Marek Szyprowski <m.szyprowski@samsung.com> wrote:

> On 01.10.2025 08:10, Petr Tesarik wrote:
> > Set __entry->dir to the actual "dir" parameter of all trace events
> > in dma_alloc_class. This struct member was left uninitialized by
> > mistake.
> >
> > Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> > Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")  
> 
> Applied to dma-mapping-for-next (for v6.18-rc1) branch. Thanks!

Thank you for maintaining the code!

Petr T

Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces

Posted by Sean Anderson 4 months, 1 week ago

On 10/1/25 02:10, Petr Tesarik wrote:
> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
> 
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
> ---
>  include/trace/events/dma.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
>  		__entry->dma_addr = dma_addr;
>  		__entry->size = size;
>  		__entry->flags = flags;
> +		__entry->dir = dir;
>  		__entry->attrs = attrs;
>  	),
>  

Reviewed-by: Sean Anderson <sean.anderson@linux.dev>

Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces

Posted by Petr Tesarik 4 months, 1 week ago

Cc: stable@vger.kernel.org

(One day, I'll finally remember, I promise.)

Petr T

On Wed,  1 Oct 2025 08:10:28 +0200
Petr Tesarik <ptesarik@suse.com> wrote:

> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
> 
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
> ---
>  include/trace/events/dma.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
>  		__entry->dma_addr = dma_addr;
>  		__entry->size = size;
>  		__entry->flags = flags;
> +		__entry->dir = dir;
>  		__entry->attrs = attrs;
>  	),
>