[PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta Yosemite5 board

Kevin Tung posted 2 patches 4 months, 1 week ago
[PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta Yosemite5 board
Posted by Kevin Tung 4 months, 1 week ago
Document the new compatibles used on Meta Yosemite5.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 456dbf7b5ec8f4442be815284e1ad085287dc443..6f2b12f96bd6ce31b4175e109a78d931dffdfe28 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -89,6 +89,7 @@ properties:
               - facebook,minerva-cmc
               - facebook,santabarbara-bmc
               - facebook,yosemite4-bmc
+              - facebook,yosemite5-bmc
               - ibm,blueridge-bmc
               - ibm,everest-bmc
               - ibm,fuji-bmc

-- 
2.51.0
Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta Yosemite5 board
Posted by Conor Dooley 4 months, 1 week ago
On Wed, Oct 01, 2025 at 04:47:50PM +0800, Kevin Tung wrote:
> Document the new compatibles used on Meta Yosemite5.
> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>

You've repeatedly ignored my ack, so I assume you don't want it.
Maybe you want a nak instead?

> ---
>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index 456dbf7b5ec8f4442be815284e1ad085287dc443..6f2b12f96bd6ce31b4175e109a78d931dffdfe28 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -89,6 +89,7 @@ properties:
>                - facebook,minerva-cmc
>                - facebook,santabarbara-bmc
>                - facebook,yosemite4-bmc
> +              - facebook,yosemite5-bmc
>                - ibm,blueridge-bmc
>                - ibm,everest-bmc
>                - ibm,fuji-bmc
> 
> -- 
> 2.51.0
> 
Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta Yosemite5 board
Posted by Kevin Tung 4 months, 1 week ago
On Thu, Oct 2, 2025 at 2:33 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Oct 01, 2025 at 04:47:50PM +0800, Kevin Tung wrote:
> > Document the new compatibles used on Meta Yosemite5.
> >
> > Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
>
> You've repeatedly ignored my ack, so I assume you don't want it.
> Maybe you want a nak instead?
>

Apologies for ignoring your ack repeatedly, that was not intentional.
I truly value your review and will make sure to include it. Would you
suggest that I send a v4 to pick it up, or is it fine to carry it
forward in the next revision?
Thank you again for taking the time to review my patches.

Kevin
> > ---
> >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > index 456dbf7b5ec8f4442be815284e1ad085287dc443..6f2b12f96bd6ce31b4175e109a78d931dffdfe28 100644
> > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > @@ -89,6 +89,7 @@ properties:
> >                - facebook,minerva-cmc
> >                - facebook,santabarbara-bmc
> >                - facebook,yosemite4-bmc
> > +              - facebook,yosemite5-bmc
> >                - ibm,blueridge-bmc
> >                - ibm,everest-bmc
> >                - ibm,fuji-bmc
> >
> > --
> > 2.51.0
> >
Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta Yosemite5 board
Posted by Conor Dooley 4 months, 1 week ago
On Thu, Oct 02, 2025 at 12:23:47PM +0800, Kevin Tung wrote:
> On Thu, Oct 2, 2025 at 2:33 AM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Oct 01, 2025 at 04:47:50PM +0800, Kevin Tung wrote:
> > > Document the new compatibles used on Meta Yosemite5.
> > >
> > > Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> >
> > You've repeatedly ignored my ack, so I assume you don't want it.
> > Maybe you want a nak instead?
> >
> 
> Apologies for ignoring your ack repeatedly, that was not intentional.
> I truly value your review and will make sure to include it. Would you
> suggest that I send a v4 to pick it up, or is it fine to carry it
> forward in the next revision?
> Thank you again for taking the time to review my patches.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

The maintainer will add it when they apply, there's no need to make
another version for this alone.

> 
> Kevin
> > > ---
> > >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > > index 456dbf7b5ec8f4442be815284e1ad085287dc443..6f2b12f96bd6ce31b4175e109a78d931dffdfe28 100644
> > > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > > @@ -89,6 +89,7 @@ properties:
> > >                - facebook,minerva-cmc
> > >                - facebook,santabarbara-bmc
> > >                - facebook,yosemite4-bmc
> > > +              - facebook,yosemite5-bmc
> > >                - ibm,blueridge-bmc
> > >                - ibm,everest-bmc
> > >                - ibm,fuji-bmc
> > >
> > > --
> > > 2.51.0
> > >
Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: add Meta Yosemite5 board
Posted by Kevin Tung 4 months, 1 week ago
On Fri, Oct 3, 2025 at 2:35 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Oct 02, 2025 at 12:23:47PM +0800, Kevin Tung wrote:
> > On Thu, Oct 2, 2025 at 2:33 AM Conor Dooley <conor@kernel.org> wrote:
> > >
> > > On Wed, Oct 01, 2025 at 04:47:50PM +0800, Kevin Tung wrote:
> > > > Document the new compatibles used on Meta Yosemite5.
> > > >
> > > > Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> > >
> > > You've repeatedly ignored my ack, so I assume you don't want it.
> > > Maybe you want a nak instead?
> > >
> >
> > Apologies for ignoring your ack repeatedly, that was not intentional.
> > I truly value your review and will make sure to include it. Would you
> > suggest that I send a v4 to pick it up, or is it fine to carry it
> > forward in the next revision?
> > Thank you again for taking the time to review my patches.
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> The maintainer will add it when they apply, there's no need to make
> another version for this alone.
>
Got it, thanks for clarifying.
> >
> > Kevin
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > > > index 456dbf7b5ec8f4442be815284e1ad085287dc443..6f2b12f96bd6ce31b4175e109a78d931dffdfe28 100644
> > > > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > > > @@ -89,6 +89,7 @@ properties:
> > > >                - facebook,minerva-cmc
> > > >                - facebook,santabarbara-bmc
> > > >                - facebook,yosemite4-bmc
> > > > +              - facebook,yosemite5-bmc
> > > >                - ibm,blueridge-bmc
> > > >                - ibm,everest-bmc
> > > >                - ibm,fuji-bmc
> > > >
> > > > --
> > > > 2.51.0
> > > >