[PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)

Jacob Keller posted 8 patches 4 months, 1 week ago
There is a newer version of this series
drivers/net/ethernet/intel/idpf/idpf.h             |  12 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h       |  15 ++
drivers/net/ethernet/intel/ixgbevf/defines.h       |   1 +
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h       |   7 +
drivers/net/ethernet/intel/ixgbevf/mbx.h           |   8 +
drivers/net/ethernet/intel/ixgbevf/vf.h            |   1 +
drivers/net/ethernet/intel/idpf/idpf_ethtool.c     |  10 +-
drivers/net/ethernet/intel/idpf/idpf_lib.c         |  23 ++-
drivers/net/ethernet/intel/idpf/idpf_ptp.c         |   3 +
.../net/ethernet/intel/idpf/idpf_singleq_txrx.c    |   2 +-
drivers/net/ethernet/intel/idpf/idpf_txrx.c        |   2 +-
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c    |   4 +-
.../net/ethernet/intel/idpf/idpf_virtchnl_ptp.c    |   1 +
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |   3 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c     |  79 +++++++++
drivers/net/ethernet/intel/ixgbevf/ipsec.c         |  10 ++
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c  |  34 +++-
drivers/net/ethernet/intel/ixgbevf/vf.c            | 182 +++++++++++++++++----
18 files changed, 335 insertions(+), 62 deletions(-)
[PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)
Posted by Jacob Keller 4 months, 1 week ago
For idpf:
Milena fixes a memory leak in the idpf reset logic when the driver resets
with an outstanding Tx timestamp.

Emil fixes a race condition in idpf_vport_stop() by using
test_and_clear_bit() to ensure we execute idpf_vport_stop() once.

For ixgbe and ixgbevf:
Jedrzej fixes an issue with reporting link speed on E610 VFs.

Jedrzej also fixes the VF mailbox API incompatibilities caused by the
confusion with API v1.4, v1.5, and v1.6. The v1.4 API introduced IPSEC
offload, but this was only supported on Linux hosts. The v1.5 API
introduced a new mailbox API which is necessary to resolve issues on ESX
hosts. The v1.6 API introduced a new link management API for E610. Jedrzej
introduces a new v1.7 API with a feature negotiation which enables properly
checking if features such as IPSEC or the ESX mailbox APIs are supported.
This resolves issues with compatibility on different hosts, and aligns the
API across hosts instead of having Linux require custom mailbox API
versions for IPSEC offload.

Koichiro fixes a KASAN use-after-free bug in ixgbe_remove().

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Emil Tantilov (2):
      idpf: convert vport state to bitmap
      idpf: fix possible race in idpf_vport_stop()

Jedrzej Jagielski (4):
      ixgbevf: fix getting link speed data for E610 devices
      ixgbe: handle IXGBE_VF_GET_PF_LINK_STATE mailbox operation
      ixgbevf: fix mailbox API compatibility by negotiating supported features
      ixgbe: handle IXGBE_VF_FEATURES_NEGOTIATE mbox cmd

Koichiro Den (1):
      ixgbe: fix too early devlink_free() in ixgbe_remove()

Milena Olech (1):
      idpf: cleanup remaining SKBs in PTP flows

 drivers/net/ethernet/intel/idpf/idpf.h             |  12 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h       |  15 ++
 drivers/net/ethernet/intel/ixgbevf/defines.h       |   1 +
 drivers/net/ethernet/intel/ixgbevf/ixgbevf.h       |   7 +
 drivers/net/ethernet/intel/ixgbevf/mbx.h           |   8 +
 drivers/net/ethernet/intel/ixgbevf/vf.h            |   1 +
 drivers/net/ethernet/intel/idpf/idpf_ethtool.c     |  10 +-
 drivers/net/ethernet/intel/idpf/idpf_lib.c         |  23 ++-
 drivers/net/ethernet/intel/idpf/idpf_ptp.c         |   3 +
 .../net/ethernet/intel/idpf/idpf_singleq_txrx.c    |   2 +-
 drivers/net/ethernet/intel/idpf/idpf_txrx.c        |   2 +-
 drivers/net/ethernet/intel/idpf/idpf_virtchnl.c    |   4 +-
 .../net/ethernet/intel/idpf/idpf_virtchnl_ptp.c    |   1 +
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |   3 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c     |  79 +++++++++
 drivers/net/ethernet/intel/ixgbevf/ipsec.c         |  10 ++
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c  |  34 +++-
 drivers/net/ethernet/intel/ixgbevf/vf.c            | 182 +++++++++++++++++----
 18 files changed, 335 insertions(+), 62 deletions(-)
---
base-commit: daa26ea63c6f848159821cd9b3cbe47cddbb0a1c
change-id: 20251001-jk-iwl-net-2025-10-01-92cd2a626ff7

Best regards,
--  
Jacob Keller <jacob.e.keller@intel.com>
Re: [PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)
Posted by Jakub Kicinski 4 months, 1 week ago
On Wed, 01 Oct 2025 17:14:10 -0700 Jacob Keller wrote:
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

We need your sign-off on the patches.
Sorry for not noticing earlier.
Re: [PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)
Posted by Jacob Keller 4 months, 1 week ago

On 10/3/2025 10:42 AM, Jakub Kicinski wrote:
> On Wed, 01 Oct 2025 17:14:10 -0700 Jacob Keller wrote:
>> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> 
> We need your sign-off on the patches.
> Sorry for not noticing earlier.

Argh. Apologies for missing that. I'll resend the ones besides the idpf
fix you commented on.

Thanks,
Jake
Re: [PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)
Posted by Alexander Lobakin 4 months ago
From: Jacob Keller <jacob.e.keller@intel.com>
Date: Wed, 01 Oct 2025 17:14:10 -0700

> For idpf:
> Milena fixes a memory leak in the idpf reset logic when the driver resets
> with an outstanding Tx timestamp.
> 
> Emil fixes a race condition in idpf_vport_stop() by using
> test_and_clear_bit() to ensure we execute idpf_vport_stop() once.
Patches 2-3 (at least) triggered a good bunch of compiler errors in
Tony's queue due to that XDP and XSk support for idpf went into net-next
already, but these patches weren't rebased and retested after that.

Thanks,
Olek
Re: [PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)
Posted by Jacob Keller 4 months ago

On 10/6/2025 8:27 AM, Alexander Lobakin wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
> Date: Wed, 01 Oct 2025 17:14:10 -0700
> 
>> For idpf:
>> Milena fixes a memory leak in the idpf reset logic when the driver resets
>> with an outstanding Tx timestamp.
>>
>> Emil fixes a race condition in idpf_vport_stop() by using
>> test_and_clear_bit() to ensure we execute idpf_vport_stop() once.
> Patches 2-3 (at least) triggered a good bunch of compiler errors in
> Tony's queue due to that XDP and XSk support for idpf went into net-next
> already, but these patches weren't rebased and retested after that.
> 
> Thanks,
> Olek

I've at least fixed the compile failures on whats published in Tony's
dev-queue for net and next now. Thanks for letting me know.
Re: [PATCH net 0/8] Intel Wired LAN Driver Updates 2025-10-01 (idpf, ixgbe, ixgbevf)
Posted by Jacob Keller 4 months ago

On 10/6/2025 8:27 AM, Alexander Lobakin wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
> Date: Wed, 01 Oct 2025 17:14:10 -0700
> 
>> For idpf:
>> Milena fixes a memory leak in the idpf reset logic when the driver resets
>> with an outstanding Tx timestamp.
>>
>> Emil fixes a race condition in idpf_vport_stop() by using
>> test_and_clear_bit() to ensure we execute idpf_vport_stop() once.
> Patches 2-3 (at least) triggered a good bunch of compiler errors in
> Tony's queue due to that XDP and XSk support for idpf went into net-next
> already, but these patches weren't rebased and retested after that.
> 
> Thanks,
> Olek

Yep, I thought I had based on this after the merge with the XDP support,
but apparently I was too early.

We have outstanding comments from Jakub on the flags changes, so I
dropped them from v2, but still have conflicts. Working on a v3 to fix that.