Remove an unnecessary 'break' statement that follows a 'return'
in arch/arm64/kvm/at.c. The break is unreachable.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 arch/arm64/kvm/at.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c
index d71ca4ddc9d1..b04c00f95944 100644
--- a/arch/arm64/kvm/at.c
+++ b/arch/arm64/kvm/at.c
@@ -43,7 +43,6 @@ static enum trans_regime compute_translation_regime(struct kvm_vcpu *vcpu, u32 o
 	case OP_AT_S1E2W:
 	case OP_AT_S1E2A:
 		return vcpu_el2_e2h_is_set(vcpu) ? TR_EL20 : TR_EL2;
-		break;
 	default:
 		return (vcpu_el2_e2h_is_set(vcpu) &&
 			vcpu_el2_tge_is_set(vcpu)) ? TR_EL20 : TR_EL10;
-- 
2.43.0

On Tue, 30 Sep 2025 16:56:21 +0300, Osama Abdelkader wrote:
> Remove an unnecessary 'break' statement that follows a 'return'
> in arch/arm64/kvm/at.c. The break is unreachable.
> 
> 

Applied to fixes, thanks!

[1/1] KVM: arm64: Remove unreachable break after return
      commit: 55eeaa24c9ac3a22f9c220500e23ee8b6ddff751

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.

On 2025/9/30 21:56, Osama Abdelkader wrote:
> Remove an unnecessary 'break' statement that follows a 'return'
> in arch/arm64/kvm/at.c. The break is unreachable.
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>  arch/arm64/kvm/at.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c
> index d71ca4ddc9d1..b04c00f95944 100644
> --- a/arch/arm64/kvm/at.c
> +++ b/arch/arm64/kvm/at.c
> @@ -43,7 +43,6 @@ static enum trans_regime compute_translation_regime(struct kvm_vcpu *vcpu, u32 o
>  	case OP_AT_S1E2W:
>  	case OP_AT_S1E2A:
>  		return vcpu_el2_e2h_is_set(vcpu) ? TR_EL20 : TR_EL2;
> -		break;
>  	default:
>  		return (vcpu_el2_e2h_is_set(vcpu) &&
>  			vcpu_el2_tge_is_set(vcpu)) ? TR_EL20 : TR_EL10;

Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>

Thanks,
Zenghui