ASoC: codecs: Fix the error of excessive semicolons

[PATCH] ASoC: codecs: Fix the error of excessive semicolons

Posted by TangBin 2 months, 2 weeks ago

From: Tang Bin <tangbin@cmss.chinamobile.com>

Remove unnecessary semicolons in the function
pm4125_codec_enable_adc and pm4125_micbias_control.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 sound/soc/codecs/pm4125.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c
index 706fc668f..aa8319c4a 100644
--- a/sound/soc/codecs/pm4125.c
+++ b/sound/soc/codecs/pm4125.c
@@ -691,7 +691,7 @@ static int pm4125_codec_enable_adc(struct snd_soc_dapm_widget *w,
 						      0x00);
 		pm4125_global_mbias_disable(component);
 		break;
-	};
+	}
 
 	return 0;
 }
@@ -756,7 +756,7 @@ static int pm4125_micbias_control(struct snd_soc_component *component, int micb_
 		dev_err(component->dev, "%s: Invalid micbias number: %d\n",
 			__func__, micb_num);
 		return -EINVAL;
-	};
+	}
 
 	switch (req) {
 	case MICB_PULLUP_ENABLE:
@@ -799,7 +799,7 @@ static int pm4125_micbias_control(struct snd_soc_component *component, int micb_
 			pm4125_global_mbias_disable(component);
 		}
 		break;
-	};
+	}
 
 	return 0;
 }
-- 
2.33.0

Re: [PATCH] ASoC: codecs: Fix the error of excessive semicolons

Posted by Alexey Klimov 2 months, 2 weeks ago

On Tue Sep 30, 2025 at 10:41 AM BST, TangBin wrote:
> From: Tang Bin <tangbin@cmss.chinamobile.com>
>
> Remove unnecessary semicolons in the function
> pm4125_codec_enable_adc and pm4125_micbias_control.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Please use better email/commit subject or title.
I'd say that something like "ASoC: codecs: pm4125: ... " would be better
to reflect which codec this change relates to.


> ---
>  sound/soc/codecs/pm4125.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c
> index 706fc668f..aa8319c4a 100644
> --- a/sound/soc/codecs/pm4125.c
> +++ b/sound/soc/codecs/pm4125.c
> @@ -691,7 +691,7 @@ static int pm4125_codec_enable_adc(struct snd_soc_dapm_widget *w,
>  						      0x00);
>  		pm4125_global_mbias_disable(component);
>  		break;
> -	};
> +	}
>  
>  	return 0;
>  }
> @@ -756,7 +756,7 @@ static int pm4125_micbias_control(struct snd_soc_component *component, int micb_
>  		dev_err(component->dev, "%s: Invalid micbias number: %d\n",
>  			__func__, micb_num);
>  		return -EINVAL;
> -	};
> +	}
>  
>  	switch (req) {
>  	case MICB_PULLUP_ENABLE:
> @@ -799,7 +799,7 @@ static int pm4125_micbias_control(struct snd_soc_component *component, int micb_
>  			pm4125_global_mbias_disable(component);
>  		}
>  		break;
> -	};
> +	}

Thanks for noticing this.

Looks like checkpatch.pl --strict generates a bit of more warnings for this file.

Best regards,
Alexey

Re: [PATCH] ASoC: codecs: Fix the error of excessive semicolons

Posted by Dmitry Baryshkov 2 months, 2 weeks ago

On Tue, Sep 30, 2025 at 05:41:03PM +0800, TangBin wrote:
> From: Tang Bin <tangbin@cmss.chinamobile.com>
> 
> Remove unnecessary semicolons in the function
> pm4125_codec_enable_adc and pm4125_micbias_control.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  sound/soc/codecs/pm4125.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry