1. Patchew
  2. linux
  3. [PATCH 0/6] Further bringup of SHIFTphone 8
  4. View patch

[PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

Luca Weiss posted 6 patches 4 months, 1 week ago
There is a newer version of this series
[PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
Posted by Luca Weiss 4 months, 1 week ago 
From: Luca Weiss <luca@lucaweiss.eu>

Enable the RGB LED connected to the PM7350C (PM8350C).

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -632,6 +632,33 @@ led-0 {
 	};
 };
 
+&pm8350c_pwm {
+	status = "okay";
+
+	multi-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@2 {
+			reg = <2>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
 &pmk8350_adc_tm {
 	status = "okay";
 

-- 
2.51.0
Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
Posted by Pavel Machek 3 months, 2 weeks ago 
On Tue 2025-09-30 16:32:23, Luca Weiss wrote:
> From: Luca Weiss <luca@lucaweiss.eu>
> 
> Enable the RGB LED connected to the PM7350C (PM8350C).
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Reviewed-by: Pavel Machek <pavel@ucw.cz>

Thanks!
							Pavel

-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
Posted by Konrad Dybcio 4 months, 1 week ago 
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Luca Weiss <luca@lucaweiss.eu>
> 
> Enable the RGB LED connected to the PM7350C (PM8350C).
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -632,6 +632,33 @@ led-0 {
>  	};
>  };
>  
> +&pm8350c_pwm {
> +	status = "okay";
> +
> +	multi-led {
> +		color = <LED_COLOR_ID_RGB>;
> +		function = LED_FUNCTION_STATUS;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@1 {
> +			reg = <1>;
> +			color = <LED_COLOR_ID_RED>;
> +		};
> +
> +		led@2 {
> +			reg = <2>;
> +			color = <LED_COLOR_ID_GREEN>;
> +		};
> +
> +		led@3 {
> +			reg = <3>;
> +			color = <LED_COLOR_ID_BLUE>;
> +		};

I assume you managed to confirm these mappings are correct.. sometimes
they are not what you'd expect

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
Posted by Luca Weiss 4 months, 1 week ago 
On Wed Oct 1, 2025 at 10:29 AM CEST, Konrad Dybcio wrote:
> On 9/30/25 4:32 PM, Luca Weiss wrote:
>> From: Luca Weiss <luca@lucaweiss.eu>
>> 
>> Enable the RGB LED connected to the PM7350C (PM8350C).
>> 
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> @@ -632,6 +632,33 @@ led-0 {
>>  	};
>>  };
>>  
>> +&pm8350c_pwm {
>> +	status = "okay";
>> +
>> +	multi-led {
>> +		color = <LED_COLOR_ID_RGB>;
>> +		function = LED_FUNCTION_STATUS;
>> +
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		led@1 {
>> +			reg = <1>;
>> +			color = <LED_COLOR_ID_RED>;
>> +		};
>> +
>> +		led@2 {
>> +			reg = <2>;
>> +			color = <LED_COLOR_ID_GREEN>;
>> +		};
>> +
>> +		led@3 {
>> +			reg = <3>;
>> +			color = <LED_COLOR_ID_BLUE>;
>> +		};
>
> I assume you managed to confirm these mappings are correct.. sometimes
> they are not what you'd expect

If you mean, that red == red, green == green and blue == blue, yes. The
RGB configured from user space matches the color on the LED.

Regards
Luca

>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
Posted by Konrad Dybcio 4 months, 1 week ago 
On 10/1/25 10:30 AM, Luca Weiss wrote:
> On Wed Oct 1, 2025 at 10:29 AM CEST, Konrad Dybcio wrote:
>> On 9/30/25 4:32 PM, Luca Weiss wrote:
>>> From: Luca Weiss <luca@lucaweiss.eu>
>>>
>>> Enable the RGB LED connected to the PM7350C (PM8350C).
>>>
>>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> @@ -632,6 +632,33 @@ led-0 {
>>>  	};
>>>  };
>>>  
>>> +&pm8350c_pwm {
>>> +	status = "okay";
>>> +
>>> +	multi-led {
>>> +		color = <LED_COLOR_ID_RGB>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +
>>> +		led@1 {
>>> +			reg = <1>;
>>> +			color = <LED_COLOR_ID_RED>;
>>> +		};
>>> +
>>> +		led@2 {
>>> +			reg = <2>;
>>> +			color = <LED_COLOR_ID_GREEN>;
>>> +		};
>>> +
>>> +		led@3 {
>>> +			reg = <3>;
>>> +			color = <LED_COLOR_ID_BLUE>;
>>> +		};
>>
>> I assume you managed to confirm these mappings are correct.. sometimes
>> they are not what you'd expect
> 
> If you mean, that red == red, green == green and blue == blue, yes. The
> RGB configured from user space matches the color on the LED.

Yeah that's what I meant, thanks

Konrad

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.