|
Fix warning caused from declaration under a case label. The proper way
is to declare variable at the beginning of the function. The warning
came from running clang using LLVM=1; and is as follows:
--
-test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
|
Signed-off-by: Sidharth Seela <sidharthseela@gmail.com>
---
diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c
index c952640f163b..0305e736f2b8 100644
--- a/tools/testing/selftests/cachestat/test_cachestat.c
+++ b/tools/testing/selftests/cachestat/test_cachestat.c
@@ -226,7 +226,7 @@ bool run_cachestat_test(enum file_type type)
int syscall_ret;
size_t compute_len = PS * 512;
struct cachestat_range cs_range = { PS, compute_len };
- char *filename = "tmpshmcstat";
+ char *filename = "tmpshmcstat", *map;
struct cachestat cs;
bool ret = true;
int fd;
@@ -257,7 +257,7 @@ bool run_cachestat_test(enum file_type type)
}
break;
case FILE_MMAP:
- char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
+ map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
MAP_SHARED, fd, 0);
if (map == MAP_FAILED) {
--
2.47.3On 29/09/25 5:24 pm, Sidharth Seela wrote: > Fix warning caused from declaration under a case label. The proper way > is to declare variable at the beginning of the function. The warning > came from running clang using LLVM=1; and is as follows: > -- > -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] > 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, > | > > Signed-off-by: Sidharth Seela <sidharthseela@gmail.com> > --- > Reviewed-by: Dev Jain <dev.jain@arm.com>
On 9/29/25 22:52, Dev Jain wrote: > > On 29/09/25 5:24 pm, Sidharth Seela wrote: >> Fix warning caused from declaration under a case label. The proper way >> is to declare variable at the beginning of the function. The warning >> came from running clang using LLVM=1; and is as follows: >> -- Sidharth, Make sure to not use "---" in your commit logs. Everything after this line gets thrown away. I had to go fix it manually. >> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] >> 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, >> | >> >> Signed-off-by: Sidharth Seela <sidharthseela@gmail.com> >> --- >> > > Reviewed-by: Dev Jain <dev.jain@arm.com> > Applied to linux-kselftest fixes branch for next rc. thanks, -- Shuah
> Make sure to not use "---" in your commit logs. Everything after > this line gets thrown away. I had to go fix it manually. Sorry, I will make sure that doesn't happen again. -- Thanks, Sidharth Seela
On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela <sidharthseela@gmail.com> wrote: > Fix warning caused from declaration under a case label. The proper way > is to declare variable at the beginning of the function. The warning > came from running clang using LLVM=1; and is as follows: > -- > -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] > 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, > | > > Signed-off-by: Sidharth Seela <sidharthseela@gmail.com> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ [...]
On 9/29/25 11:27, SeongJae Park wrote: > On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela <sidharthseela@gmail.com> wrote: > >> Fix warning caused from declaration under a case label. The proper way >> is to declare variable at the beginning of the function. The warning >> came from running clang using LLVM=1; and is as follows: >> -- >> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] >> 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, >> | >> >> Signed-off-by: Sidharth Seela <sidharthseela@gmail.com> > > Reviewed-by: SeongJae Park <sj@kernel.org> > > Johannes and Nhat, Assuming this will go through cachestat tree Acked-by: Shuah Khan <skhan@linuxfoundation.org> Let me know if you would like me to take this through my tree. thanks, -- Shuah
On Fri, Oct 10, 2025 at 1:07 PM Shuah Khan <skhan@linuxfoundation.org> wrote: > > On 9/29/25 11:27, SeongJae Park wrote: > > On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela <sidharthseela@gmail.com> wrote: > > > >> Fix warning caused from declaration under a case label. The proper way > >> is to declare variable at the beginning of the function. The warning > >> came from running clang using LLVM=1; and is as follows: > >> -- > >> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] > >> 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, > >> | > >> > >> Signed-off-by: Sidharth Seela <sidharthseela@gmail.com> > > > > Reviewed-by: SeongJae Park <sj@kernel.org> > > > > > > Johannes and Nhat, > > Assuming this will go through cachestat tree > > Acked-by: Shuah Khan <skhan@linuxfoundation.org> > Hi Shuah. LGTM: Acked-by: Nhat Pham <nphamcs@gmail.com>
From: wang lian <lianux.mm@gmail.com> Reviewed-by: wang lian <lianux.mm@gmail.com> > Fix warning caused from declaration under a case label. The proper way > is to declare variable at the beginning of the function. The warning > came from running clang using LLVM=1; and is as follows: > -- > -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] > 260 | char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, > | > > Signed-off-by: Sidharth Seela <sidharthseela@gmail.com> Best regards, wang lian
© 2016 - 2026 Red Hat, Inc.