[PATCH V2 0/4] Add tegra264 audio device tree support

Sheetal . posted 4 patches 4 months, 1 week ago
.../bindings/dma/nvidia,tegra210-adma.yaml    |   15 +-
.../interrupt-controller/arm,gic.yaml         |    1 +
.../sound/nvidia,tegra210-admaif.yaml         |  106 +-
.../arm64/boot/dts/nvidia/tegra264-p3971.dtsi |  106 +
arch/arm64/boot/dts/nvidia/tegra264.dtsi      | 3190 +++++++++++++++++
5 files changed, 3377 insertions(+), 41 deletions(-)
[PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Sheetal . 4 months, 1 week ago
From: sheetal <sheetal@nvidia.com>

Add device tree support for tegra264 audio subsystem including:
- Binding update for
  - 64-channel ADMA controller
  - 32 RX/TX ADMAIF channels
  - tegra264-agic binding for arm,gic  
- Add device tree nodes for
  - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
    DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
  - HDA controller
  - sound

Note:
 The change is dependent on https://patchwork.ozlabs.org/project/linux-tegra/patch/20250818135241.3407180-1-thierry.reding@gmail.com/

...
Changes in V2:
 - Update the allOf condition in Patch 2/4.

sheetal (4):
  dt-bindings: dma: Update ADMA bindings for tegra264
  dt-bindings: sound: Update ADMAIF bindings for tegra264
  dt-bindings: interrupt-controller: arm,gic: Add tegra264-agic
  arm64: tegra: Add tegra264 audio support

 .../bindings/dma/nvidia,tegra210-adma.yaml    |   15 +-
 .../interrupt-controller/arm,gic.yaml         |    1 +
 .../sound/nvidia,tegra210-admaif.yaml         |  106 +-
 .../arm64/boot/dts/nvidia/tegra264-p3971.dtsi |  106 +
 arch/arm64/boot/dts/nvidia/tegra264.dtsi      | 3190 +++++++++++++++++
 5 files changed, 3377 insertions(+), 41 deletions(-)

-- 
2.34.1
Re: [PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Rob Herring (Arm) 4 months, 1 week ago
On Mon, 29 Sep 2025 16:29:26 +0530, Sheetal . wrote:
> From: sheetal <sheetal@nvidia.com>
> 
> Add device tree support for tegra264 audio subsystem including:
> - Binding update for
>   - 64-channel ADMA controller
>   - 32 RX/TX ADMAIF channels
>   - tegra264-agic binding for arm,gic
> - Add device tree nodes for
>   - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
>     DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
>   - HDA controller
>   - sound
> 
> Note:
>  The change is dependent on https://patchwork.ozlabs.org/project/linux-tegra/patch/20250818135241.3407180-1-thierry.reding@gmail.com/
> 
> ...
> Changes in V2:
>  - Update the allOf condition in Patch 2/4.
> 
> sheetal (4):
>   dt-bindings: dma: Update ADMA bindings for tegra264
>   dt-bindings: sound: Update ADMAIF bindings for tegra264
>   dt-bindings: interrupt-controller: arm,gic: Add tegra264-agic
>   arm64: tegra: Add tegra264 audio support
> 
>  .../bindings/dma/nvidia,tegra210-adma.yaml    |   15 +-
>  .../interrupt-controller/arm,gic.yaml         |    1 +
>  .../sound/nvidia,tegra210-admaif.yaml         |  106 +-
>  .../arm64/boot/dts/nvidia/tegra264-p3971.dtsi |  106 +
>  arch/arm64/boot/dts/nvidia/tegra264.dtsi      | 3190 +++++++++++++++++
>  5 files changed, 3377 insertions(+), 41 deletions(-)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.17-rc1-57-g635ae6f0a3ad (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250929105930.1767294-1-sheetal@nvidia.com:

In file included from arch/arm64/boot/dts/nvidia/tegra264-p3834.dtsi:3,
                 from arch/arm64/boot/dts/nvidia/tegra264-p3834-0008.dtsi:3,
                 from arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dts:5:
arch/arm64/boot/dts/nvidia/tegra264.dtsi:8:10: fatal error: dt-bindings/power/nvidia,tegra264-powergate.h: No such file or directory
    8 | #include <dt-bindings/power/nvidia,tegra264-powergate.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [scripts/Makefile.dtbs:132: arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dtb] Error 1
make[2]: *** [scripts/Makefile.build:556: arch/arm64/boot/dts/nvidia] Error 2
make[2]: Target 'arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1480: nvidia/tegra264-p3971-0089+p3834-0008.dtb] Error 2
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'nvidia/tegra210-p2371-2180.dtb' not remade because of errors.
make: Target 'nvidia/tegra210-p3450-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra234-p3737-0000+p3701-0008.dtb' not remade because of errors.
make: Target 'nvidia/tegra234-p3740-0002+p3701-0008.dtb' not remade because of errors.
make: Target 'nvidia/tegra234-p3737-0000+p3701-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra186-p2771-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra210-p2371-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra194-p3509-0000+p3668-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra234-p3768-0000+p3767-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra234-sim-vdk.dtb' not remade because of errors.
make: Target 'nvidia/tegra186-p3509-0000+p3636-0001.dtb' not remade because of errors.
make: Target 'nvidia/tegra194-p2972-0000.dtb' not remade because of errors.
make: Target 'nvidia/tegra210-smaug.dtb' not remade because of errors.
make: Target 'nvidia/tegra194-p3509-0000+p3668-0001.dtb' not remade because of errors.
make: Target 'nvidia/tegra234-p3768-0000+p3767-0005.dtb' not remade because of errors.
make: Target 'nvidia/tegra210-p2571.dtb' not remade because of errors.
make: Target 'nvidia/tegra264-p3971-0089+p3834-0008.dtb' not remade because of errors.
make: Target 'nvidia/tegra132-norrin.dtb' not remade because of errors.
make: Target 'nvidia/tegra210-p2894-0050-a08.dtb' not remade because of errors.
Re: [PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Sheetal . 4 months, 1 week ago

On 29-09-2025 20:58, Rob Herring (Arm) wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Mon, 29 Sep 2025 16:29:26 +0530, Sheetal . wrote:
>> From: sheetal <sheetal@nvidia.com>
>>
>> Add device tree support for tegra264 audio subsystem including:
>> - Binding update for
>>    - 64-channel ADMA controller
>>    - 32 RX/TX ADMAIF channels
>>    - tegra264-agic binding for arm,gic
>> - Add device tree nodes for
>>    - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
>>      DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
>>    - HDA controller
>>    - sound
>>
>> Note:
>>   The change is dependent on https://patchwork.ozlabs.org/project/linux-tegra/patch/20250818135241.3407180-1-thierry.reding@gmail.com/
>>
>> ...
>> Changes in V2:
>>   - Update the allOf condition in Patch 2/4.
>>
>> sheetal (4):
>>    dt-bindings: dma: Update ADMA bindings for tegra264
>>    dt-bindings: sound: Update ADMAIF bindings for tegra264
>>    dt-bindings: interrupt-controller: arm,gic: Add tegra264-agic
>>    arm64: tegra: Add tegra264 audio support
>>
>>   .../bindings/dma/nvidia,tegra210-adma.yaml    |   15 +-
>>   .../interrupt-controller/arm,gic.yaml         |    1 +
>>   .../sound/nvidia,tegra210-admaif.yaml         |  106 +-
>>   .../arm64/boot/dts/nvidia/tegra264-p3971.dtsi |  106 +
>>   arch/arm64/boot/dts/nvidia/tegra264.dtsi      | 3190 +++++++++++++++++
>>   5 files changed, 3377 insertions(+), 41 deletions(-)
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>    pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>   Base: attempting to guess base-commit...
>   Base: tags/v6.17-rc1-57-g635ae6f0a3ad (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250929105930.1767294-1-sheetal@nvidia.com:
> 
> In file included from arch/arm64/boot/dts/nvidia/tegra264-p3834.dtsi:3,
>                   from arch/arm64/boot/dts/nvidia/tegra264-p3834-0008.dtsi:3,
>                   from arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dts:5:
> arch/arm64/boot/dts/nvidia/tegra264.dtsi:8:10: fatal error: dt-bindings/power/nvidia,tegra264-powergate.h: No such file or directory

This error is expected.
"dt-bindings/power/nvidia,tegra264-powergate.h" file is being added in 
https://patchwork.ozlabs.org/project/linux-tegra/patch/20250818135241.3407180-1-thierry.reding@gmail.com/, 
in the cover letter it is mentioned as dependent of that change in the 
'Note'.


>      8 | #include <dt-bindings/power/nvidia,tegra264-powergate.h>
>        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[3]: *** [scripts/Makefile.dtbs:132: arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dtb] Error 1
> make[2]: *** [scripts/Makefile.build:556: arch/arm64/boot/dts/nvidia] Error 2
> make[2]: Target 'arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dtb' not remade because of errors.
> make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1480: nvidia/tegra264-p3971-0089+p3834-0008.dtb] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
> make: Target 'nvidia/tegra210-p2371-2180.dtb' not remade because of errors.
> make: Target 'nvidia/tegra210-p3450-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra234-p3737-0000+p3701-0008.dtb' not remade because of errors.
> make: Target 'nvidia/tegra234-p3740-0002+p3701-0008.dtb' not remade because of errors.
> make: Target 'nvidia/tegra234-p3737-0000+p3701-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra186-p2771-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra210-p2371-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra194-p3509-0000+p3668-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra234-p3768-0000+p3767-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra234-sim-vdk.dtb' not remade because of errors.
> make: Target 'nvidia/tegra186-p3509-0000+p3636-0001.dtb' not remade because of errors.
> make: Target 'nvidia/tegra194-p2972-0000.dtb' not remade because of errors.
> make: Target 'nvidia/tegra210-smaug.dtb' not remade because of errors.
> make: Target 'nvidia/tegra194-p3509-0000+p3668-0001.dtb' not remade because of errors.
> make: Target 'nvidia/tegra234-p3768-0000+p3767-0005.dtb' not remade because of errors.
> make: Target 'nvidia/tegra210-p2571.dtb' not remade because of errors.
> make: Target 'nvidia/tegra264-p3971-0089+p3834-0008.dtb' not remade because of errors.
> make: Target 'nvidia/tegra132-norrin.dtb' not remade because of errors.
> make: Target 'nvidia/tegra210-p2894-0050-a08.dtb' not remade because of errors.
> 
> 
> 
> 
>
Re: [PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Krzysztof Kozlowski 4 months ago
On 30/09/2025 15:24, Sheetal . wrote:
> 
> 
> On 29-09-2025 20:58, Rob Herring (Arm) wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On Mon, 29 Sep 2025 16:29:26 +0530, Sheetal . wrote:
>>> From: sheetal <sheetal@nvidia.com>
>>>
>>> Add device tree support for tegra264 audio subsystem including:
>>> - Binding update for
>>>    - 64-channel ADMA controller
>>>    - 32 RX/TX ADMAIF channels
>>>    - tegra264-agic binding for arm,gic
>>> - Add device tree nodes for
>>>    - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
>>>      DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
>>>    - HDA controller
>>>    - sound
>>>
>>> Note:
>>>   The change is dependent on https://patchwork.ozlabs.org/project/linux-tegra/patch/20250818135241.3407180-1-thierry.reding@gmail.com/
>>>
>>> ...
>>> Changes in V2:
>>>   - Update the allOf condition in Patch 2/4.
>>>
>>> sheetal (4):
>>>    dt-bindings: dma: Update ADMA bindings for tegra264
>>>    dt-bindings: sound: Update ADMAIF bindings for tegra264
>>>    dt-bindings: interrupt-controller: arm,gic: Add tegra264-agic
>>>    arm64: tegra: Add tegra264 audio support
>>>
>>>   .../bindings/dma/nvidia,tegra210-adma.yaml    |   15 +-
>>>   .../interrupt-controller/arm,gic.yaml         |    1 +
>>>   .../sound/nvidia,tegra210-admaif.yaml         |  106 +-
>>>   .../arm64/boot/dts/nvidia/tegra264-p3971.dtsi |  106 +
>>>   arch/arm64/boot/dts/nvidia/tegra264.dtsi      | 3190 +++++++++++++++++
>>>   5 files changed, 3377 insertions(+), 41 deletions(-)
>>>
>>> --
>>> 2.34.1
>>>
>>>
>>>
>>
>>
>> My bot found new DTB warnings on the .dts files added or changed in this
>> series.
>>
>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>> are fixed by another series. Ultimately, it is up to the platform
>> maintainer whether these warnings are acceptable or not. No need to reply
>> unless the platform maintainer has comments.
>>
>> If you already ran DT checks and didn't see these error(s), then
>> make sure dt-schema is up to date:
>>
>>    pip3 install dtschema --upgrade
>>
>>
>> This patch series was applied (using b4) to base:
>>   Base: attempting to guess base-commit...
>>   Base: tags/v6.17-rc1-57-g635ae6f0a3ad (exact match)
>>
>> If this is not the correct base, please add 'base-commit' tag
>> (or use b4 which does this automatically)
>>
>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250929105930.1767294-1-sheetal@nvidia.com:
>>
>> In file included from arch/arm64/boot/dts/nvidia/tegra264-p3834.dtsi:3,
>>                   from arch/arm64/boot/dts/nvidia/tegra264-p3834-0008.dtsi:3,
>>                   from arch/arm64/boot/dts/nvidia/tegra264-p3971-0089+p3834-0008.dts:5:
>> arch/arm64/boot/dts/nvidia/tegra264.dtsi:8:10: fatal error: dt-bindings/power/nvidia,tegra264-powergate.h: No such file or directory
> 
> This error is expected.
> "dt-bindings/power/nvidia,tegra264-powergate.h" file is being added in 
> https://patchwork.ozlabs.org/project/linux-tegra/patch/20250818135241.3407180-1-thierry.reding@gmail.com/, 
> in the cover letter it is mentioned as dependent of that change in the 
> 'Note'.
> 
If you expect your patch not to be ignored after such feedback, explain
briefly missing dependency in the patch changelog. Not cover letter.

You will get this report every time and maintainers might ignore your
patch, due to unresolved reports from automation.

Best regards,
Krzysztof
Re: (subset) [PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Mark Brown 3 months, 3 weeks ago
On Mon, 29 Sep 2025 16:29:26 +0530, Sheetal . wrote:
> Add device tree support for tegra264 audio subsystem including:
> - Binding update for
>   - 64-channel ADMA controller
>   - 32 RX/TX ADMAIF channels
>   - tegra264-agic binding for arm,gic
> - Add device tree nodes for
>   - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
>     DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
>   - HDA controller
>   - sound
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[2/4] dt-bindings: sound: Update ADMAIF bindings for tegra264
      commit: 4d410ba9aa275e7990a270f63ce436990ace1bea

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: (subset) [PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Vinod Koul 1 month, 2 weeks ago
On Mon, 29 Sep 2025 16:29:26 +0530, Sheetal . wrote:
> Add device tree support for tegra264 audio subsystem including:
> - Binding update for
>   - 64-channel ADMA controller
>   - 32 RX/TX ADMAIF channels
>   - tegra264-agic binding for arm,gic
> - Add device tree nodes for
>   - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
>     DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
>   - HDA controller
>   - sound
> 
> [...]

Applied, thanks!

[1/4] dt-bindings: dma: Update ADMA bindings for tegra264
      commit: 0b4f3aeee766fd3cc3bf254a26b9761d9b53818b

Best regards,
-- 
~Vinod
Re: (subset) [PATCH V2 0/4] Add tegra264 audio device tree support
Posted by Thierry Reding 3 weeks ago
From: Thierry Reding <treding@nvidia.com>


On Mon, 29 Sep 2025 16:29:26 +0530, Sheetal . wrote:
> From: sheetal <sheetal@nvidia.com>
> 
> Add device tree support for tegra264 audio subsystem including:
> - Binding update for
>   - 64-channel ADMA controller
>   - 32 RX/TX ADMAIF channels
>   - tegra264-agic binding for arm,gic
> - Add device tree nodes for
>   - APE subsystem (ACONNECT, AGIC, ADMA, AHUB and children (ADMAIF, I2S,
>     DMIC, DSPK, MVC, SFC, ASRC, AMX, ADX, OPE and Mixer) nodes
>   - HDA controller
>   - sound
> 
> [...]

Applied, thanks!

[1/4] dt-bindings: dma: Update ADMA bindings for tegra264
      commit: 919f6cd469c605f1de2269d46d04ebf80a1af568

Best regards,
-- 
Thierry Reding <treding@nvidia.com>